Merge branch 'remove-DOMContentLoaded-subscriptions-Pages' into 'master'

Remove DOMContentLoaded Eventlisteners

See merge request gitlab-org/gitlab!47781

ee/app/assets/javascripts/pages/groups/analytics/cycle_analytics/index.js

 import initCycleAnalyticsApp from 'ee/analytics/cycle_analytics/index';
 
-document.addEventListener('DOMContentLoaded', initCycleAnalyticsApp);
+initCycleAnalyticsApp();

ee/app/assets/javascripts/pages/operations/environments/index.js

@@ -2,19 +2,16 @@ import Vue from 'vue';
 import EnvironmentDashboardComponent from 'ee/environments_dashboard/components/dashboard/dashboard.vue';
 import createStore from 'ee/vue_shared/dashboards/store';
 
-document.addEventListener(
-  'DOMContentLoaded',
-  () =>
-    new Vue({
-      el: '#js-environments',
-      store: createStore(),
-      components: {
-        EnvironmentDashboardComponent,
-      },
-      render(createElement) {
-        return createElement(EnvironmentDashboardComponent, {
-          props: this.$el.dataset,
-        });
-      },
-    }),
-);
+// eslint-disable-next-line no-new
+new Vue({
+  el: '#js-environments',
+  store: createStore(),
+  components: {
+    EnvironmentDashboardComponent,
+  },
+  render(createElement) {
+    return createElement(EnvironmentDashboardComponent, {
+      props: this.$el.dataset,
+    });
+  },
+});

ee/app/assets/javascripts/pages/operations/index/index.js

@@ -2,24 +2,21 @@ import Vue from 'vue';
 import createStore from 'ee/vue_shared/dashboards/store';
 import DashboardComponent from 'ee/operations/components/dashboard/dashboard.vue';
 
-document.addEventListener(
-  'DOMContentLoaded',
-  () =>
-    new Vue({
-      el: '#js-operations',
-      store: createStore(),
-      components: {
-        DashboardComponent,
+// eslint-disable-next-line no-new
+new Vue({
+  el: '#js-operations',
+  store: createStore(),
+  components: {
+    DashboardComponent,
+  },
+  render(createElement) {
+    return createElement(DashboardComponent, {
+      props: {
+        listPath: this.$el.dataset.listPath,
+        addPath: this.$el.dataset.addPath,
+        emptyDashboardSvgPath: this.$el.dataset.emptyDashboardSvgPath,
+        emptyDashboardHelpPath: this.$el.dataset.emptyDashboardHelpPath,
       },
-      render(createElement) {
-        return createElement(DashboardComponent, {
-          props: {
-            listPath: this.$el.dataset.listPath,
-            addPath: this.$el.dataset.addPath,
-            emptyDashboardSvgPath: this.$el.dataset.emptyDashboardSvgPath,
-            emptyDashboardHelpPath: this.$el.dataset.emptyDashboardHelpPath,
-          },
-        });
-      },
-    }),
-);
+    });
+  },
+});

ee/app/assets/javascripts/pages/search/show/index.js

 import '~/pages/search/show/index';
 import UserCallout from '~/user_callout';
 
-document.addEventListener('DOMContentLoaded', () => new UserCallout());
+// eslint-disable-next-line no-new
+new UserCallout();

ee/app/assets/javascripts/pages/subscriptions/groups/edit/index.js

@@ -5,9 +5,7 @@ import GroupPathValidator from '~/pages/groups/new/group_path_validator';
 import BindInOut from '~/behaviors/bind_in_out';
 import Group from '~/group';
 
-document.addEventListener('DOMContentLoaded', () => {
-  mountProgressBar();
-  new GroupPathValidator();
-  BindInOut.initAll();
-  new Group();
-});
+mountProgressBar();
+new GroupPathValidator();
+BindInOut.initAll();
+new Group();

ee/app/assets/javascripts/pages/subscriptions/new/index.js

 import mountSubscriptionsApplication from 'ee/subscriptions/new';
 
-document.addEventListener('DOMContentLoaded', () => mountSubscriptionsApplication());
+mountSubscriptionsApplication();