Merge branch 'jv-add-missing-bounds-checks' into 'master'

Add missing bounds checks in LSIF parser

See merge request gitlab-org/gitlab-workhorse!527

internal/lsif_transformer/parser/id.go

@@ -14,7 +14,7 @@ const (
 type Id int32
 
 func (id *Id) UnmarshalJSON(b []byte) error {
-	if b[0] != '"' {
+	if len(b) > 0 && b[0] != '"' {
 		if err := id.unmarshalInt(b); err != nil {
 			return err
 		}

internal/lsif_transformer/parser/ranges.go

@@ -2,6 +2,7 @@ package parser
 
 import (
 	"encoding/json"
+	"errors"
 	"io"
 	"strconv"
 )
@@ -177,6 +178,10 @@ func (r *Ranges) addItem(line []byte) error {
 }
 
 func (r *Ranges) addDefRef(defRef *RawDefRef) error {
+	if len(defRef.RangeIds) == 0 {
+		return errors.New("no range IDs")
+	}
+
 	var rg Range
 	if err := r.Cache.Entry(defRef.RangeIds[0], &rg); err != nil {
 		return err