Merge branch 'first-param-cop' into 'master'

Fix Layout/FirstParameterIndentation cop

See merge request gitlab-org/gitlab!41089

.rubocop_todo.yml

@@ -57,17 +57,6 @@ Layout/FirstArrayElementIndentation:
 Layout/FirstHashElementIndentation:
   Enabled: false
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: consistent, align_parentheses
-Layout/FirstParameterIndentation:
-  Exclude:
-    - 'lib/gitlab/cross_project_access.rb'
-    - 'lib/gitlab/data_builder/push.rb'
-    - 'spec/support/helpers/repo_helpers.rb'
-    - 'spec/support/helpers/stub_object_storage.rb'
-
 # Offense count: 2164
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.

changelogs/unreleased/first-param-cop.yml

+---
+title: Fix Layout/FirstParameterIndentation cop
+merge_request: 41089
+author:
+type: fixed

lib/gitlab/cross_project_access.rb

@@ -18,7 +18,7 @@ module Gitlab
     end
 
     def add_check(
-          klass,
+      klass,
           actions: {},
           positive_condition: nil,
           negative_condition: nil,

lib/gitlab/data_builder/push.rb

@@ -86,7 +86,7 @@ module Gitlab
       #
       # rubocop:disable Metrics/ParameterLists
       def build(
-          project:, user:, ref:, oldrev: nil, newrev: nil,
+        project:, user:, ref:, oldrev: nil, newrev: nil,
           commits: [], commits_count: nil, message: nil, push_options: {},
           with_changed_files: true)
 

spec/support/helpers/repo_helpers.rb

@@ -125,7 +125,7 @@ eos
   end
 
   def create_file_in_repo(
-        project, start_branch, branch_name, filename, content,
+    project, start_branch, branch_name, filename, content,
         commit_message: 'Add new content')
     Files::CreateService.new(
       project,

spec/support/helpers/stub_object_storage.rb

@@ -14,7 +14,7 @@ module StubObjectStorage
   end
 
   def stub_object_storage_uploader(
-        config:,
+    config:,
         uploader:,
         remote_directory:,
         enabled: true,