Apply 1 suggestion(s) to 1 file(s)

app/services/groups/count_service.rb

@@ -30,20 +30,20 @@ module Groups
 
     private
 
+    def relation_for_count
+      raise NotImplementedError
+    end
+
     def cache_options
       super.merge({ expires_in: EXPIRATION_TIME })
     end
 
     def cache_key_name
-      raise NotImplementedError
-    end
-
-    def relation_for_count
-      raise NotImplementedError
+      raise NotImplementedError, 'cache_key_name must be implemented and return a String'
     end
 
     def issuable_key
-      ''
+      raise NotImplementedError, 'issuable_key must be implemented and return a String'
     end
   end
 end

changelogs/unreleased/299178-follow-up-from-cached-sidebar-issues-count-in-group-sidebar.yml

@@ -2,4 +2,4 @@
 title: Cache open merge requests count in group sidebar
 merge_request: 55971
 author:
-type: added
+type: performance

doc/user/project/merge_requests/reviewing_and_managing_merge_requests.md

@@ -28,7 +28,7 @@ You can [search and filter the results](../../search/index.md#filtering-issue-an
 
 ![Group Issues list view](img/group_merge_requests_list_view.png)
 
-## Cached merge request count **(FREE SELF)**
+## Cached merge request count
 
 > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/299542) in GitLab 13.11.
 > - It's [deployed behind a feature flag](../../feature_flags.md), enabled by default.