Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
17b84b6a
Commit
17b84b6a
authored
Feb 19, 2020
by
lauraMon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replaces underscore with lodash and native func
parent
81a5fdac
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
5 deletions
+4
-5
app/assets/javascripts/issuable_suggestions/components/app.vue
...ssets/javascripts/issuable_suggestions/components/app.vue
+1
-2
app/assets/javascripts/issuable_suggestions/components/item.vue
...sets/javascripts/issuable_suggestions/components/item.vue
+3
-3
No files found.
app/assets/javascripts/issuable_suggestions/components/app.vue
View file @
17b84b6a
<
script
>
<
script
>
import
_
from
'
underscore
'
;
import
{
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
__
}
from
'
~/locale
'
;
import
{
__
}
from
'
~/locale
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
...
@@ -48,7 +47,7 @@ export default {
...
@@ -48,7 +47,7 @@ export default {
},
},
computed
:
{
computed
:
{
isSearchEmpty
()
{
isSearchEmpty
()
{
return
_
.
isEmpty
(
this
.
search
)
;
return
!
this
.
search
.
length
;
},
},
showSuggestions
()
{
showSuggestions
()
{
return
!
this
.
isSearchEmpty
&&
this
.
issues
.
length
&&
!
this
.
loading
;
return
!
this
.
isSearchEmpty
&&
this
.
issues
.
length
&&
!
this
.
loading
;
...
...
app/assets/javascripts/issuable_suggestions/components/item.vue
View file @
17b84b6a
<
script
>
<
script
>
/* eslint-disable @gitlab/vue-i18n/no-bare-strings */
/* eslint-disable @gitlab/vue-i18n/no-bare-strings */
import
_
from
'
underscore
'
;
import
{
uniqueId
}
from
'
lodash
'
;
import
{
GlLink
,
GlTooltip
,
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
GlLink
,
GlTooltip
,
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
__
}
from
'
~/locale
'
;
import
{
__
}
from
'
~/locale
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
...
@@ -36,13 +36,13 @@ export default {
...
@@ -36,13 +36,13 @@ export default {
counts
()
{
counts
()
{
return
[
return
[
{
{
id
:
_
.
uniqueId
(),
id
:
uniqueId
(),
icon
:
'
thumb-up
'
,
icon
:
'
thumb-up
'
,
tooltipTitle
:
__
(
'
Upvotes
'
),
tooltipTitle
:
__
(
'
Upvotes
'
),
count
:
this
.
suggestion
.
upvotes
,
count
:
this
.
suggestion
.
upvotes
,
},
},
{
{
id
:
_
.
uniqueId
(),
id
:
uniqueId
(),
icon
:
'
comment
'
,
icon
:
'
comment
'
,
tooltipTitle
:
__
(
'
Comments
'
),
tooltipTitle
:
__
(
'
Comments
'
),
count
:
this
.
suggestion
.
userNotesCount
,
count
:
this
.
suggestion
.
userNotesCount
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment