Commit 18049a7c authored by Lin Jen-Shin's avatar Lin Jen-Shin

Merge branch 'doc-development-gotchas' into 'master'

Docs: Update Gotchas page with comment clarifications

See merge request gitlab-org/gitlab!18593
parents 4f237fda 31756894
...@@ -114,6 +114,7 @@ Instead of writing: ...@@ -114,6 +114,7 @@ Instead of writing:
# Don't do this: # Don't do this:
expect_any_instance_of(Project).to receive(:add_import_job) expect_any_instance_of(Project).to receive(:add_import_job)
# Don't do this:
allow_any_instance_of(Project).to receive(:add_import_job) allow_any_instance_of(Project).to receive(:add_import_job)
``` ```
...@@ -125,6 +126,7 @@ expect_next_instance_of(Project) do |project| ...@@ -125,6 +126,7 @@ expect_next_instance_of(Project) do |project|
expect(project).to receive(:add_import_job) expect(project).to receive(:add_import_job)
end end
# Do this:
allow_next_instance_of(Project) do |project| allow_next_instance_of(Project) do |project|
allow(project).to receive(:add_import_job) allow(project).to receive(:add_import_job)
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment