Merge branch 'xanf-overstubbing' into 'master'

Remove useless stubs for components

See merge request gitlab-org/gitlab!40207

spec/frontend/issuables_list/components/issuable_spec.js

@@ -52,7 +52,6 @@ describe('Issuable component', () => {
       },
       stubs: {
         'gl-sprintf': GlSprintf,
-        'gl-link': '<a><slot></slot></a>',
       },
     });
   };

spec/frontend/packages/list/components/packages_list_spec.js

@@ -18,7 +18,6 @@ describe('packages_list', () => {
   let wrapper;
   let store;
 
-  const GlSortingItem = { name: 'sorting-item-stub', template: '<div><slot></slot></div>' };
   const EmptySlotStub = { name: 'empty-slot-stub', template: '<div>bar</div>' };
 
   const findPackagesListLoader = () => wrapper.find(PackagesListLoader);
@@ -67,7 +66,6 @@ describe('packages_list', () => {
       stubs: {
         ...stubChildren(PackagesList),
         GlTable,
-        GlSortingItem,
         GlModal,
       },
       ...options,

spec/frontend/packages/list/components/packages_sort_spec.js

 import Vuex from 'vuex';
-import { GlSorting } from '@gitlab/ui';
+import { GlSorting, GlSortingItem } from '@gitlab/ui';
 import { mount, createLocalVue } from '@vue/test-utils';
 import stubChildren from 'helpers/stub_children';
 import PackagesSort from '~/packages/list/components/packages_sort.vue';
@@ -13,8 +13,6 @@ describe('packages_sort', () => {
   let sorting;
   let sortingItems;
 
-  const GlSortingItem = { name: 'sorting-item-stub', template: '<div><slot></slot></div>' };
-
   const findPackageListSorting = () => wrapper.find(GlSorting);
   const findSortingItems = () => wrapper.findAll(GlSortingItem);
 

spec/frontend/vue_shared/components/filtered_search_bar/tokens/author_token_spec.js

@@ -23,9 +23,7 @@ const createComponent = ({ config = mockAuthorToken, value = { data: '' }, activ
       alignSuggestions: function fakeAlignSuggestions() {},
     },
     stubs: {
-      Portal: {
-        template: '<div><slot></slot></div>',
-      },
+      Portal: true,
       GlFilteredSearchSuggestionList: {
         template: '<div></div>',
         methods: {

spec/frontend/vue_shared/components/filtered_search_bar/tokens/label_token_spec.js

@@ -27,9 +27,7 @@ const createComponent = ({ config = mockLabelToken, value = { data: '' }, active
       alignSuggestions: function fakeAlignSuggestions() {},
     },
     stubs: {
-      Portal: {
-        template: '<div><slot></slot></div>',
-      },
+      Portal: true,
       GlFilteredSearchSuggestionList: {
         template: '<div></div>',
         methods: {

spec/frontend/vue_shared/components/filtered_search_bar/tokens/milestone_token_spec.js

@@ -32,9 +32,7 @@ const createComponent = ({
       alignSuggestions: function fakeAlignSuggestions() {},
     },
     stubs: {
-      Portal: {
-        template: '<div><slot></slot></div>',
-      },
+      Portal: true,
       GlFilteredSearchSuggestionList: {
         template: '<div></div>',
         methods: {