Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1861b865
Commit
1861b865
authored
Jul 16, 2020
by
Alina Mihaila
Committed by
Russell Dickenson
Jul 16, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update database review docs to link to Telemetry guide
parent
1ad2429e
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
0 deletions
+4
-0
doc/development/database_review.md
doc/development/database_review.md
+4
-0
No files found.
doc/development/database_review.md
View file @
1861b865
...
@@ -19,6 +19,10 @@ A database review is required for:
...
@@ -19,6 +19,10 @@ A database review is required for:
generally up to the author of a merge request to decide whether or
generally up to the author of a merge request to decide whether or
not complex queries are being introduced and if they require a
not complex queries are being introduced and if they require a
database review.
database review.
-
Changes in usage data metrics that use
`count`
and
`distinct_count`
.
These metrics could have complex queries over large tables.
See the
[
Telemetry Guide
](
telemetry/usage_ping.md#implementing-usage-ping
)
for implementation details.
A database reviewer is expected to look out for obviously complex
A database reviewer is expected to look out for obviously complex
queries in the change and review those closer. If the author does not
queries in the change and review those closer. If the author does not
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment