Merge branch 'ph/addMissingMetricDefinition' into 'master'

Added missing metric definion for diff settings

See merge request gitlab-org/gitlab!63411

config/metrics/aggregates/code_review.yml

@@ -52,6 +52,7 @@
     - 'i_code_review_user_reviewers_changed'
     - 'i_code_review_user_milestone_changed'
     - 'i_code_review_user_labels_changed'
+    - 'i_code_review_click_diff_view_setting'
     - 'i_code_review_click_single_file_mode_setting'
     - 'i_code_review_click_file_browser_setting'
     - 'i_code_review_click_whitespace_setting'
@@ -109,6 +110,7 @@
     - 'i_code_review_user_reviewers_changed'
     - 'i_code_review_user_milestone_changed'
     - 'i_code_review_user_labels_changed'
+    - 'i_code_review_click_diff_view_setting'
     - 'i_code_review_click_single_file_mode_setting'
     - 'i_code_review_click_file_browser_setting'
     - 'i_code_review_click_whitespace_setting'

config/metrics/counts_28d/20210607113556_i_code_review_click_diff_view_setting_monthly.yml

+---
+key_path: redis_hll_counters.code_review.i_code_review_click_diff_view_setting_monthly
+description: Count of users clicking diff view setting
+product_section: dev
+product_stage: create
+product_group: group::code review
+product_category: code_review
+value_type: number
+status: implemented
+milestone: '13.12'
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/59979
+time_frame: 28d
+data_source: redis_hll
+distribution:
+  - ce
+tier:
+  - free
+  - premium
+  - ultimate

config/metrics/counts_7d/20210607113552_i_code_review_click_diff_view_setting_weekly.yml

+---
+key_path: redis_hll_counters.code_review.i_code_review_click_diff_view_setting_weekly
+description: Count of users clicking diff view setting
+product_section: dev
+product_stage: create
+product_group: group::code review
+product_category: code_review
+value_type: number
+status: implemented
+milestone: '13.12'
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/59979
+time_frame: 7d
+data_source: redis_hll
+distribution:
+  - ce
+tier:
+  - free
+  - premium
+  - ultimate

doc/development/usage_ping/dictionary.md

@@ -8614,6 +8614,30 @@ Status: `data_available`
 
 Tiers: `free`, `premium`, `ultimate`
 
+### `redis_hll_counters.code_review.i_code_review_click_diff_view_setting_monthly`
+
+Count of users clicking diff view setting
+
+[YAML definition](https://gitlab.com/gitlab-org/gitlab/-/blob/master/config/metrics/counts_28d/20210607113556_i_code_review_click_diff_view_setting_monthly.yml)
+
+Group: `group::code review`
+
+Status: `implemented`
+
+Tiers: `free`, `premium`, `ultimate`
+
+### `redis_hll_counters.code_review.i_code_review_click_diff_view_setting_weekly`
+
+Count of users clicking diff view setting
+
+[YAML definition](https://gitlab.com/gitlab-org/gitlab/-/blob/master/config/metrics/counts_7d/20210607113552_i_code_review_click_diff_view_setting_weekly.yml)
+
+Group: `group::code review`
+
+Status: `implemented`
+
+Tiers: `free`, `premium`, `ultimate`
+
 ### `redis_hll_counters.code_review.i_code_review_click_file_browser_setting_monthly`
 
 Count of users clicking merge request file browser setting

lib/gitlab/usage_data_counters/known_events/code_review_events.yml

@@ -164,6 +164,11 @@
   category: code_review
   aggregation: weekly
 # Diff settings events
+- name: i_code_review_click_diff_view_setting
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: diff_settings_usage_data
 - name: i_code_review_click_single_file_mode_setting
   redis_slot: code_review
   category: code_review