Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1a3f200a
Commit
1a3f200a
authored
May 06, 2021
by
Paul Gascou-Vaillancourt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a comment about bugged sortKey feature
parent
06c868c3
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
0 deletions
+6
-0
app/assets/javascripts/incidents/components/incidents_list.vue
...ssets/javascripts/incidents/components/incidents_list.vue
+6
-0
No files found.
app/assets/javascripts/incidents/components/incidents_list.vue
View file @
1a3f200a
...
@@ -261,6 +261,12 @@ export default {
...
@@ -261,6 +261,12 @@ export default {
const
sortingDirection
=
sortDesc
?
'
DESC
'
:
'
ASC
'
;
const
sortingDirection
=
sortDesc
?
'
DESC
'
:
'
ASC
'
;
this
.
pagination
=
initialPaginationState
;
this
.
pagination
=
initialPaginationState
;
// BootstapVue natively supports a `sortKey` parameter, but using it results in the sorting
// icons not being updated properly in the header. We decided to fallback on `actualSortKey`
// to bypass BootstrapVue's behavior until the bug is addressed upstream.
// Related discussion: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60926/diffs#note_568020482
// Upstream issue: https://github.com/bootstrap-vue/bootstrap-vue/issues/6602
this
.
sort
=
`
${
field
.
actualSortKey
}
_
${
sortingDirection
}
`
;
this
.
sort
=
`
${
field
.
actualSortKey
}
_
${
sortingDirection
}
`
;
},
},
getSeverity
(
severity
)
{
getSeverity
(
severity
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment