Merge branch 'reset-job-token-scope-enabled-2' into 'master'

Reset job_token_scope_enabled setting to false

See merge request gitlab-org/gitlab!65725

db/post_migrate/20210628124505_reset_job_token_scope_enabled.rb

+# frozen_string_literal: true
+
+class ResetJobTokenScopeEnabled < ActiveRecord::Migration[6.1]
+  include Gitlab::Database::MigrationHelpers
+
+  def up
+    with_lock_retries do
+      remove_column :project_ci_cd_settings, :job_token_scope_enabled
+      add_column :project_ci_cd_settings, :job_token_scope_enabled, :boolean, default: false, null: false
+    end
+  end
+
+  def down
+    # Irreversible
+  end
+end

db/schema_migrations/20210628124505

+7add197fec50d8da5bcdbca83115558480668c26ad3a3fefc4ab93c07f34f63a
\ No newline at end of file

spec/migrations/reset_job_token_scope_enabled_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+require_migration!
+
+RSpec.describe ResetJobTokenScopeEnabled do
+  let(:settings) { table(:project_ci_cd_settings) }
+  let(:projects) { table(:projects) }
+  let(:namespaces) { table(:namespaces) }
+  let(:namespace) { namespaces.create!(name: 'gitlab', path: 'gitlab-org') }
+  let(:project_1) { projects.create!(name: 'proj-1', path: 'gitlab-org', namespace_id: namespace.id)}
+  let(:project_2) { projects.create!(name: 'proj-2', path: 'gitlab-org', namespace_id: namespace.id)}
+
+  before do
+    settings.create!(id: 1, project_id: project_1.id, job_token_scope_enabled: true)
+    settings.create!(id: 2, project_id: project_2.id, job_token_scope_enabled: false)
+  end
+
+  it 'migrates job_token_scope_enabled to be always false' do
+    expect { migrate! }
+      .to change { settings.where(job_token_scope_enabled: false).count }
+      .from(1).to(2)
+  end
+end