Merge branch 'rails-save-bang-1' into 'master'

Refactor boards controller spec with SaveBang Cop

See merge request gitlab-org/gitlab!36582

.rubocop_todo.yml

@@ -738,8 +738,6 @@ Style/SymbolProc:
 # Configuration parameters: AllowImplicitReturn, AllowedReceivers.
 Rails/SaveBang:
   Exclude:
-    - 'ee/spec/controllers/boards/issues_controller_spec.rb'
-    - 'ee/spec/controllers/boards/lists_controller_spec.rb'
     - 'ee/spec/controllers/ee/sent_notifications_controller_spec.rb'
     - 'ee/spec/controllers/groups/epic_issues_controller_spec.rb'
     - 'ee/spec/controllers/groups/epic_links_controller_spec.rb'

changelogs/unreleased/rails-save-bang-1.yml

+---
+title: Refactor issues controller spec to fix SaveBang Cop
+merge_request: 36582
+author: Rajendra Kadam
+type: fixed

ee/spec/controllers/boards/issues_controller_spec.rb

@@ -123,7 +123,7 @@ RSpec.describe Boards::IssuesController do
 
     context 'with unauthorized user' do
       before do
-        group.group_member(user).destroy
+        group.group_member(user).destroy!
       end
 
       it 'returns a forbidden 403 response' do

ee/spec/controllers/boards/lists_controller_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe Boards::ListsController do
 
     context 'with unauthorized user' do
       before do
-        group.group_member(user).destroy
+        group.group_member(user).destroy!
       end
 
       it 'returns a forbidden 403 response' do