Merge branch 'fix_product_intelligenc_dangerbot_pipeline' into 'master'

Fix dangerbot pipeline failures

See merge request gitlab-org/gitlab!55374

danger/product_intelligence/Dangerfile

@@ -69,7 +69,7 @@ snowplow_changed_files = all_changed_files.select do |file|
     matching_files?(file, extension: '.haml', pattern: %r{data: \{ track})
 end
 
-required_dictionary_update_changed_files = dictionary_changed_file.select do |file|
+required_dictionary_update_changed_files = metrics_changed_files.select do |file|
   matching_files?(file, extension: '.yml', pattern: dictionary_pattern)
 end
 
@@ -89,7 +89,7 @@ if matching_changed_files.any?
 
   warn format(CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(matching_changed_files), engineers_group: mention)
 
-  fail format(UPDATE_DICTIONARY_MESSAGE) if metrics_changed_files.any? && required_dictionary_update_changed_files.empty?
+  fail format(UPDATE_DICTIONARY_MESSAGE) if required_dictionary_update_changed_files.any? && dictionary_changed_file.empty?
 
   labels = ['product intelligence']
   labels << 'product intelligence::review pending' unless helper.mr_has_labels?('product intelligence::approved')