Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1e1ebea6
Commit
1e1ebea6
authored
Jun 10, 2020
by
peterhegman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Migrate `GlDeprecatedButton` to `GlButton`
parent
22e6de6e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
15 deletions
+18
-15
app/assets/javascripts/error_tracking/components/error_details.vue
...s/javascripts/error_tracking/components/error_details.vue
+15
-12
spec/frontend/error_tracking/components/error_details_spec.js
.../frontend/error_tracking/components/error_details_spec.js
+3
-3
No files found.
app/assets/javascripts/error_tracking/components/error_details.vue
View file @
1e1ebea6
...
...
@@ -2,7 +2,7 @@
import
{
mapActions
,
mapGetters
,
mapState
}
from
'
vuex
'
;
import
createFlash
from
'
~/flash
'
;
import
{
Gl
Deprecated
Button
,
GlButton
,
GlFormInput
,
GlLink
,
GlLoadingIcon
,
...
...
@@ -33,7 +33,7 @@ const SENTRY_TIMEOUT = 10000;
export
default
{
components
:
{
Gl
Deprecated
Button
,
GlButton
,
GlFormInput
,
GlLink
,
GlLoadingIcon
,
...
...
@@ -279,22 +279,24 @@ export default {
</div>
<div
class=
"error-details-actions"
>
<div
class=
"d-inline-flex bv-d-sm-down-none"
>
<gl-
deprecated-
button
<gl-button
:loading=
"updatingIgnoreStatus"
data-testid=
"update-ignore-status-btn"
@
click=
"onIgnoreStatusUpdate"
>
{{ ignoreBtnLabel }}
</gl-deprecated-button>
<gl-deprecated-button
class=
"btn-outline-info ml-2"
</gl-button>
<gl-button
class=
"ml-2"
category=
"secondary"
variant=
"info"
:loading=
"updatingResolveStatus"
data-testid=
"update-resolve-status-btn"
@
click=
"onResolveStatusUpdate"
>
{{ resolveBtnLabel }}
</gl-
deprecated-
button>
<gl-
deprecated-
button
</gl-button>
<gl-button
v-if=
"error.gitlabIssuePath"
class=
"ml-2"
data-testid=
"view_issue_button"
...
...
@@ -302,7 +304,7 @@ export default {
variant=
"success"
>
{{ __('View issue') }}
</gl-
deprecated-
button>
</gl-button>
<form
ref=
"sentryIssueForm"
:action=
"projectIssuesPath"
...
...
@@ -317,15 +319,16 @@ export default {
name=
"issue[sentry_issue_attributes][sentry_issue_identifier]"
/>
<gl-form-input
:value=
"csrfToken"
class=
"hidden"
name=
"authenticity_token"
/>
<gl-
deprecated-
button
<gl-button
v-if=
"!error.gitlabIssuePath"
class=
"btn-success"
category=
"primary"
variant=
"success"
:loading=
"issueCreationInProgress"
data-qa-selector=
"create_issue_button"
@
click=
"createIssue"
>
{{ __('Create issue') }}
</gl-
deprecated-
button>
</gl-button>
</form>
</div>
<gl-dropdown
...
...
spec/frontend/error_tracking/components/error_details_spec.js
View file @
1e1ebea6
...
...
@@ -3,7 +3,7 @@ import Vuex from 'vuex';
import
{
__
}
from
'
~/locale
'
;
import
createFlash
from
'
~/flash
'
;
import
{
Gl
Deprecated
Button
,
GlButton
,
GlLoadingIcon
,
GlLink
,
GlBadge
,
...
...
@@ -52,7 +52,7 @@ describe('ErrorDetails', () => {
function
mountComponent
()
{
wrapper
=
shallowMount
(
ErrorDetails
,
{
stubs
:
{
Gl
Deprecated
Button
,
GlSprintf
},
stubs
:
{
GlButton
,
GlSprintf
},
localVue
,
store
,
mocks
,
...
...
@@ -195,7 +195,7 @@ describe('ErrorDetails', () => {
expect
(
wrapper
.
find
(
GlLoadingIcon
).
exists
()).
toBe
(
true
);
expect
(
wrapper
.
find
(
Stacktrace
).
exists
()).
toBe
(
false
);
expect
(
wrapper
.
find
(
GlBadge
).
exists
()).
toBe
(
false
);
expect
(
wrapper
.
findAll
(
Gl
Deprecated
Button
).
length
).
toBe
(
3
);
expect
(
wrapper
.
findAll
(
GlButton
).
length
).
toBe
(
3
);
});
describe
(
'
unsafe chars for culprit field
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment