Merge branch 'public_generic_packages' into 'master'

Public generic packages

See merge request gitlab-org/gitlab!55978

changelogs/unreleased/public_generic_packages.yml

+---
+title: Public generic packages can now be accessed by developer, guest and anonymous users
+merge_request: 55978
+author: Mathieu Parent
+type: changed

lib/api/generic_packages.rb

@@ -13,7 +13,7 @@ module API
 
     before do
       require_packages_enabled!
-      authenticate!
+      authenticate_non_get!
 
       require_generic_packages_available!
     end

spec/requests/api/generic_packages_spec.rb

@@ -444,17 +444,17 @@ RSpec.describe API::GenericPackages do
         'PUBLIC'  | :guest     | true  | :user_basic_auth               | :success
         'PUBLIC'  | :developer | true  | :invalid_personal_access_token | :unauthorized
         'PUBLIC'  | :guest     | true  | :invalid_personal_access_token | :unauthorized
-        'PUBLIC'  | :developer | true  | :invalid_user_basic_auth       | :unauthorized
-        'PUBLIC'  | :guest     | true  | :invalid_user_basic_auth       | :unauthorized
+        'PUBLIC'  | :developer | true  | :invalid_user_basic_auth       | :success
+        'PUBLIC'  | :guest     | true  | :invalid_user_basic_auth       | :success
         'PUBLIC'  | :developer | false | :personal_access_token         | :success
         'PUBLIC'  | :guest     | false | :personal_access_token         | :success
         'PUBLIC'  | :developer | false | :user_basic_auth               | :success
         'PUBLIC'  | :guest     | false | :user_basic_auth               | :success
         'PUBLIC'  | :developer | false | :invalid_personal_access_token | :unauthorized
         'PUBLIC'  | :guest     | false | :invalid_personal_access_token | :unauthorized
-        'PUBLIC'  | :developer | false | :invalid_user_basic_auth       | :unauthorized
-        'PUBLIC'  | :guest     | false | :invalid_user_basic_auth       | :unauthorized
-        'PUBLIC'  | :anonymous | false | :none                          | :unauthorized
+        'PUBLIC'  | :developer | false | :invalid_user_basic_auth       | :success
+        'PUBLIC'  | :guest     | false | :invalid_user_basic_auth       | :success
+        'PUBLIC'  | :anonymous | false | :none                          | :success
         'PRIVATE' | :developer | true  | :personal_access_token         | :success
         'PRIVATE' | :guest     | true  | :personal_access_token         | :forbidden
         'PRIVATE' | :developer | true  | :user_basic_auth               | :success