Merge branch '247870-nomethoderror-saving-jira-integration-with-invalid-credentials' into 'master'

Resolve "NoMethodError - Saving Jira integration with invalid credentials"

Closes #247870

See merge request gitlab-org/gitlab!42361

app/models/project_services/jira_service.rb

@@ -439,7 +439,8 @@ class JiraService < IssueTrackerService
   end
 
   def update_deployment_type?
-    api_url_changed? || url_changed? || username_changed? || password_changed?
+    (api_url_changed? || url_changed? || username_changed? || password_changed?) &&
+      can_test?
   end
 
   def update_deployment_type

changelogs/unreleased/247870-nomethoderror-saving-jira-integration-with-invalid-credentials.yml

+---
+title: Fix exception when saving Jira integration info for an instance
+merge_request: 42361
+author:
+type: fixed

spec/models/project_services/jira_service_spec.rb

@@ -254,6 +254,16 @@ RSpec.describe JiraService do
           end
         end
 
+        context 'when not allowed to test an instance or group' do
+          it 'does not update deployment type' do
+            allow(service).to receive(:can_test?).and_return(false)
+
+            service.update!(url: 'http://first.url')
+
+            expect(WebMock).not_to have_requested(:get, /serverInfo/)
+          end
+        end
+
         context 'stored password invalidation' do
           context 'when a password was previously set' do
             context 'when only web url present' do