Commit 201aba9b authored by Mark Lapierre's avatar Mark Lapierre

Merge branch 'qa-improve-add-comment-to-snippet-spec' into 'master'

Avoid flakiness by introducing more conditional waiting

See merge request gitlab-org/gitlab!45236
parents 5be4c49d 31965622
...@@ -170,6 +170,7 @@ module QA ...@@ -170,6 +170,7 @@ module QA
def add_comment(comment) def add_comment(comment)
fill_element(:note_field, comment) fill_element(:note_field, comment)
click_element(:comment_button) click_element(:comment_button)
wait_until(reload: false) { has_element?(:note_author_content) }
end end
def has_comment_author?(author_username) def has_comment_author?(author_username)
...@@ -194,6 +195,7 @@ module QA ...@@ -194,6 +195,7 @@ module QA
click_element(:edit_comment_button) click_element(:edit_comment_button)
fill_element(:edit_note_field, comment) fill_element(:edit_note_field, comment)
click_element(:save_comment_button) click_element(:save_comment_button)
wait_until(reload: false) { has_element?(:note_author_content) }
end end
def delete_comment(comment) def delete_comment(comment)
...@@ -201,6 +203,7 @@ module QA ...@@ -201,6 +203,7 @@ module QA
accept_alert do accept_alert do
click_element(:delete_comment_button) click_element(:delete_comment_button)
end end
wait_until(reload: false) { has_no_text?(comment) }
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment