Commit 202ab628 authored by Douwe Maan's avatar Douwe Maan

Merge branch 'fix-conflict-highlighting' into 'master'

Fix conflict highlighting

See merge request gitlab-org/gitlab-ce!15463
parents 77350d96 64a9e53b
...@@ -996,10 +996,6 @@ class Repository ...@@ -996,10 +996,6 @@ class Repository
raw_repository.ls_files(actual_ref) raw_repository.ls_files(actual_ref)
end end
def gitattribute(path, name)
raw_repository.attributes(path)[name]
end
def copy_gitattributes(ref) def copy_gitattributes(ref)
actual_ref = ref || root_ref actual_ref = ref || root_ref
begin begin
......
...@@ -984,6 +984,10 @@ module Gitlab ...@@ -984,6 +984,10 @@ module Gitlab
@attributes.attributes(path) @attributes.attributes(path)
end end
def gitattribute(path, name)
attributes(path)[name]
end
def languages(ref = nil) def languages(ref = nil)
Gitlab::GitalyClient.migrate(:commit_languages) do |is_enabled| Gitlab::GitalyClient.migrate(:commit_languages) do |is_enabled|
if is_enabled if is_enabled
......
...@@ -84,6 +84,13 @@ describe Gitlab::Conflict::File do ...@@ -84,6 +84,13 @@ describe Gitlab::Conflict::File do
expect(line.text).to eq(html_to_text(line.rich_text)) expect(line.text).to eq(html_to_text(line.rich_text))
end end
end end
# This spec will break if Rouge's highlighting changes, but we need to
# ensure that the lines are actually highlighted.
it 'highlights the lines correctly' do
expect(conflict_file.lines.first.rich_text)
.to eq("<span id=\"LC1\" class=\"line\" lang=\"ruby\"><span class=\"k\">module</span> <span class=\"nn\">Gitlab</span></span>\n")
end
end end
describe '#sections' do describe '#sections' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment