add save tests

app/assets/javascripts/boards/stores/boards_store.js

@@ -408,6 +408,29 @@ const boardsStore = {
     return axios.delete(`${this.state.endpoints.listsEndpoint}/${id}`);
   },
 
+  saveList(list) {
+    const entity = list.label || list.assignee || list.milestone;
+    let entityType = '';
+    if (list.label) {
+      entityType = 'label_id';
+    } else if (list.assignee) {
+      entityType = 'assignee_id';
+    } else if (IS_EE && list.milestone) {
+      entityType = 'milestone_id';
+    }
+
+    return this.createList(entity.id, entityType)
+      .then(res => res.data)
+      .then(data => {
+        list.id = data.id;
+        list.type = data.list_type;
+        list.position = data.position;
+        list.label = data.label;
+
+        return list.getIssues();
+      });
+  },
+
   getIssuesForList(id, filter = {}) {
     const data = { id };
     Object.keys(filter).forEach(key => {
@@ -525,29 +548,6 @@ const boardsStore = {
   clearMultiSelect() {
     this.multiSelect.list = [];
   },
-
-  saveList(list) {
-    const entity = list.label || list.assignee || list.milestone;
-    let entityType = '';
-    if (list.label) {
-      entityType = 'label_id';
-    } else if (list.assignee) {
-      entityType = 'assignee_id';
-    } else if (IS_EE && list.milestone) {
-      entityType = 'milestone_id';
-    }
-
-    return this.createList(entity.id, entityType)
-      .then(res => res.data)
-      .then(data => {
-        list.id = data.id;
-        list.type = data.list_type;
-        list.position = data.position;
-        list.label = data.label;
-
-        return list.getIssues();
-      });
-  },
 };
 
 BoardsStoreEE.initEESpecific(boardsStore);

spec/frontend/boards/boards_store_spec.js

@@ -189,6 +189,42 @@ describe('boardsStore', () => {
         });
     });
   });
+  
+  describe('saveList',() => {
+    const entityType = 'moorhen';
+    const entity.id = 'quack';
+    const expectedRequest = expect.objectContaining({
+      data: JSON.stringify({ list: { [entityType]: entityId } }),
+    });
+
+    let requestSpy;
+
+    beforeEach(() => {
+      requestSpy = jest.fn();
+      axiosMock.onPost(endpoints.listsEndpoint).replyOnce(config => requestSpy(config));
+    });
+
+    it('makes a request to save a list', () => {
+      requestSpy.mockReturnValue([200, dummyResponse]);
+      const expectedResponse = expect.objectContaining({ data: dummyResponse });
+
+      return expect(boardsStore.saveList(this))
+        .resolves.toEqual(expectedResponse)
+        .then(() => {
+          expect(requestSpy).toHaveBeenCalledWith(expectedRequest);
+        });
+    });
+
+    it('fails for error response', () => {
+      requestSpy.mockReturnValue([500]);
+
+      return expect(boardsStore.saveList(this))
+        .rejects.toThrow()
+        .then(() => {
+          expect(requestSpy).toHaveBeenCalledWith(expectedRequest);
+        });
+    });
+  }); 
 
   describe('getIssuesForList', () => {
     const id = 'TOO-MUCH';
@@ -575,6 +611,7 @@ describe('boardsStore', () => {
     });
   });
 
+
   describe('when created', () => {
     beforeEach(() => {
       setupDefaultResponses();