Make 'package-and-qa' actually depending on 'build-assets-image'

Also, update the documentation accordingly.
Signed-off-by: Rémy Coutable <remy@rymai.me>

.gitlab/ci/qa.gitlab-ci.yml

@@ -58,5 +58,5 @@ package-and-qa:
   needs:
     - job: build-qa-image
       artifacts: false
-    - job: gitlab:assets:compile pull-cache
+    - job: build-assets-image
       artifacts: false

doc/development/pipelines.md

@@ -237,7 +237,6 @@ graph RL;
   click 2_1-3 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356729&udv=0"
   2_1-4["run-dev-fixtures-ee (5 minutes)"];
   click 2_1-4 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356731&udv=0"
-
   subgraph "Needs `setup-test-env`";
     2_1-1 & 2_1-2 & 2_1-3 & 2_1-4 --> 1-6;
   end
@@ -253,28 +252,27 @@ graph RL;
   click 2_2-4 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356727&udv=0"
   2_2-5["webpack-dev-server (7.62 minutes)"];
   click 2_2-5 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8404303&udv=0"
-
-  2_3-1["build-assets-image"];
-  class 2_3-1 criticalPath;
-
   subgraph "Needs `setup-test-env` & `compile-assets`";
     2_2-1 & 2_2-2 & 2_2-4 & 2_2-5 --> 1-6 & 1-3;
     2_2-3 --> 1-6 & 1-4;
   end
 
+  2_3-1["build-assets-image (2.5 minutes)"];
   subgraph "Needs `gitlab:assets:compile`";
     2_3-1 --> 1-5
   end
 
-  subgraph "Needs `build-qa-image` & `build-assets-image`";
-    2_4-1["package-and-qa (manual)"] --> 1-2 & 2_3-1;
+  2_4-1["package-and-qa (manual)"];
+  subgraph "Needs `build-qa-image`";
+    2_4-1 --> 1-2;
     click 2_4-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914305&udv=0"
   end
 
-  subgraph "Needs `compile-assets`, `setup-test-env, & `retrieve-tests-metadata`";
-    2_4-1["rspec & db jobs (12-22 minutes)"] --> 1-3 & 1-6 & 1-14;
-    class 2_4-1 criticalPath;
-    click 2_4-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations"
+  2_5-1["rspec & db jobs (12-22 minutes)"];
+  subgraph "Needs `compile-assets`, `setup-test-env`, & `retrieve-tests-metadata`";
+    2_5-1 --> 1-3 & 1-6 & 1-14;
+    class 2_5-1 criticalPath;
+    click 2_5-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations"
   end
 
   3_1-1["jest (11.2 minutes)"];
@@ -286,20 +284,21 @@ graph RL;
   click 3_1-3 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914205&udv=0"
   3_1-4["karma-as-if-foss (8.25 minutes)"];
   click 3_1-4 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914203&udv=0"
-
   subgraph "Needs `frontend-fixtures`";
     3_1-1 & 3_1-2 --> 2_2-2;
     3_1-3 & 3_1-4 --> 2_2-3;
   end
 
+  3_2-1["rspec:coverage (7.67 minutes)"];
   subgraph "Depends on `rspec` jobs";
-    3_2-1["rspec:coverage (7.67 minutes)"] -.->|"(don't use needs because of limitations)"| 2_4-1;
+    3_2-1 -.->|"(don't use needs because of limitations)"| 2_5-1;
     class 3_2-1 criticalPath;
     click 3_2-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=7248745&udv=0"
   end
 
+  4_1-1["coverage-frontend (5.39 minutes)"];
   subgraph "Needs `jest`";
-    4_1-1["coverage-frontend (5.39 minutes)"] --> 3_1-1;
+    4_1-1 --> 3_1-1;
     class 4_1-1 criticalPath;
     click 4_1-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=7910777&udv=0"
   end
@@ -352,7 +351,6 @@ graph RL;
   click 2_1-3 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356729&udv=0"
   2_1-4["run-dev-fixtures-ee (5 minutes)"];
   click 2_1-4 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356731&udv=0"
-
   subgraph "Needs `setup-test-env`";
     2_1-1 & 2_1-2 & 2_1-3 & 2_1-4 --> 1-6;
   end
@@ -368,32 +366,33 @@ graph RL;
   click 2_2-4 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356727&udv=0"
   2_2-5["webpack-dev-server (7.62 minutes)"];
   click 2_2-5 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8404303&udv=0"
-
-  2_3-1["build-assets-image"];
-  class 2_3-1 criticalPath;
-
   subgraph "Needs `setup-test-env` & `compile-assets`";
     2_2-1 & 2_2-2 & 2_2-4 & 2_2-5 --> 1-6 & 1-3;
     2_2-3 --> 1-6 & 1-4;
   end
 
+  2_3-1["build-assets-image (2.5 minutes)"];
+  class 2_3-1 criticalPath;
   subgraph "Needs `gitlab:assets:compile`";
     2_3-1 --> 1-5
   end
 
+  2_4-1["package-and-qa (manual)"];
   subgraph "Needs `build-qa-image` & `build-assets-image`";
-    2_4-1["package-and-qa (manual)"] --> 1-2 & 2_3-1;
+    2_4-1 --> 1-2 & 2_3-1;
     click 2_4-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914305&udv=0"
   end
 
+  2_5-1["rspec & db jobs (12-22 minutes)"];
   subgraph "Needs `compile-assets`, `setup-test-env, & `retrieve-tests-metadata`";
-    2_5-1["rspec & db jobs (12-22 minutes)"] --> 1-3 & 1-6 & 1-14;
+    2_5-1 --> 1-3 & 1-6 & 1-14;
     class 2_5-1 criticalPath;
     click 2_5-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations"
   end
 
+  2_6-1["review-build-cng (27.3 minutes)"];
   subgraph "Needs `build-assets-image`";
-    2_6-1["review-build-cng (27.3 minutes)"] --> 2_3-1;
+    2_6-1 --> 2_3-1;
     class 2_6-1 criticalPath;
     click 2_6-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914314&udv=0"
   end
@@ -407,38 +406,39 @@ graph RL;
   click 3_1-3 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914205&udv=0"
   3_1-4["karma-as-if-foss (8.25 minutes)"];
   click 3_1-4 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914203&udv=0"
-
   subgraph "Needs `frontend-fixtures`";
     3_1-1 & 3_1-3 --> 2_2-2;
     3_1-2 & 3_1-4 --> 2_2-3;
   end
 
+  3_2-1["rspec:coverage (7.67 minutes)"];
   subgraph "Depends on `rspec` jobs";
-    3_2-1["rspec:coverage (7.67 minutes)"] -.->|"(don't use needs because of limitations)"| 2_5-1;
+    3_2-1 -.->|"(don't use needs because of limitations)"| 2_5-1;
     class 3_2-1 criticalPath;
     click 3_2-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=7248745&udv=0"
   end
 
+  4_1-1["coverage-frontend (5.39 minutes)"];
   subgraph "Needs `jest`";
-    4_1-1["coverage-frontend (5.39 minutes)"] --> 3_1-1;
+    4_1-1 --> 3_1-1;
     class 4_1-1 criticalPath;
     click 4_1-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=7910777&udv=0"
   end
 
+  3_3-1["review-deploy (6 minutes)"];
   subgraph "Played by `review-build-cng`";
-    3_3-1["review-deploy (6 minutes)"] --> 2_6-1;
+    3_3-1 --> 2_6-1;
     class 3_3-1 criticalPath;
     click 3_3-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6721130&udv=0"
   end
 
   4_2-1["review-qa-smoke (7.29 minutes)"];
-  class 4_2-1 criticalPath;
   click 4_2-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6729805&udv=0"
   4_2-2["review-performance (3.83 minutes)"];
   click 4_2-2 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356817&udv=0"
-  4_2-3["dast (16.4 minutes)"];
+  4_2-3["dast (18 minutes)"];
   click 4_2-3 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356819&udv=0"
-
+  class 4_2-3 criticalPath;
   subgraph "Played by `review-deploy`";
     4_2-1 & 4_2-2 & 4_2-3 -.->|"(don't use needs because of limitations)"| 3_3-1;
   end
@@ -478,32 +478,30 @@ graph RL;
     1-19["nodejs-scan-sast"];
     1-20["secrets-sast"];
 
-    class 1-3 criticalPath;
     class 1-5 criticalPath;
-    class 1-6 criticalPath;
   end
 
   2_1-1["graphql-reference-verify (5 minutes)"];
   click 2_1-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=8356715&udv=0"
-
   subgraph "Needs `setup-test-env`";
     2_1-1 --> 1-6;
   end
 
   2_2-1["static-analysis (17 minutes)"];
   click 2_2-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914471&udv=0"
-
   subgraph "Needs `setup-test-env` & `compile-assets`";
     2_2-1 --> 1-6 & 1-3;
   end
 
+  2_3-1["build-assets-image (2.5 minutes)"];
   subgraph "Needs `gitlab:assets:compile`";
-    2_3-1["build-assets-image (2 minutes)"] --> 1-5
+    2_3-1 --> 1-5
     class 2_3-1 criticalPath;
   end
 
+  2_4-1["package-and-qa (108 minutes)"];
   subgraph "Needs `build-qa-image` & `build-assets-image`";
-    2_4-1["package-and-qa (108 minutes)"] --> 1-2 & 2_3-1;
+    2_4-1 --> 1-2 & 2_3-1;
     class 2_4-1 criticalPath;
     click 2_4-1 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914305&udv=0"
   end