Commit 217376a7 authored by Miguel Rincon's avatar Miguel Rincon

Remove tabindex where not needed

parent 21061935
...@@ -339,7 +339,6 @@ export default { ...@@ -339,7 +339,6 @@ export default {
<h5 <h5
ref="graphTitle" ref="graphTitle"
class="prometheus-graph-title gl-font-lg font-weight-bold text-truncate gl-mr-3" class="prometheus-graph-title gl-font-lg font-weight-bold text-truncate gl-mr-3"
tabindex="0"
> >
{{ title }} {{ title }}
</h5> </h5>
......
...@@ -52,7 +52,7 @@ export default { ...@@ -52,7 +52,7 @@ export default {
</script> </script>
<template> <template>
<div v-if="showPanels" ref="graph-group" class="card prometheus-panel" tabindex="0"> <div v-if="showPanels" ref="graph-group" class="card prometheus-panel">
<div class="card-header d-flex align-items-center"> <div class="card-header d-flex align-items-center">
<h4 class="flex-grow-1">{{ name }}</h4> <h4 class="flex-grow-1">{{ name }}</h4>
<a <a
......
---
title: Remove dashboard panels' tabindex where is not needed
merge_request: 36168
author:
type: fixed
...@@ -136,10 +136,6 @@ describe('Dashboard Panel', () => { ...@@ -136,10 +136,6 @@ describe('Dashboard Panel', () => {
expect(wrapper.find(MonitorEmptyChart).exists()).toBe(true); expect(wrapper.find(MonitorEmptyChart).exists()).toBe(true);
expect(wrapper.find(MonitorEmptyChart).isVueInstance()).toBe(true); expect(wrapper.find(MonitorEmptyChart).isVueInstance()).toBe(true);
}); });
it('does not contain a tabindex attribute', () => {
expect(wrapper.find(MonitorEmptyChart).contains('[tabindex]')).toBe(false);
});
}); });
describe('When graphData is null', () => { describe('When graphData is null', () => {
......
...@@ -42,14 +42,10 @@ describe('Graph group component', () => { ...@@ -42,14 +42,10 @@ describe('Graph group component', () => {
}); });
}); });
it('should contain a tabindex', () => {
expect(findGroup().contains('[tabindex]')).toBe(true);
});
it('should contain a tab index for the collapse button', () => { it('should contain a tab index for the collapse button', () => {
const groupToggle = findToggleButton(); const groupToggle = findToggleButton();
expect(groupToggle.contains('[tabindex]')).toBe(true); expect(groupToggle.is('[tabindex]')).toBe(true);
}); });
it('should show the open the group when collapseGroup is set to true', () => { it('should show the open the group when collapseGroup is set to true', () => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment