Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
217376a7
Commit
217376a7
authored
Jul 07, 2020
by
Miguel Rincon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove tabindex where not needed
parent
21061935
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
7 additions
and
11 deletions
+7
-11
app/assets/javascripts/monitoring/components/dashboard_panel.vue
...ets/javascripts/monitoring/components/dashboard_panel.vue
+0
-1
app/assets/javascripts/monitoring/components/graph_group.vue
app/assets/javascripts/monitoring/components/graph_group.vue
+1
-1
changelogs/unreleased/219385-metrics-dashboard-elements-outline.yml
.../unreleased/219385-metrics-dashboard-elements-outline.yml
+5
-0
spec/frontend/monitoring/components/dashboard_panel_spec.js
spec/frontend/monitoring/components/dashboard_panel_spec.js
+0
-4
spec/frontend/monitoring/components/graph_group_spec.js
spec/frontend/monitoring/components/graph_group_spec.js
+1
-5
No files found.
app/assets/javascripts/monitoring/components/dashboard_panel.vue
View file @
217376a7
...
@@ -339,7 +339,6 @@ export default {
...
@@ -339,7 +339,6 @@ export default {
<h5
<h5
ref=
"graphTitle"
ref=
"graphTitle"
class=
"prometheus-graph-title gl-font-lg font-weight-bold text-truncate gl-mr-3"
class=
"prometheus-graph-title gl-font-lg font-weight-bold text-truncate gl-mr-3"
tabindex=
"0"
>
>
{{
title
}}
{{
title
}}
</h5>
</h5>
...
...
app/assets/javascripts/monitoring/components/graph_group.vue
View file @
217376a7
...
@@ -52,7 +52,7 @@ export default {
...
@@ -52,7 +52,7 @@ export default {
</
script
>
</
script
>
<
template
>
<
template
>
<div
v-if=
"showPanels"
ref=
"graph-group"
class=
"card prometheus-panel"
tabindex=
"0"
>
<div
v-if=
"showPanels"
ref=
"graph-group"
class=
"card prometheus-panel"
>
<div
class=
"card-header d-flex align-items-center"
>
<div
class=
"card-header d-flex align-items-center"
>
<h4
class=
"flex-grow-1"
>
{{
name
}}
</h4>
<h4
class=
"flex-grow-1"
>
{{
name
}}
</h4>
<a
<a
...
...
changelogs/unreleased/219385-metrics-dashboard-elements-outline.yml
0 → 100644
View file @
217376a7
---
title
:
Remove dashboard panels' tabindex where is not needed
merge_request
:
36168
author
:
type
:
fixed
spec/frontend/monitoring/components/dashboard_panel_spec.js
View file @
217376a7
...
@@ -136,10 +136,6 @@ describe('Dashboard Panel', () => {
...
@@ -136,10 +136,6 @@ describe('Dashboard Panel', () => {
expect
(
wrapper
.
find
(
MonitorEmptyChart
).
exists
()).
toBe
(
true
);
expect
(
wrapper
.
find
(
MonitorEmptyChart
).
exists
()).
toBe
(
true
);
expect
(
wrapper
.
find
(
MonitorEmptyChart
).
isVueInstance
()).
toBe
(
true
);
expect
(
wrapper
.
find
(
MonitorEmptyChart
).
isVueInstance
()).
toBe
(
true
);
});
});
it
(
'
does not contain a tabindex attribute
'
,
()
=>
{
expect
(
wrapper
.
find
(
MonitorEmptyChart
).
contains
(
'
[tabindex]
'
)).
toBe
(
false
);
});
});
});
describe
(
'
When graphData is null
'
,
()
=>
{
describe
(
'
When graphData is null
'
,
()
=>
{
...
...
spec/frontend/monitoring/components/graph_group_spec.js
View file @
217376a7
...
@@ -42,14 +42,10 @@ describe('Graph group component', () => {
...
@@ -42,14 +42,10 @@ describe('Graph group component', () => {
});
});
});
});
it
(
'
should contain a tabindex
'
,
()
=>
{
expect
(
findGroup
().
contains
(
'
[tabindex]
'
)).
toBe
(
true
);
});
it
(
'
should contain a tab index for the collapse button
'
,
()
=>
{
it
(
'
should contain a tab index for the collapse button
'
,
()
=>
{
const
groupToggle
=
findToggleButton
();
const
groupToggle
=
findToggleButton
();
expect
(
groupToggle
.
contain
s
(
'
[tabindex]
'
)).
toBe
(
true
);
expect
(
groupToggle
.
i
s
(
'
[tabindex]
'
)).
toBe
(
true
);
});
});
it
(
'
should show the open the group when collapseGroup is set to true
'
,
()
=>
{
it
(
'
should show the open the group when collapseGroup is set to true
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment