Commit 2238c62b authored by Nathan Friend's avatar Nathan Friend

Merge branch '332443-environments-folders-currently-breaking-the-page-layout' into 'master'

Resolve "Environments Folders currently breaking the page layout"

See merge request gitlab-org/gitlab!64280
parents 9a767309 d03f85fe
...@@ -552,6 +552,9 @@ export default { ...@@ -552,6 +552,9 @@ export default {
{ 'gl-display-none gl-md-display-block': !this.upcomingDeployment }, { 'gl-display-none gl-md-display-block': !this.upcomingDeployment },
]; ];
}, },
tableNameSpacingClass() {
return this.isFolder ? 'section-100' : this.tableData.name.spacing;
},
}, },
methods: { methods: {
...@@ -588,8 +591,9 @@ export default { ...@@ -588,8 +591,9 @@ export default {
> >
<div <div
class="table-section section-wrap text-truncate" class="table-section section-wrap text-truncate"
:class="tableData.name.spacing" :class="tableNameSpacingClass"
role="gridcell" role="gridcell"
data-testid="environment-name-cell"
> >
<div v-if="!isFolder" class="table-mobile-header" role="rowheader"> <div v-if="!isFolder" class="table-mobile-header" role="rowheader">
{{ getMobileViewTitleForField('name') }} {{ getMobileViewTitleForField('name') }}
...@@ -632,9 +636,11 @@ export default { ...@@ -632,9 +636,11 @@ export default {
</div> </div>
<div <div
v-if="!isFolder"
class="table-section deployment-column d-none d-md-block" class="table-section deployment-column d-none d-md-block"
:class="tableData.deploy.spacing" :class="tableData.deploy.spacing"
role="gridcell" role="gridcell"
data-testid="enviornment-deployment-id-cell"
> >
<span v-if="shouldRenderDeploymentID" class="text-break-word"> <span v-if="shouldRenderDeploymentID" class="text-break-word">
{{ deploymentInternalId }} {{ deploymentInternalId }}
...@@ -656,7 +662,13 @@ export default { ...@@ -656,7 +662,13 @@ export default {
</div> </div>
</div> </div>
<div class="table-section d-none d-md-block" :class="tableData.build.spacing" role="gridcell"> <div
v-if="!isFolder"
class="table-section d-none d-md-block"
:class="tableData.build.spacing"
role="gridcell"
data-testid="environment-build-cell"
>
<a v-if="shouldRenderBuildName" :href="buildPath" class="build-link cgray"> <a v-if="shouldRenderBuildName" :href="buildPath" class="build-link cgray">
<tooltip-on-truncate <tooltip-on-truncate
:title="buildName" :title="buildName"
......
...@@ -285,6 +285,17 @@ describe('Environment item', () => { ...@@ -285,6 +285,17 @@ describe('Environment item', () => {
it('should not render the "Upcoming deployment" column', () => { it('should not render the "Upcoming deployment" column', () => {
expect(findUpcomingDeployment().exists()).toBe(false); expect(findUpcomingDeployment().exists()).toBe(false);
}); });
it('should set the name cell to be full width', () => {
expect(wrapper.find('[data-testid="environment-name-cell"]').classes('section-100')).toBe(
true,
);
});
it('should hide non-folder properties', () => {
expect(wrapper.find('[data-testid="environment-deployment-id-cell"]').exists()).toBe(false);
expect(wrapper.find('[data-testid="environment-build-cell"]').exists()).toBe(false);
});
}); });
describe('When environment can be deleted', () => { describe('When environment can be deleted', () => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment