Add latest changes from gitlab-org/gitlab@master

Gemfile.lock

@@ -1328,7 +1328,7 @@ DEPENDENCIES
   request_store (~> 1.3)
   responders (~> 3.0)
   retriable (~> 3.1.2)
-  rouge (~> 3.11.0)
+  rouge (~> 3.15.0)
   rqrcode-rails3 (~> 0.1.7)
   rspec-parameterized
   rspec-rails (~> 4.0.0.beta3)

changelogs/unreleased/docs-job-activity-limit.yml

+---
+title: Document CI job activity limit for pipeline creation
+merge_request: 23246
+author:
+type: added

doc/administration/instance_limits.md

@@ -42,3 +42,35 @@ Activity history for projects and individuals' profiles was limited to one year
 A maximum number of project webhooks applies to each GitLab.com tier. Check the
 [Maximum number of webhooks (per tier)](../user/project/integrations/webhooks.md#maximum-number-of-webhooks-per-tier)
 section in the Webhooks page.
+
+## CI/CD limits
+
+### Number of jobs in active pipelines
+
+> [Introduced](https://gitlab.com/gitlab-org/gitlab/issues/32823) in GitLab 12.6.
+
+The total number of jobs in active pipelines can be limited per project. This limit is checked
+each time a new pipeline is created. An active pipeline is any pipeline in one of the following states:
+
+- `created`
+- `pending`
+- `running`
+
+If a new pipeline would cause the total number of jobs to exceed the limit, the pipeline
+will fail with a `job_activity_limit_exceeded` error.
+
+- On GitLab.com different [limits are defined per plan](../user/gitlab_com/index.md#gitlab-cicd) and they affect all projects under that plan.
+- On [GitLab Starter](https://about.gitlab.com/pricing/#self-managed) tier or higher self-hosted installations, this limit is defined for the `default` plan that affects all projects.
+  This limit is disabled by default.
+
+To set this limit on a self-hosted installation, run the following in the
+[GitLab Rails console](https://docs.gitlab.com/omnibus/maintenance/#starting-a-rails-console-session):
+
+```ruby
+# If limits don't exist for the default plan, you can create one with:
+# Plan.default.create_limits!
+
+Plan.default.limits.update!(ci_active_jobs: 500)
+```
+
+Set the limit to `0` to disable it.

doc/administration/logs.md

@@ -121,7 +121,9 @@ In this example we can see that server processed an HTTP request with URL
 
 ## `api_json.log`
 
-Introduced in GitLab 10.0, this file lives in
+> Introduced in GitLab 10.0.
+
+This file lives in
 `/var/log/gitlab/gitlab-rails/api_json.log` for Omnibus GitLab packages or in
 `/home/git/gitlab/log/api_json.log` for installations from source.
 
@@ -159,6 +161,21 @@ October 07, 2014 11:25: User "Claudie Hodkiewicz" (nasir_stehr@olson.co.uk)  was
 October 07, 2014 11:25: Project "project133" was removed
 ```
 
+## `application_json.log`
+
+> [Introduced](https://gitlab.com/gitlab-org/gitlab/issues/22812) in GitLab 12.7.
+
+This file lives in `/var/log/gitlab/gitlab-rails/application_json.log` for
+Omnibus GitLab packages or in `/home/git/gitlab/log/application_json.log` for
+installations from source.
+
+It contains the JSON version of the logs in `application.log` like the example below:
+
+``` json
+{"severity":"INFO","time":"2020-01-14T13:35:15.466Z","correlation_id":"3823a1550b64417f9c9ed8ee0f48087e","message":"User \"Administrator\" (admin@example.com) was created"}
+{"severity":"INFO","time":"2020-01-14T13:35:15.466Z","correlation_id":"78e3df10c9a18745243d524540bd5be4","message":"Project \"project133\" was removed"}
+```
+
 ## `integrations_json.log`
 
 This file lives in `/var/log/gitlab/gitlab-rails/integrations_json.log` for
@@ -174,7 +191,9 @@ It contains information about [integrations](../user/project/integrations/projec
 
 ## `kubernetes.log`
 
-Introduced in GitLab 11.6. This file lives in
+> Introduced in GitLab 11.6.
+
+This file lives in
 `/var/log/gitlab/gitlab-rails/kubernetes.log` for Omnibus GitLab
 packages or in `/home/git/gitlab/log/kubernetes.log` for
 installations from source.
@@ -320,13 +339,17 @@ It logs information whenever a [repository check is run][repocheck] on a project
 
 ## `importer.log`
 
-Introduced in GitLab 11.3. This file lives in `/var/log/gitlab/gitlab-rails/importer.log` for
+> Introduced in GitLab 11.3.
+
+This file lives in `/var/log/gitlab/gitlab-rails/importer.log` for
 Omnibus GitLab packages or in `/home/git/gitlab/log/importer.log` for
 installations from source.
 
 ## `auth.log`
 
-Introduced in GitLab 12.0. This file lives in `/var/log/gitlab/gitlab-rails/auth.log` for
+> Introduced in GitLab 12.0.
+
+This file lives in `/var/log/gitlab/gitlab-rails/auth.log` for
 Omnibus GitLab packages or in `/home/git/gitlab/log/auth.log` for
 installations from source.
 
@@ -356,7 +379,9 @@ GraphQL queries are recorded in that file. For example:
 
 ## `migrations.log`
 
-Introduced in GitLab 12.3. This file lives in `/var/log/gitlab/gitlab-rails/migrations.log` for
+> Introduced in GitLab 12.3.
+
+This file lives in `/var/log/gitlab/gitlab-rails/migrations.log` for
 Omnibus GitLab packages or in `/home/git/gitlab/log/migrations.log` for
 installations from source.
 
@@ -406,7 +431,9 @@ It is stored at:
 
 ## `elasticsearch.log`
 
-Introduced in GitLab 12.6. This file lives in
+> Introduced in GitLab 12.6.
+
+This file lives in
 `/var/log/gitlab/gitlab-rails/elasticsearch.log` for Omnibus GitLab
 packages or in `/home/git/gitlab/log/elasticsearch.log` for installations
 from source.

doc/user/gitlab_com/index.md

@@ -75,6 +75,7 @@ Below are the current settings regarding [GitLab CI/CD](../../ci/README.md).
 | Artifacts maximum size (uncompressed) | 1G                | 100M          |
 | Artifacts [expiry time](../../ci/yaml/README.md#artifactsexpire_in)   | kept forever           | deleted after 30 days unless otherwise specified    |
 | Scheduled Pipeline Cron | `*/5 * * * *` | `*/19 * * * *` |
+| [Max jobs in active pipelines](../../administration/instance_limits.md#number-of-jobs-in-active-pipelines) | `500` for Free tier, unlimited otherwise | Unlimited
 
 ## Repository size limit
 
@@ -95,7 +96,11 @@ IP based firewall can be configured by looking up all
 
 ## Shared Runners
 
-Shared Runners on GitLab.com run in [autoscale mode] and powered by Google Cloud Platform.
+GitLab offers Linux and Windows shared runners hosted on GitLab.com for executing your pipelines.
+
+### Linux Shared Runners
+
+Linux Shared Runners on GitLab.com run in [autoscale mode] and are powered by Google Cloud Platform.
 Autoscaling means reduced waiting times to spin up CI/CD jobs, and isolated VMs for each project,
 thus maximizing security. They're free to use for public open source projects and limited
 to 2000 CI minutes per month per group for private projects. More minutes
@@ -122,7 +127,7 @@ Below are the shared Runners settings.
 | Default Docker image                  | `ruby:2.5`                                        | -          |
 | `privileged` (run [Docker in Docker]) | `true`                                            | `false`    |
 
-### `config.toml`
+#### `config.toml`
 
 The full contents of our `config.toml` are:
 
@@ -184,6 +189,158 @@ sentry_dsn = "X"
       BucketName = "bucket-name"
 ```
 
+### Windows Shared Runners (beta)
+
+The Windows Shared Runners are currently in
+[beta](https://about.gitlab.com/handbook/product/#beta) and should not be used
+for production workloads.
+
+During the beta period for groups and private projects the use of
+Windows Shared Runners will count towards the [shared runner pipeline
+quota](https://docs.gitlab.com/ee/user/admin_area/settings/continuous_integration.html#shared-runners-pipeline-minutes-quota-starter-only)
+as if they are Linux Runners, we do have plans to change this in
+[#30835](https://gitlab.com/gitlab-org/gitlab/issues/30834).
+
+Windows Shared Runners on GitLab.com automatically autoscale by
+launching virtual machines on the Google Cloud Platform. This solution uses
+a new [autoscaling driver](https://gitlab.com/gitlab-org/ci-cd/custom-executor-drivers/autoscaler/tree/master/docs/readme.md)
+developed by GitLab for the [custom executor](https://docs.gitlab.com/runner/executors/custom.html).
+Windows Shared Runners execute your CI/CD jobs on `n1-standard-2` instances with 2
+vCPUs and 7.5GB RAM. You can find a full list of available Windows packages in the
+[package documentation](https://gitlab.com/gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers/blob/master/cookbooks/preinstalled-software/README.md).
+
+We want to keep iterating to get Windows Shared Runners in a stable state and
+[generally available](https://about.gitlab.com/handbook/product/#generally-available-ga).
+You can follow our work towards this goal in the
+[related epic](https://gitlab.com/groups/gitlab-org/-/epics/2162).
+
+#### Configuration
+
+The full contents of our `config.toml` are:
+
+```toml
+concurrent = 10
+check_interval = 3
+
+[[runners]]
+  name = "windows-runner"
+  url = "https://gitlab.com/"
+  token = "TOKEN"
+  executor = "custom"
+  builds_dir = "C:\\GitLab-Runner\\builds"
+  cache_dir = "C:\\GitLab-Runner\\cache"
+  shell  = "powershell"
+  [runners.custom]
+    config_exec = "C:\\GitLab-Runner\\autoscaler\\autoscaler.exe"
+    config_args = ["--config", "C:\\GitLab-Runner\\autoscaler\\config.toml", "custom", "config"]
+    prepare_exec = "C:\\GitLab-Runner\\autoscaler\\autoscaler.exe"
+    prepare_args = ["--config", "C:\\GitLab-Runner\\autoscaler\\config.toml", "custom", "prepare"]
+    run_exec = "C:\\GitLab-Runner\\autoscaler\\autoscaler.exe"
+    run_args = ["--config", "C:\\GitLab-Runner\\autoscaler\\config.toml", "custom", "run"]
+    cleanup_exec = "C:\\GitLab-Runner\\autoscaler\\autoscaler.exe"
+    cleanup_args = ["--config", "C:\\GitLab-Runner\\autoscaler\\config.toml", "custom", "cleanup"]
+```
+
+The full contents of our `autoscaler/config.toml` are:
+
+```toml
+Provider = "gcp"
+Executor = "winrm"
+OS = "windows"
+LogLevel = "info"
+LogFormat = "text"
+LogFile = "C:\\GitLab-Runner\\autoscaler\\autoscaler.log"
+VMTag = "windows"
+
+[GCP]
+  ServiceAccountFile = "PATH"
+  Project = "some-project-df9323"
+  Zone = "us-east1-c"
+  MachineType = "n1-standard-2"
+  Image = "IMAGE"
+  DiskSize = 50
+  DiskType = "pd-standard"
+  Subnetwork = "default"
+  Network = "default"
+  Tags = ["TAGS"]
+  Username = "gitlab_runner"
+
+[WinRM]
+  MaximumTimeout = 3600
+  ExecutionMaxRetries = 0
+
+[ProviderCache]
+  Enabled = true
+  Directory = "C:\\GitLab-Runner\\autoscaler\\machines"
+```
+
+#### Example
+
+Below is a simple `.gitlab-ci.yml` file to show how to start using the
+Windows Shared Runners:
+
+```yaml
+.shared_windows_runners:
+  tags:
+  - shared
+  - windows
+  - windows-1809
+
+stages:
+  - build
+  - test
+
+before_script:
+ - date +"%H"
+ - echo ${HOUR}
+ - echo "started by ${GITLAB_USER_NAME}"
+
+build:
+  extends:
+  - .shared_windows_runners
+  stage: build
+  script:
+  - echo "running scripts in the build job"
+
+test:
+  extends:
+  - .shared_windows_runners
+  stage: test
+  script:
+  - echo "running scripts in the test job"
+```
+
+#### Limitations and known issues
+
+- All the limitations mentioned in our [beta
+  definition](https://about.gitlab.com/handbook/product/#beta).
+- The average provisioning time for a new Windows VM is 5 minutes.
+  This means that for the beta you will notice slower build start times
+  on the Windows Shared Runner fleet compared to Linux. In a future
+  release we will add the ability to the autoscaler which will enable
+  the pre-warming of virtual machines. This will significantly reduce
+  the time it takes to provision a VM on the Windows fleet. You can
+  follow along in this
+  [issue](https://gitlab.com/gitlab-org/ci-cd/custom-executor-drivers/autoscaler/issues/32).
+- The Windows Shared Runner fleet may be unavailable occasionally
+  for maintenance or updates.
+- The Windows Shared Runner virtual machine instances do not use the
+  GitLab Docker executor. This means that unlike the Linux Shared
+  Runners, you will not be able to specify `image` and `services` in
+  your pipeline configuration.
+- For the beta release, we have included a set of software packages in
+  the base VM image. If your CI job requires additional software that's
+  not included in this list, then you will need to add installation
+  commands to [`before_script`](../../ci/yaml/README.md#before_script-and-after_script) or [`script`](../../ci/yaml/README.md#script) to install the required
+  software. Note that each job runs on a new VM instance, so the
+  installation of additional software packages needs to be repeated for
+  each job in your pipeline.
+- The job may stay in a pending state for longer than the
+  Linux shared Runners.
+- There is the possibility that we introduce breaking changes which will
+  require updates to pipelines that are using the Windows Shared Runner
+  fleet.
+
 ## Sidekiq
 
 GitLab.com runs [Sidekiq](https://sidekiq.org) with arguments `--timeout=4 --concurrency=4`

doc/user/project/issues/design_management.md

@@ -54,8 +54,8 @@ Design Management requires that projects are using
 - Design Management data [won't be moved](https://gitlab.com/gitlab-org/gitlab/issues/13426)
   when an issue is moved, nor [deleted](https://gitlab.com/gitlab-org/gitlab/issues/13427)
   when an issue is deleted.
-- Design Management
-  [isn't supported by Geo](https://gitlab.com/groups/gitlab-org/-/epics/1633) yet.
+- From GitLab 12.7, Design Management data [can be replicated](../../../administration/geo/replication/datatypes.md#limitations-on-replicationverification)
+  by Geo but [not verified](https://gitlab.com/gitlab-org/gitlab/issues/32467).
 - Only the latest version of the designs can be deleted.
 - Deleted designs cannot be recovered but you can see them on previous designs versions.
 

spec/frontend/monitoring/components/charts/time_series_spec.js

@@ -8,7 +8,7 @@ import TimeSeries from '~/monitoring/components/charts/time_series.vue';
 import * as types from '~/monitoring/stores/mutation_types';
 import {
   deploymentData,
-  metricsGroupsAPIResponse,
+  metricsDashboardPayload,
   mockedQueryResultPayload,
   mockProjectDir,
   mockHost,
@@ -34,7 +34,7 @@ describe('Time series component', () => {
 
     store.commit(
       `monitoringDashboard/${types.RECEIVE_METRICS_DATA_SUCCESS}`,
-      metricsGroupsAPIResponse,
+      metricsDashboardPayload,
     );
 
     store.commit(`monitoringDashboard/${types.RECEIVE_DEPLOYMENTS_DATA_SUCCESS}`, deploymentData);

spec/frontend/monitoring/components/dashboard_spec.js

@@ -14,9 +14,8 @@ import { createStore } from '~/monitoring/stores';
 import * as types from '~/monitoring/stores/mutation_types';
 import { setupComponentStore, propsData } from '../init_utils';
 import {
-  metricsGroupsAPIResponse,
+  metricsDashboardPayload,
   mockedQueryResultPayload,
-  mockApiEndpoint,
   environmentData,
   dashboardGitResponse,
 } from '../mock_data';
@@ -33,6 +32,9 @@ describe('Dashboard', () => {
     wrapper = shallowMount(Dashboard, {
       localVue,
       propsData: { ...propsData, ...props },
+      methods: {
+        fetchData: jest.fn(),
+      },
       store,
       ...options,
     });
@@ -42,6 +44,9 @@ describe('Dashboard', () => {
     wrapper = mount(Dashboard, {
       localVue,
       propsData: { ...propsData, ...props },
+      methods: {
+        fetchData: jest.fn(),
+      },
       store,
       ...options,
     });
@@ -55,21 +60,16 @@ describe('Dashboard', () => {
   afterEach(() => {
     if (wrapper) {
       wrapper.destroy();
+      wrapper = null;
     }
     mock.restore();
   });
 
   describe('no metrics are available yet', () => {
     beforeEach(() => {
-      mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
-
       createShallowWrapper();
     });
 
-    afterEach(() => {
-      wrapper.destroy();
-    });
-
     it('shows the environment selector', () => {
       expect(wrapper.vm.$el.querySelector('.js-environments-dropdown')).toBeTruthy();
     });
@@ -77,29 +77,19 @@ describe('Dashboard', () => {
 
   describe('no data found', () => {
     beforeEach(done => {
-      mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
-
       createShallowWrapper();
 
       wrapper.vm.$nextTick(done);
     });
 
-    afterEach(() => {
-      wrapper.destroy();
-    });
-
     it('shows the environment selector dropdown', () => {
       expect(wrapper.vm.$el.querySelector('.js-environments-dropdown')).toBeTruthy();
     });
   });
 
   describe('request information to the server', () => {
-    beforeEach(() => {
-      mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
-    });
-
     it('shows up a loading state', done => {
-      createShallowWrapper({ hasMetrics: true });
+      createShallowWrapper({ hasMetrics: true }, { methods: {} });
 
       wrapper.vm
         .$nextTick()
@@ -153,17 +143,11 @@ describe('Dashboard', () => {
 
   describe('when all requests have been commited by the store', () => {
     beforeEach(() => {
-      mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
-
       createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
       setupComponentStore(wrapper);
     });
 
-    afterEach(() => {
-      wrapper.destroy();
-    });
-
     it('renders the environments dropdown with a number of environments', done => {
       wrapper.vm
         .$nextTick()
@@ -211,7 +195,7 @@ describe('Dashboard', () => {
 
     wrapper.vm.$store.commit(
       `monitoringDashboard/${types.RECEIVE_METRICS_DATA_SUCCESS}`,
-      metricsGroupsAPIResponse,
+      metricsDashboardPayload,
     );
     wrapper.vm.$store.commit(
       `monitoringDashboard/${types.RECEIVE_METRIC_RESULT_SUCCESS}`,
@@ -247,8 +231,6 @@ describe('Dashboard', () => {
 
   describe('when one of the metrics is missing', () => {
     beforeEach(done => {
-      mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
-
       createShallowWrapper({ hasMetrics: true });
       setupComponentStore(wrapper);
 
@@ -278,10 +260,6 @@ describe('Dashboard', () => {
     const findDraggablePanels = () => wrapper.findAll('.js-draggable-panel');
     const findRearrangeButton = () => wrapper.find('.js-rearrange-button');
 
-    beforeEach(() => {
-      mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
-    });
-
     beforeEach(done => {
       createShallowWrapper({ hasMetrics: true });
 
@@ -290,10 +268,6 @@ describe('Dashboard', () => {
       wrapper.vm.$nextTick(done);
     });
 
-    afterEach(() => {
-      wrapper.destroy();
-    });
-
     it('wraps vuedraggable', () => {
       expect(findDraggablePanels().exists()).toBe(true);
       expect(findDraggablePanels().length).toEqual(expectedPanelCount);
@@ -332,7 +306,7 @@ describe('Dashboard', () => {
 
         it('metrics can be swapped', done => {
           const firstDraggable = findDraggables().at(0);
-          const mockMetrics = [...metricsGroupsAPIResponse.panel_groups[1].panels];
+          const mockMetrics = [...metricsDashboardPayload.panel_groups[1].panels];
 
           const firstTitle = mockMetrics[0].title;
           const secondTitle = mockMetrics[1].title;
@@ -384,10 +358,6 @@ describe('Dashboard', () => {
       wrapper.vm.$nextTick(done);
     });
 
-    afterEach(() => {
-      wrapper.destroy();
-    });
-
     it('renders correctly', () => {
       expect(wrapper.isVueInstance()).toBe(true);
       expect(wrapper.exists()).toBe(true);
@@ -398,8 +368,6 @@ describe('Dashboard', () => {
     const findEditLink = () => wrapper.find('.js-edit-link');
 
     beforeEach(done => {
-      mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
-
       createShallowWrapper({ hasMetrics: true });
 
       wrapper.vm.$store.commit(
@@ -409,10 +377,6 @@ describe('Dashboard', () => {
       wrapper.vm.$nextTick(done);
     });
 
-    afterEach(() => {
-      wrapper.destroy();
-    });
-
     it('is not present for the default dashboard', () => {
       expect(findEditLink().exists()).toBe(false);
     });
@@ -435,8 +399,6 @@ describe('Dashboard', () => {
 
   describe('Dashboard dropdown', () => {
     beforeEach(() => {
-      mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
-
       createMountedWrapper({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 
       wrapper.vm.$store.commit(
@@ -460,8 +422,6 @@ describe('Dashboard', () => {
 
   describe('external dashboard link', () => {
     beforeEach(() => {
-      mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
-
       createMountedWrapper(
         {
           hasMetrics: true,
@@ -497,17 +457,11 @@ describe('Dashboard', () => {
     const clipboardText = () => link().element.dataset.clipboardText;
 
     beforeEach(done => {
-      mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
-
       createShallowWrapper({ hasMetrics: true, currentDashboard });
 
       setTimeout(done);
     });
 
-    afterEach(() => {
-      wrapper.destroy();
-    });
-
     it('adds a copy button to the dropdown', () => {
       expect(link().text()).toContain('Generate link to chart');
     });

spec/frontend/monitoring/components/dashboard_time_window_spec.js

@@ -6,7 +6,7 @@ import statusCodes from '~/lib/utils/http_status';
 import Dashboard from '~/monitoring/components/dashboard.vue';
 import { createStore } from '~/monitoring/stores';
 import { propsData, setupComponentStore } from '../init_utils';
-import { metricsGroupsAPIResponse, mockApiEndpoint } from '../mock_data';
+import { metricsDashboardPayload, mockApiEndpoint } from '../mock_data';
 
 jest.mock('~/lib/utils/url_utility', () => ({
   getParameterValues: jest.fn().mockImplementation(param => {
@@ -43,7 +43,7 @@ describe('dashboard time window', () => {
   });
 
   it('shows an error message if invalid url parameters are passed', done => {
-    mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsGroupsAPIResponse);
+    mock.onGet(mockApiEndpoint).reply(statusCodes.OK, metricsDashboardPayload);
 
     createComponentWrapperMounted({ hasMetrics: true }, { stubs: ['graph-group', 'panel-type'] });
 

spec/frontend/monitoring/init_utils.js

 import * as types from '~/monitoring/stores/mutation_types';
 import {
-  metricsGroupsAPIResponse,
+  metricsDashboardPayload,
   mockedEmptyResult,
   mockedQueryResultPayload,
   mockedQueryResultPayloadCoresTotal,
@@ -23,7 +23,7 @@ export const propsData = {
   emptyNoDataSvgPath: '/path/to/no-data.svg',
   emptyNoDataSmallSvgPath: '/path/to/no-data-small.svg',
   emptyUnableToConnectSvgPath: '/path/to/unable-to-connect.svg',
-  environmentsEndpoint: '/root/hello-prometheus/environments/35',
+  environmentsEndpoint: '/root/hello-prometheus/-/environments.json',
   currentEnvironmentName: 'production',
   customMetricsAvailable: false,
   customMetricsPath: '',
@@ -33,7 +33,7 @@ export const propsData = {
 export const setupComponentStore = wrapper => {
   wrapper.vm.$store.commit(
     `monitoringDashboard/${types.RECEIVE_METRICS_DATA_SUCCESS}`,
-    metricsGroupsAPIResponse,
+    metricsDashboardPayload,
   );
 
   // Load 3 panels to the dashboard, one with an empty result

spec/frontend/monitoring/mock_data.js

@@ -331,81 +331,6 @@ export const mockedQueryResultPayloadCoresTotal = {
   ],
 };
 
-export const metricsGroupsAPIResponse = {
-  dashboard: 'Environment metrics',
-  panel_groups: [
-    {
-      group: 'Response metrics (NGINX Ingress VTS)',
-      priority: 10,
-      panels: [
-        {
-          metrics: [
-            {
-              id: 'response_metrics_nginx_ingress_throughput_status_code',
-              label: 'Status Code',
-              metric_id: 1,
-              prometheus_endpoint_path:
-                '/root/autodevops-deploy/environments/32/prometheus/api/v1/query_range?query=sum%28rate%28nginx_upstream_responses_total%7Bupstream%3D~%22%25%7Bkube_namespace%7D-%25%7Bci_environment_slug%7D-.%2A%22%7D%5B2m%5D%29%29+by+%28status_code%29',
-              query_range:
-                'sum(rate(nginx_upstream_responses_total{upstream=~"%{kube_namespace}-%{ci_environment_slug}-.*"}[2m])) by (status_code)',
-              unit: 'req / sec',
-            },
-          ],
-          title: 'Throughput',
-          type: 'area-chart',
-          weight: 1,
-          y_label: 'Requests / Sec',
-        },
-      ],
-    },
-    {
-      group: 'System metrics (Kubernetes)',
-      priority: 5,
-      panels: [
-        {
-          title: 'Memory Usage (Pod average)',
-          type: 'area-chart',
-          y_label: 'Memory Used per Pod',
-          weight: 2,
-          metrics: [
-            {
-              id: 'system_metrics_kubernetes_container_memory_average',
-              query_range:
-                'avg(sum(container_memory_usage_bytes{container_name!="POD",pod_name=~"^%{ci_environment_slug}-([^c].*|c([^a]|a([^n]|n([^a]|a([^r]|r[^y])))).*|)-(.*)",namespace="%{kube_namespace}"}) by (job)) without (job) / count(avg(container_memory_usage_bytes{container_name!="POD",pod_name=~"^%{ci_environment_slug}-([^c].*|c([^a]|a([^n]|n([^a]|a([^r]|r[^y])))).*|)-(.*)",namespace="%{kube_namespace}"}) without (job)) /1024/1024',
-              label: 'Pod average',
-              unit: 'MB',
-              metric_id: 17,
-              prometheus_endpoint_path:
-                '/root/autodevops-deploy/environments/32/prometheus/api/v1/query_range?query=avg%28sum%28container_memory_usage_bytes%7Bcontainer_name%21%3D%22POD%22%2Cpod_name%3D~%22%5E%25%7Bci_environment_slug%7D-%28%5B%5Ec%5D.%2A%7Cc%28%5B%5Ea%5D%7Ca%28%5B%5En%5D%7Cn%28%5B%5Ea%5D%7Ca%28%5B%5Er%5D%7Cr%5B%5Ey%5D%29%29%29%29.%2A%7C%29-%28.%2A%29%22%2Cnamespace%3D%22%25%7Bkube_namespace%7D%22%7D%29+by+%28job%29%29+without+%28job%29+%2F+count%28avg%28container_memory_usage_bytes%7Bcontainer_name%21%3D%22POD%22%2Cpod_name%3D~%22%5E%25%7Bci_environment_slug%7D-%28%5B%5Ec%5D.%2A%7Cc%28%5B%5Ea%5D%7Ca%28%5B%5En%5D%7Cn%28%5B%5Ea%5D%7Ca%28%5B%5Er%5D%7Cr%5B%5Ey%5D%29%29%29%29.%2A%7C%29-%28.%2A%29%22%2Cnamespace%3D%22%25%7Bkube_namespace%7D%22%7D%29+without+%28job%29%29+%2F1024%2F1024',
-              appearance: {
-                line: {
-                  width: 2,
-                },
-              },
-            },
-          ],
-        },
-        {
-          title: 'Core Usage (Total)',
-          type: 'area-chart',
-          y_label: 'Total Cores',
-          weight: 3,
-          metrics: [
-            {
-              id: 'system_metrics_kubernetes_container_cores_total',
-              query_range:
-                'avg(sum(rate(container_cpu_usage_seconds_total{container_name!="POD",pod_name=~"^%{ci_environment_slug}-(.*)",namespace="%{kube_namespace}"}[15m])) by (job)) without (job)',
-              label: 'Total',
-              unit: 'cores',
-              metric_id: 13,
-            },
-          ],
-        },
-      ],
-    },
-  ],
-};
-
 export const environmentData = [
   {
     id: 34,
@@ -517,6 +442,81 @@ export const metricsDashboardResponse = {
   status: 'success',
 };
 
+export const metricsDashboardPayload = {
+  dashboard: 'Environment metrics',
+  panel_groups: [
+    {
+      group: 'Response metrics (NGINX Ingress VTS)',
+      priority: 10,
+      panels: [
+        {
+          metrics: [
+            {
+              id: 'response_metrics_nginx_ingress_throughput_status_code',
+              label: 'Status Code',
+              metric_id: 1,
+              prometheus_endpoint_path:
+                '/root/autodevops-deploy/environments/32/prometheus/api/v1/query_range?query=sum%28rate%28nginx_upstream_responses_total%7Bupstream%3D~%22%25%7Bkube_namespace%7D-%25%7Bci_environment_slug%7D-.%2A%22%7D%5B2m%5D%29%29+by+%28status_code%29',
+              query_range:
+                'sum(rate(nginx_upstream_responses_total{upstream=~"%{kube_namespace}-%{ci_environment_slug}-.*"}[2m])) by (status_code)',
+              unit: 'req / sec',
+            },
+          ],
+          title: 'Throughput',
+          type: 'area-chart',
+          weight: 1,
+          y_label: 'Requests / Sec',
+        },
+      ],
+    },
+    {
+      group: 'System metrics (Kubernetes)',
+      priority: 5,
+      panels: [
+        {
+          title: 'Memory Usage (Pod average)',
+          type: 'area-chart',
+          y_label: 'Memory Used per Pod',
+          weight: 2,
+          metrics: [
+            {
+              id: 'system_metrics_kubernetes_container_memory_average',
+              query_range:
+                'avg(sum(container_memory_usage_bytes{container_name!="POD",pod_name=~"^%{ci_environment_slug}-([^c].*|c([^a]|a([^n]|n([^a]|a([^r]|r[^y])))).*|)-(.*)",namespace="%{kube_namespace}"}) by (job)) without (job) / count(avg(container_memory_usage_bytes{container_name!="POD",pod_name=~"^%{ci_environment_slug}-([^c].*|c([^a]|a([^n]|n([^a]|a([^r]|r[^y])))).*|)-(.*)",namespace="%{kube_namespace}"}) without (job)) /1024/1024',
+              label: 'Pod average',
+              unit: 'MB',
+              metric_id: 17,
+              prometheus_endpoint_path:
+                '/root/autodevops-deploy/environments/32/prometheus/api/v1/query_range?query=avg%28sum%28container_memory_usage_bytes%7Bcontainer_name%21%3D%22POD%22%2Cpod_name%3D~%22%5E%25%7Bci_environment_slug%7D-%28%5B%5Ec%5D.%2A%7Cc%28%5B%5Ea%5D%7Ca%28%5B%5En%5D%7Cn%28%5B%5Ea%5D%7Ca%28%5B%5Er%5D%7Cr%5B%5Ey%5D%29%29%29%29.%2A%7C%29-%28.%2A%29%22%2Cnamespace%3D%22%25%7Bkube_namespace%7D%22%7D%29+by+%28job%29%29+without+%28job%29+%2F+count%28avg%28container_memory_usage_bytes%7Bcontainer_name%21%3D%22POD%22%2Cpod_name%3D~%22%5E%25%7Bci_environment_slug%7D-%28%5B%5Ec%5D.%2A%7Cc%28%5B%5Ea%5D%7Ca%28%5B%5En%5D%7Cn%28%5B%5Ea%5D%7Ca%28%5B%5Er%5D%7Cr%5B%5Ey%5D%29%29%29%29.%2A%7C%29-%28.%2A%29%22%2Cnamespace%3D%22%25%7Bkube_namespace%7D%22%7D%29+without+%28job%29%29+%2F1024%2F1024',
+              appearance: {
+                line: {
+                  width: 2,
+                },
+              },
+            },
+          ],
+        },
+        {
+          title: 'Core Usage (Total)',
+          type: 'area-chart',
+          y_label: 'Total Cores',
+          weight: 3,
+          metrics: [
+            {
+              id: 'system_metrics_kubernetes_container_cores_total',
+              query_range:
+                'avg(sum(rate(container_cpu_usage_seconds_total{container_name!="POD",pod_name=~"^%{ci_environment_slug}-(.*)",namespace="%{kube_namespace}"}[15m])) by (job)) without (job)',
+              label: 'Total',
+              unit: 'cores',
+              metric_id: 13,
+            },
+          ],
+        },
+      ],
+    },
+  ],
+};
+
 export const dashboardGitResponse = [
   {
     default: true,

spec/frontend/monitoring/store/actions_spec.js

@@ -25,7 +25,7 @@ import {
   deploymentData,
   environmentData,
   metricsDashboardResponse,
-  metricsGroupsAPIResponse,
+  metricsDashboardPayload,
   dashboardGitResponse,
 } from '../mock_data';
 
@@ -442,7 +442,7 @@ describe('Monitoring store actions', () => {
     beforeEach(() => {
       state = storeState();
       [metric] = metricsDashboardResponse.dashboard.panel_groups[0].panels[0].metrics;
-      [data] = metricsGroupsAPIResponse.panel_groups[0].panels[0].metrics;
+      [data] = metricsDashboardPayload.panel_groups[0].panels[0].metrics;
     });
 
     it('commits result', done => {

spec/frontend/monitoring/store/getters_spec.js

@@ -3,7 +3,7 @@ import mutations from '~/monitoring/stores/mutations';
 import * as types from '~/monitoring/stores/mutation_types';
 import { metricStates } from '~/monitoring/constants';
 import {
-  metricsGroupsAPIResponse,
+  metricsDashboardPayload,
   mockedEmptyResult,
   mockedQueryResultPayload,
   mockedQueryResultPayloadCoresTotal,
@@ -44,7 +44,7 @@ describe('Monitoring store Getters', () => {
         setupState({
           dashboard: { panel_groups: [] },
         });
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         groups = state.dashboard.panel_groups;
       });
 
@@ -53,21 +53,21 @@ describe('Monitoring store Getters', () => {
       });
 
       it('on an empty metric with no result, returns NO_DATA', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedEmptyResult);
 
         expect(getMetricStates()).toEqual([metricStates.NO_DATA]);
       });
 
       it('on a metric with a result, returns OK', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayload);
 
         expect(getMetricStates()).toEqual([metricStates.OK]);
       });
 
       it('on a metric with an error, returns an error', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_FAILURE](state, {
           metricId: groups[0].panels[0].metrics[0].metricId,
         });
@@ -76,7 +76,7 @@ describe('Monitoring store Getters', () => {
       });
 
       it('on multiple metrics with results, returns OK', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayloadCoresTotal);
 
@@ -87,7 +87,7 @@ describe('Monitoring store Getters', () => {
         expect(getMetricStates(state.dashboard.panel_groups[1].key)).toEqual([metricStates.OK]);
       });
       it('on multiple metrics errors', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
 
         mutations[types.RECEIVE_METRIC_RESULT_FAILURE](state, {
           metricId: groups[0].panels[0].metrics[0].metricId,
@@ -106,7 +106,7 @@ describe('Monitoring store Getters', () => {
       });
 
       it('on multiple metrics with errors', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
 
         // An success in 1 group
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayload);
@@ -168,27 +168,27 @@ describe('Monitoring store Getters', () => {
       });
 
       it('no loaded metric returns empty', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
 
         expect(metricsWithData()).toEqual([]);
       });
 
       it('an empty metric, returns empty', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedEmptyResult);
 
         expect(metricsWithData()).toEqual([]);
       });
 
       it('a metric with results, it returns a metric', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayload);
 
         expect(metricsWithData()).toEqual([mockedQueryResultPayload.metricId]);
       });
 
       it('multiple metrics with results, it return multiple metrics', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayloadCoresTotal);
 
@@ -199,7 +199,7 @@ describe('Monitoring store Getters', () => {
       });
 
       it('multiple metrics with results, it returns metrics filtered by group', () => {
-        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsGroupsAPIResponse);
+        mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayload);
         mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultPayloadCoresTotal);
 

spec/frontend/monitoring/store/mutations_spec.js

@@ -5,7 +5,7 @@ import * as types from '~/monitoring/stores/mutation_types';
 import state from '~/monitoring/stores/state';
 import { metricStates } from '~/monitoring/constants';
 import {
-  metricsGroupsAPIResponse,
+  metricsDashboardPayload,
   deploymentData,
   metricsDashboardResponse,
   dashboardGitResponse,
@@ -23,7 +23,7 @@ describe('Monitoring mutations', () => {
 
     beforeEach(() => {
       stateCopy.dashboard.panel_groups = [];
-      payload = metricsGroupsAPIResponse;
+      payload = metricsDashboardPayload;
     });
     it('adds a key to the group', () => {
       mutations[types.RECEIVE_METRICS_DATA_SUCCESS](stateCopy, payload);

spec/javascripts/monitoring/components/dashboard_resize_spec.js

@@ -6,7 +6,7 @@ import * as types from '~/monitoring/stores/mutation_types';
 import { createStore } from '~/monitoring/stores';
 import axios from '~/lib/utils/axios_utils';
 import {
-  metricsGroupsAPIResponse,
+  metricsDashboardPayload,
   mockedEmptyResult,
   mockedQueryResultPayload,
   mockedQueryResultPayloadCoresTotal,
@@ -41,7 +41,7 @@ function setupComponentStore(component) {
   // Load 2 panel groups
   component.$store.commit(
     `monitoringDashboard/${types.RECEIVE_METRICS_DATA_SUCCESS}`,
-    metricsGroupsAPIResponse,
+    metricsDashboardPayload,
   );
 
   // Load 3 panels to the dashboard, one with an empty result
@@ -98,7 +98,7 @@ describe('Dashboard', () => {
     let panelToggle;
     let chart;
     beforeEach(() => {
-      mock.onGet(mockApiEndpoint).reply(200, metricsGroupsAPIResponse);
+      mock.onGet(mockApiEndpoint).reply(200, metricsDashboardPayload);
 
       component = new DashboardComponent({
         el: document.querySelector('.prometheus-graphs'),

spec/lib/gitlab/email/receiver_spec.rb

@@ -5,6 +5,14 @@ require 'spec_helper'
 describe Gitlab::Email::Receiver do
   include_context :email_shared_context
 
+  shared_examples 'correctly finds the mail key' do
+    specify do
+      expect(Gitlab::Email::Handler).to receive(:for).with(an_instance_of(Mail::Message), 'gitlabhq/gitlabhq+auth_token').and_return(handler)
+
+      receiver.execute
+    end
+  end
+
   context 'when the email contains a valid email address in a header' do
     let(:handler) { double(:handler) }
 

spec/lib/gitlab/mail_room/mail_room_spec.rb

@@ -16,6 +16,40 @@ describe Gitlab::MailRoom do
     }
   end
 
+  shared_examples_for 'only truthy if both enabled and address are truthy' do |target_proc|
+    context 'with both enabled and address as truthy values' do
+      it 'is truthy' do
+        stub_config(enabled: true, address: 'localhost')
+
+        expect(target_proc.call).to be_truthy
+      end
+    end
+
+    context 'with address only as truthy' do
+      it 'is falsey' do
+        stub_config(enabled: false, address: 'localhost')
+
+        expect(target_proc.call).to be_falsey
+      end
+    end
+
+    context 'with enabled only as truthy' do
+      it 'is falsey' do
+        stub_config(enabled: true, address: nil)
+
+        expect(target_proc.call).to be_falsey
+      end
+    end
+
+    context 'with neither address nor enabled as truthy' do
+      it 'is falsey' do
+        stub_config(enabled: false, address: nil)
+
+        expect(target_proc.call).to be_falsey
+      end
+    end
+  end
+
   before do
     described_class.reset_config!
     allow(File).to receive(:exist?).and_return true

spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require 'support/shared_examples/malicious_regexp_shared_examples'
+require 'support/shared_examples/lib/gitlab/malicious_regexp_shared_examples'
 require 'support/helpers/stub_feature_flags'
 
 describe Gitlab::UntrustedRegexp::RubySyntax do

spec/lib/gitlab/untrusted_regexp_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require 'support/shared_examples/malicious_regexp_shared_examples'
+require 'support/shared_examples/lib/gitlab/malicious_regexp_shared_examples'
 
 describe Gitlab::UntrustedRegexp do
   describe '#initialize' do

spec/models/ci/build_trace_chunk_spec.rb

@@ -27,7 +27,42 @@ describe Ci::BuildTraceChunk, :clean_gitlab_redis_shared_state do
     let(:build) { create(:ci_build, :running, :trace_live, pipeline: pipeline, project: parent) }
     let(:subjects) { build.trace_chunks }
 
-    it_behaves_like 'fast destroyable'
+    describe 'Forbid #destroy and #destroy_all' do
+      it 'does not delete database rows and associted external data' do
+        expect(external_data_counter).to be > 0
+        expect(subjects.count).to be > 0
+
+        expect { subjects.first.destroy }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`')
+        expect { subjects.destroy_all }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`') # rubocop: disable DestroyAll
+
+        expect(subjects.count).to be > 0
+        expect(external_data_counter).to be > 0
+      end
+    end
+
+    describe '.fast_destroy_all' do
+      it 'deletes database rows and associted external data' do
+        expect(external_data_counter).to be > 0
+        expect(subjects.count).to be > 0
+
+        expect { subjects.fast_destroy_all }.not_to raise_error
+
+        expect(subjects.count).to eq(0)
+        expect(external_data_counter).to eq(0)
+      end
+    end
+
+    describe '.use_fast_destroy' do
+      it 'performs cascading delete with fast_destroy_all' do
+        expect(external_data_counter).to be > 0
+        expect(subjects.count).to be > 0
+
+        expect { parent.destroy }.not_to raise_error
+
+        expect(subjects.count).to eq(0)
+        expect(external_data_counter).to eq(0)
+      end
+    end
 
     def external_data_counter
       Gitlab::Redis::SharedState.with do |redis|

spec/services/projects/update_pages_service_spec.rb

@@ -176,6 +176,35 @@ describe Projects::UpdatePagesService do
   describe 'maximum pages artifacts size' do
     let(:metadata) { spy('metadata') }
 
+    shared_examples 'pages size limit is' do |size_limit|
+      context "when size is below the limit" do
+        before do
+          allow(metadata).to receive(:total_size).and_return(size_limit - 1.megabyte)
+        end
+
+        it 'updates pages correctly' do
+          subject.execute
+
+          expect(deploy_status.description).not_to be_present
+          expect(project.pages_metadatum).to be_deployed
+        end
+      end
+
+      context "when size is above the limit" do
+        before do
+          allow(metadata).to receive(:total_size).and_return(size_limit + 1.megabyte)
+        end
+
+        it 'limits the maximum size of gitlab pages' do
+          subject.execute
+
+          expect(deploy_status.description)
+            .to match(/artifacts for pages are too large/)
+          expect(deploy_status).to be_script_failure
+        end
+      end
+    end
+
     before do
       file = fixture_file_upload('spec/fixtures/pages.zip')
       metafile = fixture_file_upload('spec/fixtures/pages.zip.meta')

spec/support/banzai/reference_filter_shared_examples.rb

@@ -4,7 +4,7 @@
 #
 # Requires a reference:
 #   let(:reference) { '#42' }
-shared_examples 'a reference containing an element node' do
+RSpec.shared_examples 'a reference containing an element node' do
   let(:inner_html) { 'element <code>node</code> inside' }
   let(:reference_with_element) { %{<a href="#{reference}">#{inner_html}</a>} }
 
@@ -18,7 +18,7 @@ end
 #   subject { create(:user) }
 #   let(:reference) { subject.to_reference }
 #   let(:subject_name) { 'user' }
-shared_examples 'user reference or project reference' do
+RSpec.shared_examples 'user reference or project reference' do
   shared_examples 'it contains a data- attribute' do
     it 'includes a data- attribute' do
       doc = reference_filter("Hey #{reference}")

spec/support/services/clusters/create_service_shared.rb

 # frozen_string_literal: true
 
-shared_context 'valid cluster create params' do
+RSpec.shared_context 'valid cluster create params' do
   let(:params) do
     {
       name: 'test-cluster',
@@ -16,7 +16,7 @@ shared_context 'valid cluster create params' do
   end
 end
 
-shared_context 'invalid cluster create params' do
+RSpec.shared_context 'invalid cluster create params' do
   let(:params) do
     {
       name: 'test-cluster',
@@ -31,7 +31,7 @@ shared_context 'invalid cluster create params' do
   end
 end
 
-shared_examples 'create cluster service success' do
+RSpec.shared_examples 'create cluster service success' do
   it 'creates a cluster object and performs a worker' do
     expect(ClusterProvisionWorker).to receive(:perform_async)
 
@@ -53,7 +53,7 @@ shared_examples 'create cluster service success' do
   end
 end
 
-shared_examples 'create cluster service error' do
+RSpec.shared_examples 'create cluster service error' do
   it 'returns an error' do
     expect(ClusterProvisionWorker).not_to receive(:perform_async)
     expect { subject }.to change { Clusters::Cluster.count }.by(0)

spec/support/services/issuable_create_service_slash_commands_shared_examples.rb

@@ -3,7 +3,7 @@
 # Specifications for behavior common to all objects with executable attributes.
 # It can take a `default_params`.
 
-shared_examples 'new issuable record that supports quick actions' do
+RSpec.shared_examples 'new issuable record that supports quick actions' do
   let!(:project) { create(:project, :repository) }
   let(:user) { create(:user).tap { |u| project.add_maintainer(u) } }
   let(:assignee) { create(:user) }

spec/support/services/issuable_update_service_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuable update service' do
+RSpec.shared_examples 'issuable update service' do
   def update_issuable(opts)
     described_class.new(project, user, opts).execute(open_issuable)
   end

spec/support/services/migrate_to_ghost_user_service_shared_examples.rb

 # frozen_string_literal: true
 
-require "spec_helper"
-
-shared_examples "migrating a deleted user's associated records to the ghost user" do |record_class, fields|
+RSpec.shared_examples "migrating a deleted user's associated records to the ghost user" do |record_class, fields|
   record_class_name = record_class.to_s.titleize.downcase
 
   let(:project) do

spec/support/shared_contexts/change_access_checks_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'change access checks context' do
+RSpec.shared_context 'change access checks context' do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository) }
   let(:user_access) { Gitlab::UserAccess.new(user, project: project) }

spec/support/controllers/githubish_import_controller_shared_context.rb → spec/support/shared_contexts/controllers/githubish_import_controller_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'a GitHub-ish import controller' do
+RSpec.shared_context 'a GitHub-ish import controller' do
   let(:user) { create(:user) }
   let(:token) { "asdasd12345" }
   let(:access_params) { { github_access_token: token } }

spec/support/controllers/ldap_omniauth_callbacks_controller_shared_context.rb → spec/support/shared_contexts/controllers/ldap_omniauth_callbacks_controller_shared_context.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_context 'Ldap::OmniauthCallbacksController' do
+RSpec.shared_context 'Ldap::OmniauthCallbacksController' do
   include LoginHelpers
   include LdapHelpers
 

spec/support/shared_contexts/email_shared_context.rb

 # frozen_string_literal: true
 
-shared_context :email_shared_context do
+RSpec.shared_context :email_shared_context do
   let(:mail_key) { "59d8df8370b7e95c5a49fbf86aeb2c93" }
   let(:receiver) { Gitlab::Email::Receiver.new(email_raw) }
   let(:markdown) { "![image](uploads/image.png)" }
@@ -18,7 +18,7 @@ shared_context :email_shared_context do
   end
 end
 
-shared_examples :reply_processing_shared_examples do
+RSpec.shared_examples :reply_processing_shared_examples do
   context "when the user could not be found" do
     before do
       user.destroy

spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'GroupProjectsFinder context' do
   let(:group) { create(:group) }
   let(:subgroup) { create(:group, parent: group) }

spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'IssuesFinder context' do
   set(:user) { create(:user) }
   set(:user2) { create(:user) }

spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'MergeRequestsFinder multiple projects with merge requests context' do
   include ProjectForksHelper
 

spec/support/shared_contexts/finders/users_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'UsersFinder#execute filter by project context' do
   set(:normal_user) { create(:user, username: 'johndoe') }
   set(:blocked_user) { create(:user, :blocked, username: 'notsorandom') }

spec/support/shared_contexts/json_response_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'JSON response' do
+RSpec.shared_context 'JSON response' do
   let(:json_response) { JSON.parse(response.body) }
 end

spec/support/shared_contexts/mailers/notify_shared_context.rb

+# frozen_string_literal: true
+
+RSpec.shared_context 'gitlab email notification' do
+  set(:group) { create(:group) }
+  set(:subgroup) { create(:group, parent: group) }
+  set(:project) { create(:project, :repository, name: 'a-known-name', group: group) }
+  set(:recipient) { create(:user, email: 'recipient@example.com') }
+
+  let(:gitlab_sender_display_name) { Gitlab.config.gitlab.email_display_name }
+  let(:gitlab_sender) { Gitlab.config.gitlab.email_from }
+  let(:gitlab_sender_reply_to) { Gitlab.config.gitlab.email_reply_to }
+  let(:new_user_address) { 'newguy@example.com' }
+
+  before do
+    email = recipient.emails.create(email: "notifications@example.com")
+    recipient.update_attribute(:notification_email, email.email)
+    stub_incoming_email_setting(enabled: true, address: "reply+%{key}@#{Gitlab.config.gitlab.host}")
+  end
+end
+
+RSpec.shared_context 'reply-by-email is enabled with incoming address without %{key}' do
+  before do
+    stub_incoming_email_setting(enabled: true, address: "reply@#{Gitlab.config.gitlab.host}")
+  end
+end

spec/support/shared_contexts/merge_request_create.rb → spec/support/shared_contexts/merge_request_create_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'merge request create context' do
+RSpec.shared_context 'merge request create context' do
   let(:user)        { create(:user) }
   let(:user2)       { create(:user) }
   let(:target_project) { create(:project, :public, :repository) }

spec/support/shared_contexts/merge_request_edit.rb → spec/support/shared_contexts/merge_request_edit_shared_context.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-shared_context 'merge request edit context' do
+RSpec.shared_context 'merge request edit context' do
   let(:user)        { create(:user) }
   let(:user2)       { create(:user) }
   let!(:milestone)   { create(:milestone, project: target_project) }

spec/support/shared_contexts/merge_requests_allowing_collaboration.rb → spec/support/shared_contexts/merge_requests_allowing_collaboration_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'merge request allowing collaboration' do
+RSpec.shared_context 'merge request allowing collaboration' do
   include ProjectForksHelper
 
   let(:canonical) { create(:project, :public, :repository) }

spec/support/shared_contexts/rack_attack_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'rack attack cache store' do
+RSpec.shared_context 'rack attack cache store' do
   around do |example|
     # Instead of test environment's :null_store so the throttles can increment
     Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new

spec/support/shared_contexts/services_shared_context.rb

 # frozen_string_literal: true
 
 Service.available_services_names.each do |service|
-  shared_context service do
+  RSpec.shared_context service do
     let(:dashed_service) { service.dasherize }
     let(:service_method) { "#{service}_service".to_sym }
     let(:service_klass) { "#{service}_service".classify.constantize }

spec/support/shared_contexts/session_shared_context.rb

@@ -4,7 +4,7 @@
 # let(:session) variable
 # we do not use a parameter such as |session| because it does not play nice
 # with let variables
-shared_context 'custom session' do
+RSpec.shared_context 'custom session' do
   let!(:session) { {} }
 
   around do |example|

spec/support/shared_contexts/unique_ip_check_shared_context.rb

+# frozen_string_literal: true
+
+RSpec.shared_context 'unique ips sign in limit' do
+  include StubENV
+  let(:request_context) { Gitlab::RequestContext.instance }
+
+  before do
+    Gitlab::Redis::Cache.with(&:flushall)
+    Gitlab::Redis::Queues.with(&:flushall)
+    Gitlab::Redis::SharedState.with(&:flushall)
+  end
+
+  before do
+    stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
+
+    Gitlab::CurrentSettings.update!(
+      unique_ips_limit_enabled: true,
+      unique_ips_limit_time_window: 10000
+    )
+
+    # Make sure we're working with the same reqeust context everywhere
+    allow(Gitlab::RequestContext).to receive(:instance).and_return(request_context)
+  end
+
+  def change_ip(ip)
+    allow(request_context).to receive(:client_ip).and_return(ip)
+  end
+
+  def request_from_ip(ip)
+    change_ip(ip)
+    request
+    response
+  end
+
+  def operation_from_ip(ip)
+    change_ip(ip)
+    operation
+  end
+end

spec/support/shared_contexts/upload_type_check_shared_context.rb

@@ -2,7 +2,7 @@
 
 # Construct an `uploader` variable that is configured to `check_upload_type`
 # with `mime_types` and `extensions`.
-shared_context 'uploader with type check' do
+RSpec.shared_context 'uploader with type check' do
   let(:uploader_class) do
     Class.new(GitlabUploader) do
       include UploadTypeCheck::Concern
@@ -20,7 +20,7 @@ shared_context 'uploader with type check' do
   end
 end
 
-shared_context 'stubbed MimeMagic mime type detection' do
+RSpec.shared_context 'stubbed MimeMagic mime type detection' do
   let(:mime_type) { '' }
   let(:magic_mime) { mime_type }
   let(:ext_mime) { mime_type }

spec/support/shared_contexts/url_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'invalid urls' do
+RSpec.shared_context 'invalid urls' do
   let(:urls_with_CRLF) do
     ["http://127.0.0.1:333/pa\rth",
      "http://127.0.0.1:333/pa\nth",

spec/support/shared_examples/boards/multiple_issue_boards_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'multiple issue boards' do
+RSpec.shared_examples 'multiple issue boards' do
   context 'authorized user' do
     before do
       parent.add_maintainer(user)

spec/support/shared_examples/ci/auto_merge_merge_requests_examples.rb → spec/support/shared_examples/ci/auto_merge_merge_requests_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'aborted merge requests for MWPS' do
+RSpec.shared_examples 'aborted merge requests for MWPS' do
   let(:aborted_message) do
     /aborted the automatic merge because target branch was updated/
   end
@@ -23,7 +23,7 @@ shared_examples 'aborted merge requests for MWPS' do
   end
 end
 
-shared_examples 'maintained merge requests for MWPS' do
+RSpec.shared_examples 'maintained merge requests for MWPS' do
   it 'does not cancel auto merge' do
     expect(merge_request.auto_merge_enabled?).to be_truthy
     expect(merge_request.notes).to be_empty

spec/support/shared_examples/ci/pipeline_email_examples.rb → spec/support/shared_examples/ci/pipeline_email_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'correct pipeline information for pipelines for merge requests' do
+RSpec.shared_examples 'correct pipeline information for pipelines for merge requests' do
   context 'when pipeline for merge request' do
     let(:pipeline) { merge_request.all_pipelines.first }
 

spec/support/shared_examples/ci/stage_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'manual playable stage' do |stage_type|
+RSpec.shared_examples 'manual playable stage' do |stage_type|
   let(:stage) { build(stage_type, status: status) }
 
   describe '#manual_playable?' do

spec/support/shared_examples/controllers/application_settings_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'renders correct panels' do
+RSpec.shared_examples 'renders correct panels' do
   it 'renders correct action on error' do
     expect_next_instance_of(ApplicationSettings::UpdateService) do |service|
       allow(service).to receive(:execute).and_return(false)

spec/support/shared_examples/discussions_provider_shared_examples.rb → spec/support/shared_examples/controllers/discussions_provider_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'discussions provider' do
+RSpec.shared_examples 'discussions provider' do
   it 'returns the expected discussions' do
     get :discussions, params: { namespace_id: project.namespace, project_id: project, id: requested_iid }
 

spec/support/shared_examples/controllers/environments_controller_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'successful response for #cancel_auto_stop' do
+RSpec.shared_examples 'successful response for #cancel_auto_stop' do
   include GitlabRoutingHelper
 
   context 'when request is html' do
@@ -42,7 +42,7 @@ shared_examples_for 'successful response for #cancel_auto_stop' do
   end
 end
 
-shared_examples_for 'failed response for #cancel_auto_stop' do
+RSpec.shared_examples 'failed response for #cancel_auto_stop' do
   context 'when request is html' do
     let(:params) { environment_params(format: :html) }
 

spec/support/shared_examples/controllers/error_tracking_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'sets the polling header' do
+RSpec.shared_examples 'sets the polling header' do
   subject { response.headers[Gitlab::PollingInterval::HEADER_NAME] }
 
   it { is_expected.to eq '1000'}

spec/support/shared_examples/controllers/external_authorization_service_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'disabled when using an external authorization service' do
+RSpec.shared_examples 'disabled when using an external authorization service' do
   include ExternalAuthorizationServiceHelpers
 
   it 'works when the feature is not enabled' do
@@ -20,7 +18,7 @@ shared_examples 'disabled when using an external authorization service' do
   end
 end
 
-shared_examples 'unauthorized when external service denies access' do
+RSpec.shared_examples 'unauthorized when external service denies access' do
   include ExternalAuthorizationServiceHelpers
 
   it 'allows access when the authorization service allows it' do

spec/support/controllers/githubish_import_controller_shared_examples.rb → spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb

@@ -10,7 +10,7 @@ def assign_session_token(provider)
   session[:"#{provider}_access_token"] = 'asdasd12345'
 end
 
-shared_examples 'a GitHub-ish import controller: POST personal_access_token' do
+RSpec.shared_examples 'a GitHub-ish import controller: POST personal_access_token' do
   let(:status_import_url) { public_send("status_import_#{provider}_url") }
 
   it "updates access token" do
@@ -38,7 +38,7 @@ shared_examples 'a GitHub-ish import controller: POST personal_access_token' do
   end
 end
 
-shared_examples 'a GitHub-ish import controller: GET new' do
+RSpec.shared_examples 'a GitHub-ish import controller: GET new' do
   let(:status_import_url) { public_send("status_import_#{provider}_url") }
 
   it "redirects to status if we already have a token" do
@@ -57,7 +57,7 @@ shared_examples 'a GitHub-ish import controller: GET new' do
   end
 end
 
-shared_examples 'a GitHub-ish import controller: GET status' do
+RSpec.shared_examples 'a GitHub-ish import controller: GET status' do
   let(:new_import_url) { public_send("new_import_#{provider}_url") }
   let(:user) { create(:user) }
   let(:repo) { OpenStruct.new(login: 'vim', full_name: 'asd/vim', name: 'vim', owner: { login: 'owner' }) }
@@ -76,7 +76,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
 
     get :status, format: :json
 
-    expect(response).to have_gitlab_http_status(200)
+    expect(response).to have_gitlab_http_status(:ok)
     expect(json_response.dig("imported_projects", 0, "id")).to eq(project.id)
     expect(json_response.dig("provider_repos", 0, "id")).to eq(repo.id)
     expect(json_response.dig("provider_repos", 1, "id")).to eq(org_repo.id)
@@ -107,7 +107,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
 
     get :status
 
-    expect(response).to have_gitlab_http_status(200)
+    expect(response).to have_gitlab_http_status(:ok)
   end
 
   it "handles an invalid access token" do
@@ -153,7 +153,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
     it 'filters list of repositories by name' do
       get :status, params: { filter: 'emacs' }, format: :json
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(json_response.dig("imported_projects").count).to eq(0)
       expect(json_response.dig("provider_repos").count).to eq(1)
       expect(json_response.dig("provider_repos", 0, "id")).to eq(repo_2.id)
@@ -173,7 +173,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
   end
 end
 
-shared_examples 'a GitHub-ish import controller: POST create' do
+RSpec.shared_examples 'a GitHub-ish import controller: POST create' do
   let(:user) { create(:user) }
   let(:provider_username) { user.username }
   let(:provider_user) { OpenStruct.new(login: provider_username) }
@@ -198,7 +198,7 @@ shared_examples 'a GitHub-ish import controller: POST create' do
 
     post :create, format: :json
 
-    expect(response).to have_gitlab_http_status(200)
+    expect(response).to have_gitlab_http_status(:ok)
   end
 
   it 'returns 422 response with the base error when the project could not be imported' do
@@ -212,7 +212,7 @@ shared_examples 'a GitHub-ish import controller: POST create' do
 
     post :create, format: :json
 
-    expect(response).to have_gitlab_http_status(422)
+    expect(response).to have_gitlab_http_status(:unprocessable_entity)
     expect(json_response['errors']).to eq('Name is invalid, Path is old')
   end
 
@@ -484,13 +484,13 @@ shared_examples 'a GitHub-ish import controller: POST create' do
 
         post :create, params: { target_namespace: other_namespace.name }, format: :json
 
-        expect(response).to have_gitlab_http_status(422)
+        expect(response).to have_gitlab_http_status(:unprocessable_entity)
       end
     end
   end
 end
 
-shared_examples 'a GitHub-ish import controller: GET realtime_changes' do
+RSpec.shared_examples 'a GitHub-ish import controller: GET realtime_changes' do
   let(:user) { create(:user) }
 
   before do

spec/support/shared_examples/instance_statistics_controllers_shared_examples.rb → spec/support/shared_examples/controllers/instance_statistics_controllers_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'instance statistics availability' do
+RSpec.shared_examples 'instance statistics availability' do
   let(:user) { create(:user) }
 
   before do

spec/support/shared_examples/controllers/issuable_notes_filter_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuable notes filter' do
+RSpec.shared_examples 'issuable notes filter' do
   let(:params) do
     if issuable_parent.is_a?(Project)
       { namespace_id: issuable_parent.namespace, project_id: issuable_parent, id: issuable.iid }

spec/support/shared_examples/issuables_list_metadata_shared_examples.rb → spec/support/shared_examples/controllers/issuables_list_metadata_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuables list meta-data' do |issuable_type, action = nil|
+RSpec.shared_examples 'issuables list meta-data' do |issuable_type, action = nil|
   include ProjectForksHelper
 
   def get_action(action, project, extra_params = {})

spec/support/shared_examples/controllers/issuables_requiring_filter_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuables requiring filter' do |action|
+RSpec.shared_examples 'issuables requiring filter' do |action|
   it "doesn't load any issuables if no filter is set" do
     expect_any_instance_of(described_class).not_to receive(:issuables_collection)
 

spec/support/shared_examples/milestone_tabs_examples.rb → spec/support/shared_examples/controllers/milestone_tabs_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'milestone tabs' do
+RSpec.shared_examples 'milestone tabs' do
   def go(path, extra_params = {})
     params =
       case milestone

spec/support/shared_examples/controllers/paginated_collection_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'paginated collection' do
+RSpec.shared_examples 'paginated collection' do
   let(:collection) { nil }
   let(:last_page) { collection.page.total_pages }
   let(:action) { :index }

spec/support/shared_examples/controllers/repository_lfs_file_load_examples.rb → spec/support/shared_examples/controllers/repository_lfs_file_load_shared_examples.rb

@@ -17,7 +17,7 @@
 # it_behaves_like 'a controller that can serve LFS files', skip_lfs_disabled_tests: true do
 #   ...
 # end
-shared_examples 'a controller that can serve LFS files' do |options = {}|
+RSpec.shared_examples 'a controller that can serve LFS files' do |options = {}|
   let(:lfs_oid) { '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897' }
   let(:lfs_size) { '1575078' }
   let!(:lfs_object) { create(:lfs_object, oid: lfs_oid, size: lfs_size) }

spec/support/controllers/sessionless_auth_controller_shared_examples.rb → spec/support/shared_examples/controllers/sessionless_auth_controller_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'authenticates sessionless user' do |path, format, params|
+RSpec.shared_examples 'authenticates sessionless user' do |path, format, params|
   params ||= {}
 
   before do
@@ -20,14 +20,14 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
 
       get path, params: default_params.merge(private_token: personal_access_token.token)
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(controller.current_user).to eq(user)
     end
 
     it 'does not log the user in if page is public', if: params[:public] do
       get path, params: default_params
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(controller.current_user).to be_nil
     end
   end
@@ -48,7 +48,7 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
 
       get path, params: default_params.merge(private_token: personal_access_token.token)
 
-      expect(response).not_to have_gitlab_http_status(200)
+      expect(response).not_to have_gitlab_http_status(:ok)
     end
   end
 
@@ -62,7 +62,7 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
       @request.headers['PRIVATE-TOKEN'] = personal_access_token.token
       get path, params: default_params
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
   end
 
@@ -75,7 +75,7 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
 
       get path, params: default_params.merge(feed_token: user.feed_token)
 
-      expect(response).to have_gitlab_http_status 200
+      expect(response).to have_gitlab_http_status(:ok)
     end
   end
 

spec/support/shared_examples/controllers/set_sort_order_from_user_preference_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'set sort order from user preference' do
+RSpec.shared_examples 'set sort order from user preference' do
   describe '#set_sort_order_from_user_preference' do
     # There is no sorting_field defined in any CE controllers yet,
     # however any other field present in user_preferences table can be used for testing.

spec/support/shared_examples/controllers/todos_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'todos actions' do
+RSpec.shared_examples 'todos actions' do
   context 'when authorized' do
     before do
       sign_in(user)

spec/support/shared_examples/trackable_shared_examples.rb → spec/support/shared_examples/controllers/trackable_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'a Trackable Controller' do
+RSpec.shared_examples 'a Trackable Controller' do
   describe '#track_event' do
     before do
       sign_in user

spec/support/shared_examples/update_invalid_issuable.rb → spec/support/shared_examples/controllers/update_invalid_issuable_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'update invalid issuable' do |klass|
+RSpec.shared_examples 'update invalid issuable' do |klass|
   let(:params) do
     {
       namespace_id: project.namespace.path,

spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'handle uploads' do
+RSpec.shared_examples 'handle uploads' do
   let(:user)  { create(:user) }
   let(:jpg)   { fixture_file_upload('spec/fixtures/rails_sample.jpg', 'image/jpg') }
   let(:txt)   { fixture_file_upload('spec/fixtures/doc_sample.txt', 'text/plain') }
@@ -287,7 +287,7 @@ shared_examples 'handle uploads' do
   end
 end
 
-shared_examples 'handle uploads authorize' do
+RSpec.shared_examples 'handle uploads authorize' do
   describe "POST #authorize" do
     context 'when a user is not authorized to upload a file' do
       it 'returns 404 status' do

spec/support/shared_examples/controllers/variables_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'GET #show lists all variables' do
+RSpec.shared_examples 'GET #show lists all variables' do
   it 'renders the variables as json' do
     subject
 
@@ -14,7 +14,7 @@ shared_examples 'GET #show lists all variables' do
   end
 end
 
-shared_examples 'PATCH #update updates variables' do
+RSpec.shared_examples 'PATCH #update updates variables' do
   let(:variable_attributes) do
     { id: variable.id,
       key: variable.key,

spec/support/shared_examples/email_shared_examples.rb

-# frozen_string_literal: true
-
-shared_examples_for 'correctly finds the mail key' do
-  specify do
-    expect(Gitlab::Email::Handler).to receive(:for).with(an_instance_of(Mail::Message), 'gitlabhq/gitlabhq+auth_token').and_return(handler)
-
-    receiver.execute
-  end
-end

spec/support/shared_examples/evidence_updated_exposed_fields.rb

-# frozen_string_literal: true
-
-shared_examples 'updated exposed field' do
-  it 'creates another Evidence object' do
-    model.send("#{updated_field}=", updated_value)
-
-    expect(model.evidence_summary_keys).to include(updated_field)
-    expect { model.save! }.to change(Evidence, :count).by(1)
-    expect(updated_json_field).to eq(updated_value)
-  end
-end
-
-shared_examples 'updated non-exposed field' do
-  it 'does not create any Evidence object' do
-    model.send("#{updated_field}=", updated_value)
-
-    expect(model.evidence_summary_keys).not_to include(updated_field)
-    expect { model.save! }.not_to change(Evidence, :count)
-  end
-end
-
-shared_examples 'updated field on non-linked entity' do
-  it 'does not create any Evidence object' do
-    model.send("#{updated_field}=", updated_value)
-
-    expect(model.evidence_summary_keys).to be_empty
-    expect { model.save! }.not_to change(Evidence, :count)
-  end
-end

spec/support/shared_examples/fast_destroy_all.rb

-# frozen_string_literal: true
-
-shared_examples_for 'fast destroyable' do
-  describe 'Forbid #destroy and #destroy_all' do
-    it 'does not delete database rows and associted external data' do
-      expect(external_data_counter).to be > 0
-      expect(subjects.count).to be > 0
-
-      expect { subjects.first.destroy }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`')
-      expect { subjects.destroy_all }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`') # rubocop: disable DestroyAll
-
-      expect(subjects.count).to be > 0
-      expect(external_data_counter).to be > 0
-    end
-  end
-
-  describe '.fast_destroy_all' do
-    it 'deletes database rows and associted external data' do
-      expect(external_data_counter).to be > 0
-      expect(subjects.count).to be > 0
-
-      expect { subjects.fast_destroy_all }.not_to raise_error
-
-      expect(subjects.count).to eq(0)
-      expect(external_data_counter).to eq(0)
-    end
-  end
-
-  describe '.use_fast_destroy' do
-    it 'performs cascading delete with fast_destroy_all' do
-      expect(external_data_counter).to be > 0
-      expect(subjects.count).to be > 0
-
-      expect { parent.destroy }.not_to raise_error
-
-      expect(subjects.count).to eq(0)
-      expect(external_data_counter).to eq(0)
-    end
-  end
-end

spec/support/shared_examples/features/archive_download_buttons_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'archive download buttons' do
+RSpec.shared_examples 'archive download buttons' do
   let(:path_to_visit) { project_path(project) }
   let(:ref) { project.default_branch }
 

spec/support/shared_examples/features/comments_on_merge_request_files_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'comment on merge request file' do
+RSpec.shared_examples 'comment on merge request file' do
   it 'adds a comment' do
     click_diff_line(find("[id='#{sample_commit.line_code}']"))
 

spec/support/shared_examples/dirty_submit_form_shared_examples.rb → spec/support/shared_examples/features/dirty_submit_form_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'dirty submit form' do |selector_args|
+RSpec.shared_examples 'dirty submit form' do |selector_args|
   selectors = selector_args.is_a?(Array) ? selector_args : [selector_args]
 
   def expect_disabled_state(form, submit_selector, is_disabled = true)

spec/support/features/discussion_comments_shared_example.rb → spec/support/shared_examples/features/discussion_comments_shared_example.rb

 # frozen_string_literal: true
 
-shared_examples 'thread comments' do |resource_name|
+RSpec.shared_examples 'thread comments' do |resource_name|
   let(:form_selector) { '.js-main-target-form' }
   let(:dropdown_selector) { "#{form_selector} .comment-type-dropdown" }
   let(:toggle_selector) { "#{dropdown_selector} .dropdown-toggle" }

spec/support/shared_examples/features/issuable_sidebar_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issue sidebar stays collapsed on mobile' do
+RSpec.shared_examples 'issue sidebar stays collapsed on mobile' do
   before do
     resize_screen_xs
   end

spec/support/shared_examples/features/issuables_user_dropdown_behaviors_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuable user dropdown behaviors' do
+RSpec.shared_examples 'issuable user dropdown behaviors' do
   include FilteredSearchHelpers
 
   before do

spec/support/shared_examples/features/multiple_assignees_mr_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'multiple assignees merge request' do |action, save_button_title|
+RSpec.shared_examples 'multiple assignees merge request' do |action, save_button_title|
   it "#{action} a MR with multiple assignees", :js do
     find('.js-assignee-search').click
     page.within '.dropdown-menu-user' do

spec/support/shared_examples/features/project_features_apply_to_issuables_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'project features apply to issuables' do |klass|
+RSpec.shared_examples 'project features apply to issuables' do |klass|
   let(:described_class) { klass }
 
   let(:group) { create(:group) }

spec/support/shared_examples/project_list_shared_examples.rb → spec/support/shared_examples/features/project_list_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'shows public projects' do
+RSpec.shared_examples 'shows public projects' do
   it 'shows projects' do
     expect(page).to have_content(public_project.title)
     expect(page).not_to have_content(internal_project.title)
@@ -9,7 +9,7 @@ shared_examples 'shows public projects' do
   end
 end
 
-shared_examples 'shows public and internal projects' do
+RSpec.shared_examples 'shows public and internal projects' do
   it 'shows projects' do
     expect(page).to have_content(public_project.title)
     expect(page).to have_content(internal_project.title)

spec/support/shared_examples/features/protected_branches_access_control_ce.rb → spec/support/shared_examples/features/protected_branches_access_control_ce_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples "protected branches > access control > CE" do
+RSpec.shared_examples "protected branches > access control > CE" do
   ProtectedRefAccess::HUMAN_ACCESS_LEVELS.each do |(access_type_id, access_type_name)|
     it "allows creating protected branches that #{access_type_name} can push to" do
       visit project_protected_branches_path(project)

spec/support/features/reportable_note_shared_examples.rb → spec/support/shared_examples/features/reportable_note_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'reportable note' do |type|
+RSpec.shared_examples 'reportable note' do |type|
   include MobileHelpers
   include NotesHelper
 

spec/support/features/resolving_discussions_in_issues_shared_examples.rb → spec/support/shared_examples/features/resolving_discussions_in_issues_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'creating an issue for a thread' do
+RSpec.shared_examples 'creating an issue for a thread' do
   it 'shows an issue with the title filled in' do
     title_field = page.find_field('issue[title]')
 

spec/support/features/rss_shared_examples.rb → spec/support/shared_examples/features/rss_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples "an autodiscoverable RSS feed with current_user's feed token" do
+RSpec.shared_examples "an autodiscoverable RSS feed with current_user's feed token" do
   it "has an RSS autodiscovery link tag with current_user's feed token" do
     expect(page).to have_css("link[type*='atom+xml'][href*='feed_token=#{user.feed_token}']", visible: false)
   end
 end
 
-shared_examples "it has an RSS button with current_user's feed token" do
+RSpec.shared_examples "it has an RSS button with current_user's feed token" do
   it "shows the RSS button with current_user's feed token" do
     expect(page)
       .to have_css("a:has(.fa-rss)[href*='feed_token=#{user.feed_token}']")
@@ -14,13 +14,13 @@ shared_examples "it has an RSS button with current_user's feed token" do
   end
 end
 
-shared_examples "an autodiscoverable RSS feed without a feed token" do
+RSpec.shared_examples "an autodiscoverable RSS feed without a feed token" do
   it "has an RSS autodiscovery link tag without a feed token" do
     expect(page).to have_css("link[type*='atom+xml']:not([href*='feed_token'])", visible: false)
   end
 end
 
-shared_examples "it has an RSS button without a feed token" do
+RSpec.shared_examples "it has an RSS button without a feed token" do
   it "shows the RSS button without a feed token" do
     expect(page)
       .to have_css("a:has(.fa-rss):not([href*='feed_token'])")

spec/support/shared_examples/features/search_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'top right search form' do
+RSpec.shared_examples 'top right search form' do
   it 'does not show top right search form' do
     expect(page).not_to have_selector('.search')
   end

spec/support/shared_examples/showing_user_status_shared_examples.rb → spec/support/shared_examples/features/showing_user_status_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'showing user status' do
+RSpec.shared_examples 'showing user status' do
   let!(:status) { create(:user_status, user: user_with_status, emoji: 'smirk', message: 'Authoring this object') }
 
   it 'shows the status' do

spec/support/features/variable_list_shared_examples.rb → spec/support/shared_examples/features/variable_list_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'variable list' do
+RSpec.shared_examples 'variable list' do
   it 'shows list of variables' do
     page.within('.js-ci-variable-list-section') do
       expect(first('.js-ci-variable-input-key').value).to eq(variable.key)

spec/support/shared_examples/wiki_file_attachments_examples.rb → spec/support/shared_examples/features/wiki_file_attachments_shared_examples.rb

@@ -3,7 +3,7 @@
 # Requires a context containing:
 #   project
 
-shared_examples 'wiki file attachments' do
+RSpec.shared_examples 'wiki file attachments' do
   include DropzoneHelper
 
   context 'uploading attachments', :js do

spec/support/shared_examples/finders/assignees_filter_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'assignee ID filter' do
+RSpec.shared_examples 'assignee ID filter' do
   it 'returns issuables assigned to that user' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'assignee NOT ID filter' do
+RSpec.shared_examples 'assignee NOT ID filter' do
   it 'returns issuables not assigned to that user' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'assignee username filter' do
+RSpec.shared_examples 'assignee username filter' do
   it 'returns issuables assigned to those users' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'assignee NOT username filter' do
+RSpec.shared_examples 'assignee NOT username filter' do
   it 'returns issuables not assigned to those users' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'no assignee filter' do
+RSpec.shared_examples 'no assignee filter' do
   let(:params) { { assignee_id: 'None' } }
 
   it 'returns issuables not assigned to any assignee' do
@@ -38,7 +38,7 @@ shared_examples 'no assignee filter' do
   end
 end
 
-shared_examples 'any assignee filter' do
+RSpec.shared_examples 'any assignee filter' do
   context '' do
     let(:params) { { assignee_id: 'Any' } }
 

spec/support/shared_examples/finders/finder_with_external_authorization_enabled.rb → spec/support/shared_examples/finders/finder_with_external_authorization_enabled_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'a finder with external authorization service' do
+RSpec.shared_examples 'a finder with external authorization service' do
   include ExternalAuthorizationServiceHelpers
 
   let(:user) { create(:user) }

spec/support/shared_examples/graphql/failure_to_find_anything.rb → spec/support/shared_examples/graphql/failure_to_find_anything_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 # Shared example for legal queries that are expected to return nil.
 # Requires the following let bindings to be defined:
 #  - post_query: action to send the query
 #  - path: array of keys from query root to the result
-shared_examples 'a failure to find anything' do
+RSpec.shared_examples 'a failure to find anything' do
   it 'finds nothing' do
     post_query
 

spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb

 # frozen_string_literal: true
-require 'spec_helper'
 
-shared_context 'exposing regular notes on a noteable in GraphQL' do
+RSpec.shared_context 'exposing regular notes on a noteable in GraphQL' do
   include GraphqlHelpers
 
   let(:note) do

spec/support/shared_examples/uses_gitlab_url_blocker_examples.rb → spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'a request using Gitlab::UrlBlocker' do
+RSpec.shared_examples 'a request using Gitlab::UrlBlocker' do
   # Written to test internal patches against 3rd party libraries
   #
   # Expects the following to be available in the example contexts:

spec/support/shared_examples/legacy_path_redirect_shared_examples.rb

-# frozen_string_literal: true
-
-shared_examples 'redirecting a legacy path' do |source, target|
-  include RSpec::Rails::RequestExampleGroup
-
-  it "redirects #{source} to #{target} when the resource does not exist" do
-    expect(get(source)).to redirect_to(target)
-  end
-
-  it "does not redirect #{source} to #{target} when the resource exists" do
-    resource
-
-    expect(get(source)).not_to redirect_to(target)
-  end
-end
-
-shared_examples 'redirecting a legacy project path' do |source, target|
-  include RSpec::Rails::RequestExampleGroup
-
-  it "redirects #{source} to #{target}" do
-    expect(get(source)).to redirect_to(target)
-  end
-end