Merge branch 'frozen-string-enable-app-validators' into 'master'

Enable frozen string in apps/validators/*.rb

See merge request gitlab-org/gitlab-ce!20220

app/validators/abstract_path_validator.rb

+# frozen_string_literal: true
+
 class AbstractPathValidator < ActiveModel::EachValidator
   extend Gitlab::EncodingHelper
 

app/validators/certificate_fingerprint_validator.rb

+# frozen_string_literal: true
+
 class CertificateFingerprintValidator < ActiveModel::EachValidator
   FINGERPRINT_PATTERN = /\A([a-zA-Z0-9]{2}[\s\-:]?){16,}\z/.freeze
 

app/validators/certificate_key_validator.rb

+# frozen_string_literal: true
+
 # UrlValidator
 #
 # Custom validator for private keys.

app/validators/certificate_validator.rb

+# frozen_string_literal: true
+
 # UrlValidator
 #
 # Custom validator for private keys.

app/validators/cluster_name_validator.rb

+# frozen_string_literal: true
+
 # ClusterNameValidator
 #
 # Custom validator for ClusterName.

app/validators/color_validator.rb

+# frozen_string_literal: true
+
 # ColorValidator
 #
 # Custom validator for web color codes. It requires the leading hash symbol and

app/validators/cron_timezone_validator.rb

+# frozen_string_literal: true
+
 # CronTimezoneValidator
 #
 # Custom validator for CronTimezone.

app/validators/cron_validator.rb

+# frozen_string_literal: true
+
 # CronValidator
 #
 # Custom validator for Cron.

app/validators/duration_validator.rb

+# frozen_string_literal: true
+
 # DurationValidator
 #
 # Validate the format conforms with ChronicDuration

app/validators/email_validator.rb

+# frozen_string_literal: true
+
 class EmailValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     record.errors.add(attribute, :invalid) unless value =~ Devise.email_regexp

app/validators/key_restriction_validator.rb

+# frozen_string_literal: true
+
 class KeyRestrictionValidator < ActiveModel::EachValidator
   FORBIDDEN = -1
 

app/validators/line_code_validator.rb

+# frozen_string_literal: true
+
 # LineCodeValidator
 #
 # Custom validator for GitLab line codes.

app/validators/namespace_name_validator.rb

+# frozen_string_literal: true
+
 # NamespaceNameValidator
 #
 # Custom validator for GitLab namespace name strings.

app/validators/namespace_path_validator.rb

+# frozen_string_literal: true
+
 class NamespacePathValidator < AbstractPathValidator
   extend Gitlab::EncodingHelper
 

app/validators/project_path_validator.rb

+# frozen_string_literal: true
+
 class ProjectPathValidator < AbstractPathValidator
   extend Gitlab::EncodingHelper
 

app/validators/public_url_validator.rb

+# frozen_string_literal: true
+
 # PublicUrlValidator
 #
 # Custom validator for URLs. This validator works like UrlValidator but

app/validators/top_level_group_validator.rb

+# frozen_string_literal: true
+
 class TopLevelGroupValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     if value&.subgroup?

app/validators/url_validator.rb

+# frozen_string_literal: true
+
 # UrlValidator
 #
 # Custom validator for URLs.

app/validators/variable_duplicates_validator.rb

+# frozen_string_literal: true
+
 # VariableDuplicatesValidator
 #
 # This validator is designed for especially the following condition
@@ -22,8 +24,8 @@ class VariableDuplicatesValidator < ActiveModel::EachValidator
   def validate_duplicates(record, attribute, values)
     duplicates = values.reject(&:marked_for_destruction?).group_by(&:key).select { |_, v| v.many? }.map(&:first)
     if duplicates.any?
-      error_message = "have duplicate values (#{duplicates.join(", ")})"
-      error_message += " for #{values.first.send(options[:scope])} scope" if options[:scope] # rubocop:disable GitlabSecurity/PublicSend
+      error_message = +"have duplicate values (#{duplicates.join(", ")})"
+      error_message << " for #{values.first.send(options[:scope])} scope" if options[:scope] # rubocop:disable GitlabSecurity/PublicSend
       record.errors.add(attribute, error_message)
     end
   end

changelogs/unreleased/frozen-string-enable-app-validators.yml

+---
+title: Enable frozen string in apps/validators/*.rb
+merge_request: 20220
+author: gfyoung
+type: other