Merge branch 'test-for-burndown-chart' into 'master'

Add automated test  for the burndown chart starter feature

Closes gitlab-org/quality/testcases#175

See merge request gitlab-org/gitlab!18009

ee/app/views/shared/milestones/_burndown.html.haml

@@ -12,11 +12,11 @@
       .btn-group.js-burndown-data-selector
         %button.btn.btn-sm.btn-primary{ data: { show: 'count' } }
           Issues
-        %button.btn.btn-sm.btn-primary.btn-inverted{ data: { show: 'weight' } }
+        %button.btn.btn-sm.btn-primary.btn-inverted{ data: { show: 'weight', qa_selector: 'weight_button' } }
           Issue weight
   .burndown-chart{ data: { start_date: burndown.start_date.strftime("%Y-%m-%d"),
     due_date: burndown.due_date.strftime("%Y-%m-%d"),
-    burndown_events_path: expose_url(burndown_endpoint) } }
+    burndown_events_path: expose_url(burndown_endpoint), qa_selector: 'burndown_chart' } }
 
 - elsif show_burndown_placeholder?(milestone, warning)
   .burndown-hint.content-block.container-fluid

qa/qa.rb

@@ -259,6 +259,7 @@ module QA
       module Milestone
         autoload :New, 'qa/page/project/milestone/new'
         autoload :Index, 'qa/page/project/milestone/index'
+        autoload :Show, 'qa/page/project/milestone/show'
       end
 
       module Operations
@@ -449,6 +450,7 @@ module QA
       autoload :Logging, 'qa/support/page/logging'
     end
     autoload :Api, 'qa/support/api'
+    autoload :Dates, 'qa/support/dates'
     autoload :Waiter, 'qa/support/waiter'
     autoload :Retrier, 'qa/support/retrier'
   end

qa/qa/ee.rb

@@ -107,7 +107,7 @@ module QA
         end
 
         module Milestone
-          autoload :Index, 'qa/ee/page/project/milestone/index'
+          autoload :Show, 'qa/ee/page/project/milestone/show'
         end
 
         module Settings

qa/qa/ee/page/project/milestone/index.rb → qa/qa/ee/page/project/milestone/show.rb

@@ -5,15 +5,28 @@ module QA
     module Page
       module Project
         module Milestone
-          module Index
+          module Show
             def self.prepended(page)
               page.module_eval do
+                view 'ee/app/views/shared/milestones/_burndown.html.haml' do
+                  element :burndown_chart
+                  element :weight_button
+                end
+
                 view 'ee/app/views/shared/milestones/_weight.html.haml' do
                   element :total_issue_weight_value
                 end
               end
             end
 
+            def click_weight_button
+              click_element(:weight_button)
+            end
+
+            def burndown_chart
+              find_element(:burndown_chart)
+            end
+
             def total_issue_weight_value
               find_element(:total_issue_weight_value)
             end

qa/qa/ee/resource/project_milestone.rb

@@ -4,7 +4,10 @@ module QA
   module EE
     module Resource
       class ProjectMilestone < QA::Resource::Base
+        attr_writer :start_date, :due_date
+
         attribute :id
+        attribute :iid
         attribute :title
 
         attribute :project do
@@ -30,7 +33,10 @@ module QA
         def api_post_body
           {
             title: title
-          }
+          }.tap do |hash|
+            hash[:start_date] = @start_date if @start_date
+            hash[:due_date] = @due_date if @due_date
+          end
         end
       end
     end

qa/qa/page/project/milestone/index.rb

@@ -17,5 +17,3 @@ module QA
     end
   end
 end
-
-QA::Page::Project::Milestone::Index.prepend_if_ee('QA::EE::Page::Project::Milestone::Index')

qa/qa/page/project/milestone/show.rb

+# frozen_string_literal: true
+
+module QA
+  module Page
+    module Project
+      module Milestone
+        class Show < Page::Base
+        end
+      end
+    end
+  end
+end
+
+QA::Page::Project::Milestone::Show.prepend_if_ee('QA::EE::Page::Project::Milestone::Show')

qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb

+# frozen_string_literal: true
+
+module QA
+  context 'Plan' do
+    describe 'Burndown chart' do
+      include ::QA::Support::Dates
+
+      let(:project) do
+        Resource::Project.fabricate_via_api! do |project|
+          project.name = 'project-to-test-burndown-chart'
+        end
+      end
+
+      let(:milestone) do
+        QA::EE::Resource::ProjectMilestone.fabricate_via_api! do |m|
+          m.project = project
+          m.title = 'v1'
+          m.start_date = current_date_yyyy_mm_dd
+          m.due_date = next_month_yyyy_mm_dd
+        end
+      end
+
+      before do
+        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Page::Main::Login.perform(&:sign_in_using_credentials)
+
+        weight_of_two = 2
+
+        create_issue('Issue 1', project, milestone, weight_of_two)
+        create_issue('Issue 2', project, milestone, weight_of_two)
+      end
+
+      it 'shows burndown chart on milestone page' do
+        milestone.visit!
+
+        Page::Project::Milestone::Show.perform do |show|
+          expect(show.burndown_chart).to be_visible
+          expect(show.burndown_chart).to have_content("Open issues")
+
+          show.click_weight_button
+
+          expect(show.burndown_chart).to have_content('Open issue weight')
+        end
+      end
+
+      def create_issue(title, project, milestone, weight)
+        Resource::Issue.fabricate_via_api! do |issue|
+          issue.project = project
+          issue.title = title
+          issue.milestone = milestone
+          issue.weight = weight
+        end
+      end
+    end
+  end
+end

qa/qa/specs/features/ee/browser_ui/2_plan/epic/roadmap_spec.rb

@@ -4,17 +4,15 @@ module QA
   # https://gitlab.com/gitlab-org/gitlab/issues/13360
   context 'Plan', :skip do
     describe 'Epics roadmap' do
+      include Support::Dates
+
       let(:epic) do
         EE::Resource::Epic.fabricate_via_api! do |epic|
-          current_date = DateTime.now
-          current_date_yyyy_mm_dd = current_date.strftime("%Y/%m/%d")
-          next_month_date_yyyy_mm_dd = current_date.next_month.strftime("%Y/%m/%d")
-
           epic.title = 'Epic created via API to test roadmap'
           epic.start_date_is_fixed = true
           epic.start_date_fixed = current_date_yyyy_mm_dd
           epic.due_date_is_fixed = true
-          epic.due_date_fixed = next_month_date_yyyy_mm_dd
+          epic.due_date_fixed = next_month_yyyy_mm_dd
         end
       end
 

qa/qa/specs/features/ee/browser_ui/2_plan/issues_weight/issue_weight_visualization_spec.rb

@@ -41,8 +41,8 @@ module QA
           show.click_milestone_link
         end
 
-        Page::Project::Milestone::Index.perform do |index|
-          expect(index.total_issue_weight_value).to have_content(weight)
+        Page::Project::Milestone::Show.perform do |show|
+          expect(show.total_issue_weight_value).to have_content(weight)
         end
 
         Page::Project::Menu.perform(&:click_issues)

qa/qa/support/dates.rb

+# frozen_string_literal: true
+
+module QA
+  module Support
+    module Dates
+      def current_date_yyyy_mm_dd
+        current_date.strftime("%Y/%m/%d")
+      end
+
+      def next_month_yyyy_mm_dd
+        current_date.next_month.strftime("%Y/%m/%d")
+      end
+
+      private
+
+      def current_date
+        DateTime.now
+      end
+    end
+  end
+end