Updates schema, docs, other

* Fixes linting errors
* Updates DAST scanner service with CI namespace
* Adds success

app/graphql/mutations/ci/base.rb

@@ -6,6 +6,7 @@ module Mutations
       argument :id, GraphQL::ID_TYPE,
                 required: true,
                 description: 'The id of the pipeline to mutate'
+
       private
 
       def find_object(id:)

app/graphql/mutations/ci/pipeline_cancel.rb

@@ -11,6 +11,7 @@ module Mutations
         result = ::Ci::CancelUserPipelinesService.new.execute(current_user)
 
         {
+          success: result.success?,
           errors: [result&.message]
         }
       end

app/services/ci/cancel_user_pipelines_service.rb

@@ -7,6 +7,8 @@ module Ci
     # https://gitlab.com/gitlab-org/gitlab/issues/32332
     def execute(user)
       user.pipelines.cancelable.find_each(&:cancel_running)
+
+      ServiceResponse.success(message: 'Pipeline canceled')
     rescue ActiveRecord::StaleObjectError
       ServiceResponse.error(message: 'Error canceling pipeline')
     end

app/services/ci/destroy_pipeline_service.rb

@@ -12,7 +12,6 @@ module Ci
       ServiceResponse.success(message: 'Pipeline not found')
     rescue ActiveRecord::RecordNotFound
       ServiceResponse.error(message: 'Pipeline not found')
-
     end
   end
 end

doc/api/graphql/reference/gitlab_schema.graphql

@@ -10646,11 +10646,6 @@ type PipelineDestroyPayload {
   Errors encountered during execution of the mutation.
   """
   errors: [String!]!
-
-  """
-  The pipeline after mutation
-  """
-  pipeline: Pipeline
 }
 
 """

doc/api/graphql/reference/gitlab_schema.json

@@ -31948,20 +31948,6 @@
               },
               "isDeprecated": false,
               "deprecationReason": null
-            },
-            {
-              "name": "pipeline",
-              "description": "The pipeline after mutation",
-              "args": [
-
-              ],
-              "type": {
-                "kind": "OBJECT",
-                "name": "Pipeline",
-                "ofType": null
-              },
-              "isDeprecated": false,
-              "deprecationReason": null
             }
           ],
           "inputFields": null,

doc/api/graphql/reference/index.md

@@ -1639,7 +1639,6 @@ Autogenerated return type of PipelineDestroy
 | ---   |  ---- | ----------  |
 | `clientMutationId` | String | A unique identifier for the client performing the mutation. |
 | `errors` | String! => Array | Errors encountered during execution of the mutation. |
-| `pipeline` | Pipeline | The pipeline after mutation |
 
 ## PipelinePermissions
 

ee/app/graphql/mutations/dast_on_demand_scans/create.rb

@@ -29,7 +29,7 @@ module Mutations
         dast_site_profile = find_dast_site_profile(project: project, dast_site_profile_id: dast_site_profile_id)
         dast_site = dast_site_profile.dast_site
 
-        service = Ci::RunDastScanService.new(project, current_user)
+        service = ::Ci::RunDastScanService.new(project, current_user)
         result = service.execute(branch: project.default_branch, target_url: dast_site.url)
 
         if result.success?

ee/app/graphql/mutations/pipelines/run_dast_scan.rb

@@ -32,7 +32,7 @@ module Mutations
       def resolve(project_path:, target_url:, branch:, scan_type:)
         project = authorized_find!(full_path: project_path)
 
-        service = Ci::RunDastScanService.new(project, current_user)
+        service = ::Ci::RunDastScanService.new(project, current_user)
         result = service.execute(branch: branch, target_url: target_url)
 
         if result.success?

spec/requests/api/graphql/mutations/ci/pipeline_cancel_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe 'PipelineCancel' do
 
   let(:mutation_response) { graphql_mutation_response(:pipeline_cancel) }
 
-  before(:all) do
+  before_all do
     project.add_maintainer(user)
   end
 

spec/requests/api/graphql/mutations/ci/pipeline_retry_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe 'PipelineRetry' do
 
   let(:mutation_response) { graphql_mutation_response(:pipeline_retry) }
 
-  before(:all) do
+  before_all do
     project.add_maintainer(user)
   end