Commit 2653948a authored by Olena Horal-Koretska's avatar Olena Horal-Koretska

Merge branch '332398-remove-load-performance-widget-usage-data-feature-flag' into 'master'

Remove load performance widget usage data flag

See merge request gitlab-org/gitlab!68847
parents f45bcad2 487442b0
---
name: usage_data_i_testing_load_performance_widget_total
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/52688
rollout_issue_url:
milestone: '13.9'
type: development
group: group::testing
default_enabled: true
......@@ -2,14 +2,12 @@
import { componentNames } from 'ee/reports/components/issue_body';
import api from '~/api';
import ReportSection from '~/reports/components/report_section.vue';
import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
export default {
name: 'GroupedLoadPerformanceReportsApp',
components: {
ReportSection,
},
mixins: [glFeatureFlagsMixin()],
props: {
status: {
type: String,
......@@ -47,9 +45,7 @@ export default {
componentNames,
methods: {
handleLoadPerformanceToggleEvent() {
if (this.glFeatures.usageDataITestingLoadPerformanceWidgetTotal) {
api.trackRedisHllUserEvent(this.$options.expandEvent);
}
api.trackRedisHllUserEvent(this.$options.expandEvent);
},
},
expandEvent: 'i_testing_load_performance_widget_total',
......
......@@ -11,7 +11,6 @@ module EE
before_action only: [:show] do
push_frontend_feature_flag(:anonymous_visual_review_feedback)
push_frontend_feature_flag(:missing_mr_security_scan_types, @project)
push_frontend_feature_flag(:usage_data_i_testing_load_performance_widget_total, @project, default_enabled: true)
end
before_action :authorize_read_pipeline!, only: [:container_scanning_reports, :dependency_scanning_reports,
......
......@@ -9,7 +9,7 @@ const localVue = createLocalVue();
describe('Grouped load performance reports app', () => {
let wrapper;
const mountComponent = ({ usageDataITestingLoadPerformanceWidgetTotal = false } = {}) => {
const mountComponent = () => {
wrapper = mount(GroupedLoadPerformanceReportsApp, {
localVue,
propsData: {
......@@ -22,42 +22,23 @@ describe('Grouped load performance reports app', () => {
neutralIssues: [],
hasIssues: true,
},
provide: {
glFeatures: {
usageDataITestingLoadPerformanceWidgetTotal,
},
},
});
};
beforeEach(() => {
mountComponent();
});
afterEach(() => {
wrapper.destroy();
wrapper = null;
});
describe('service ping events', () => {
describe('when feature flag is enabled', () => {
beforeEach(() => {
mountComponent({ usageDataITestingLoadPerformanceWidgetTotal: true });
});
it('tracks an event when the widget is expanded', () => {
wrapper.find('[data-testid="report-section-expand-button"]').trigger('click');
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(wrapper.vm.$options.expandEvent);
});
});
describe('when feature flag is disabled', () => {
beforeEach(() => {
mountComponent({ usageDataITestingLoadPerformanceWidgetTotal: false });
});
it('tracks an event when the widget is expanded', () => {
wrapper.find('[data-testid="report-section-expand-button"]').trigger('click');
it('tracks an event when the widget is expanded', () => {
wrapper.find('[data-testid="report-section-expand-button"]').trigger('click');
expect(Api.trackRedisHllUserEvent).not.toHaveBeenCalled();
});
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(wrapper.vm.$options.expandEvent);
});
});
});
......@@ -175,7 +175,6 @@
category: testing
redis_slot: testing
aggregation: weekly
feature_flag: usage_data_i_testing_load_performance_widget_total
- name: i_testing_metrics_report_artifact_uploaders
category: testing
redis_slot: testing
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment