Commit 28f79ee4 authored by Mehmet Emin INAC's avatar Mehmet Emin INAC

Remove unnecessary override of `build_comparer` method

This method is already implemented by the superclass which is identical
so we don't need to override this method in subclass.
parent aad8b990
...@@ -13,9 +13,5 @@ module Ci ...@@ -13,9 +13,5 @@ module Ci
def get_report(pipeline) def get_report(pipeline)
Security::PipelineVulnerabilitiesFinder.new(pipeline: pipeline, params: { report_type: [params[:report_type]], scope: 'all' }).execute Security::PipelineVulnerabilitiesFinder.new(pipeline: pipeline, params: { report_type: [params[:report_type]], scope: 'all' }).execute
end end
def build_comparer(base_pipeline, head_pipeline)
comparer_class.new(get_report(base_pipeline), get_report(head_pipeline))
end
end end
end end
...@@ -82,16 +82,6 @@ RSpec.describe Ci::CompareSecurityReportsService do ...@@ -82,16 +82,6 @@ RSpec.describe Ci::CompareSecurityReportsService do
expect(result[:status_reason]).to include('JSON parsing failed') expect(result[:status_reason]).to include('JSON parsing failed')
end end
end end
describe "#build_comparer" do
context "when the head_pipeline is nil" do
subject { service.build_comparer(base_pipeline, nil) }
let(:base_pipeline) { create(:ee_ci_pipeline) }
specify { expect { subject }.not_to raise_error }
end
end
end end
describe '#execute CS' do describe '#execute CS' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment