Add `needs` to `test` jobs to bypass `fixtures`

These jobs now have `needs` with `retrieve-tests-metadata`
as it is the quickest test in `prepare`.

.gitlab/ci/dev-fixtures.gitlab-ci.yml

@@ -7,7 +7,6 @@
     - .use-pg9
   stage: test
   needs: ["setup-test-env"]
-  dependencies: ["setup-test-env"]
   variables:
     FIXTURE_PATH: "db/fixtures/development"
     SEED_CYCLE_ANALYTICS: "true"

.gitlab/ci/docs.gitlab-ci.yml

@@ -46,7 +46,9 @@ docs lint:
     - .docs:rules:docs-lint
   image: "registry.gitlab.com/gitlab-org/gitlab-docs:docs-lint"
   stage: test
-  dependencies: []
+  needs:
+    - job: "retrieve-tests-metadata"
+      artifacts: false
   script:
     - scripts/lint-doc.sh
     # Lint Markdown

.gitlab/ci/frontend.gitlab-ci.yml

@@ -128,7 +128,11 @@ compile-assets pull-cache as-if-foss:
     - .default-before_script
     - .use-pg9
   stage: fixtures
-  needs: ["setup-test-env", "compile-assets pull-cache"]
+  needs:
+    - job: "setup-test-env"
+      artifacts: true
+    - job: "compile-assets pull-cache"
+      artifacts: true
   script:
     - date
     - scripts/gitaly-test-spawn

.gitlab/ci/qa.gitlab-ci.yml

@@ -3,7 +3,9 @@
     - .default-tags
     - .default-retry
   stage: test
-  dependencies: []
+  needs:
+    - job: "retrieve-tests-metadata"
+      artifacts: false
   cache:
     key: "qa-framework-jobs:v1"
     paths:

.gitlab/ci/reports.gitlab-ci.yml

@@ -12,6 +12,9 @@ code_quality:
     - .default-retry
     - .reports:rules:code_quality
   stage: test
+  needs:
+    - job: "retrieve-tests-metadata"
+      artifacts: false
   image: docker:stable
   allow_failure: true
   services:
@@ -39,7 +42,6 @@ code_quality:
     paths:
       - gl-code-quality-report.json  # GitLab-specific
     expire_in: 1 week  # GitLab-specific
-  dependencies: []
 
 # We need to duplicate this job's definition because it seems it's impossible to
 # override an included `only.refs`.
@@ -52,7 +54,9 @@ sast:
     - .reports:rules:sast
   stage: test
   allow_failure: true
-  dependencies: []  # GitLab-specific
+  needs:
+    - job: "retrieve-tests-metadata"
+      artifacts: false
   artifacts:
     paths:
       - gl-sast-report.json  # GitLab-specific
@@ -90,6 +94,9 @@ dependency_scanning:
     - .default-retry
     - .reports:rules:dependency_scanning
   stage: test
+  needs:
+    - job: "retrieve-tests-metadata"
+      artifacts: false
   image: docker:stable
   variables:
     DOCKER_DRIVER: overlay2
@@ -148,7 +155,6 @@ dependency_scanning:
     reports:
       dependency_scanning: gl-dependency-scanning-report.json
     expire_in: 1 week  # GitLab-specific
-  dependencies: []
 
 # We need to duplicate this job's definition because it seems it's impossible to
 # override an included `only.refs`.

.gitlab/ci/review.gitlab-ci.yml

@@ -248,7 +248,9 @@ danger-review:
     - .review:rules:danger
   image: registry.gitlab.com/gitlab-org/gitlab-build-images:danger
   stage: test
-  dependencies: []
+  needs:
+    - job: "retrieve-tests-metadata"
+      artifacts: false
   script:
     - git version
     - node --version