Remove legacy query to find job artifacts that sync failed

This commit removes the legacy queries to find job artifacts
that sync failed since we made Foreign Data Wrapper (FDW) a
hard requirement for Geo on GitLab 12.0.

ee/app/finders/geo/job_artifact_registry_finder.rb

@@ -11,7 +11,7 @@ module Geo
     end
 
     def count_failed
-      job_artifacts_failed.count
+      registries_for_job_artifacts.merge(Geo::JobArtifactRegistry.failed).count
     end
 
     def count_synced_missing_on_primary
@@ -112,14 +112,6 @@ module Geo
       end
     end
 
-    def job_artifacts_failed
-      if use_legacy_queries_for_selective_sync?
-        legacy_finder.job_artifacts_failed
-      else
-        registries_for_job_artifacts.merge(Geo::JobArtifactRegistry.failed)
-      end
-    end
-
     def job_artifacts_synced_missing_on_primary
       if use_legacy_queries_for_selective_sync?
         legacy_finder.job_artifacts_synced_missing_on_primary

ee/app/finders/geo/legacy_job_artifact_registry_finder.rb

@@ -6,14 +6,6 @@ module Geo
       current_node.job_artifacts.syncable
     end
 
-    def job_artifacts_failed
-      legacy_inner_join_registry_ids(
-        syncable,
-        Geo::JobArtifactRegistry.failed.pluck_artifact_key,
-        Ci::JobArtifact
-      )
-    end
-
     def job_artifacts_synced_missing_on_primary
       legacy_inner_join_registry_ids(
         syncable,

ee/spec/finders/geo/job_artifact_registry_finder_spec.rb

@@ -676,95 +676,6 @@ describe Geo::JobArtifactRegistryFinder, :geo do
       end
     end
 
-    describe '#count_failed' do
-      let!(:job_artifact_1) { create(:ci_job_artifact, project: synced_project) }
-      let!(:job_artifact_2) { create(:ci_job_artifact, project: unsynced_project) }
-      let!(:job_artifact_3) { create(:ci_job_artifact, project: synced_project) }
-      let!(:job_artifact_4) { create(:ci_job_artifact, project: unsynced_project) }
-      let!(:job_artifact_5) { create(:ci_job_artifact, project: project_broken_storage) }
-      let!(:job_artifact_6) { create(:ci_job_artifact, project: project_broken_storage) }
-
-      context 'without selective sync' do
-        before do
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_1.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_2.id)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_3.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_5.id, success: false)
-        end
-
-        it 'counts job artifacts that sync has failed' do
-          expect(subject.count_failed).to eq 3
-        end
-
-        it 'ignores remote job artifacts' do
-          job_artifact_1.update_column(:file_store, ObjectStorage::Store::REMOTE)
-
-          expect(subject.count_failed).to eq 2
-        end
-
-        it 'ignores expired job artifacts' do
-          job_artifact_1.update_column(:expire_at, Date.yesterday)
-
-          expect(subject.count_failed).to eq 2
-        end
-      end
-
-      context 'with selective sync by namespace' do
-        before do
-          secondary.update!(selective_sync_type: 'namespaces', namespaces: [synced_group])
-
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_1.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_2.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_3.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_5.id, success: false)
-        end
-
-        it 'counts job artifacts that sync has failed' do
-          expect(subject.count_failed).to eq 2
-        end
-
-        it 'ignores remote job artifacts' do
-          job_artifact_1.update_column(:file_store, ObjectStorage::Store::REMOTE)
-
-          expect(subject.count_failed).to eq 1
-        end
-
-        it 'ignores expired job artifacts' do
-          job_artifact_1.update_column(:expire_at, Date.yesterday)
-
-          expect(subject.count_failed).to eq 1
-        end
-      end
-
-      context 'with selective sync by shard' do
-        before do
-          secondary.update!(selective_sync_type: 'shards', selective_sync_shards: ['broken'])
-
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_1.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_2.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_3.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_5.id, success: false)
-          create(:geo_job_artifact_registry, artifact_id: job_artifact_6.id, success: false)
-        end
-
-        it 'counts job artifacts that sync has failed' do
-          expect(subject.count_failed).to eq 2
-        end
-
-        it 'ignores remote job artifacts' do
-          job_artifact_5.update_column(:file_store, ObjectStorage::Store::REMOTE)
-
-          expect(subject.count_failed).to eq 1
-        end
-
-        it 'ignores expired job artifacts' do
-          job_artifact_5.update_column(:expire_at, Date.yesterday)
-
-          expect(subject.count_failed).to eq 1
-        end
-      end
-    end
-
     describe '#count_synced_missing_on_primary' do
       let!(:job_artifact_1) { create(:ci_job_artifact, project: synced_project) }
       let!(:job_artifact_2) { create(:ci_job_artifact, project: unsynced_project) }