Merge branch '343280-add-feature-flag-for-reading-from-model' into 'master'

Put feature flag for reading from finding_evidence

See merge request gitlab-org/gitlab!79883

config/feature_flags/development/read_from_vulnerability_finding_evidence.yml

+---
+name: read_from_vulnerability_finding_evidence
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79883
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/352632
+milestone: '14.8'
+type: development
+group: group::threat insights
+default_enabled: false

ee/app/models/vulnerabilities/finding.rb

@@ -291,7 +291,7 @@ module Vulnerabilities
     end
 
     def evidence
-      evidence_data = finding_evidence.present? ? finding_evidence.data : metadata.dig('evidence')
+      evidence_data = finding_evidence.present? && Feature.enabled?(:read_from_vulnerability_finding_evidence) ? finding_evidence.data : metadata.dig('evidence')
 
       {
         summary: evidence_data&.dig('summary'),

ee/spec/models/vulnerabilities/finding_spec.rb

@@ -899,9 +899,31 @@ RSpec.describe Vulnerabilities::Finding do
       context 'with finding_evidence' do
         let(:finding_evidence) { build(:vulnerabilties_finding_evidence) }
         let(:finding) { finding_evidence.finding }
-        let(:evidence) { finding_evidence.data }
 
-        include_examples 'evidence schema'
+        before do
+          finding_evidence.data[:summary] = "finding_evidence Summary"
+          finding_evidence.save!
+        end
+
+        context 'when the vulnerability_finding_replace_metadata feature flag is off' do
+          let(:evidence) { finding.metadata['evidence'] }
+
+          before do
+            stub_feature_flags(read_from_vulnerability_finding_evidence: false)
+          end
+
+          include_examples 'evidence schema'
+        end
+
+        context 'when the vulnerability_finding_replace_metadata feature flag is on' do
+          let(:evidence) { finding_evidence.data }
+
+          before do
+            stub_feature_flags(read_from_vulnerability_finding_evidence: true)
+          end
+
+          include_examples 'evidence schema'
+        end
       end
     end