Merge branch 'simplify-a-bunch-of-tests' into 'master'

Simplify a bunch of tests

See merge request gitlab-org/gitlab!23098

qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb

@@ -28,7 +28,6 @@ module QA
         Flow::Project.add_member(project: project, username: user.username)
 
         Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = 'issue title'
           issue.project = project
         end.visit!
 

qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb

@@ -8,9 +8,7 @@ module QA
       before do
         Flow::Login.sign_in
 
-        Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = 'issue title'
-        end.visit!
+        Resource::Issue.fabricate_via_api!.visit!
 
         Page::Project::Issue::Show.perform do |show|
           show.select_all_activities_filter

qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb

@@ -6,9 +6,7 @@ module QA
       before do
         Flow::Login.sign_in
 
-        Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = 'issue title'
-        end.visit!
+        Resource::Issue.fabricate_via_api!.visit!
       end
 
       it 'user comments on an issue and edits the comment' do

qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb

@@ -3,16 +3,12 @@
 module QA
   context 'Plan', :smoke do
     describe 'Issue creation' do
-      let(:issue_title) { 'issue title' }
-
       before do
         Flow::Login.sign_in
       end
 
       it 'user creates an issue' do
-        issue = Resource::Issue.fabricate_via_browser_ui! do |issue|
-          issue.title = issue_title
-        end
+        issue = Resource::Issue.fabricate_via_browser_ui!
 
         Page::Project::Menu.perform(&:click_issues)
 
@@ -28,9 +24,7 @@ module QA
         end
 
         before do
-          Resource::Issue.fabricate_via_api! do |issue|
-            issue.title = issue_title
-          end.visit!
+          Resource::Issue.fabricate_via_api!.visit!
         end
 
         it 'user comments on an issue with an attachment' do

qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb

@@ -3,14 +3,10 @@
 module QA
   context 'Plan' do
     describe 'filter issue comments activities' do
-      let(:issue_title) { 'issue title' }
-
       before do
         Flow::Login.sign_in
 
-        Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = issue_title
-        end.visit!
+        Resource::Issue.fabricate_via_api!.visit!
       end
 
       it 'user filters comments and activities in an issue' do

qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb

@@ -16,7 +16,6 @@ module QA
         project.add_member(@user)
 
         Resource::Issue.fabricate_via_api! do |issue|
-          issue.title = 'issue to test mention'
           issue.project = project
         end.visit!
       end