Fix for project_security_dashboard_spec

As per issue
https://gitlab.com/gitlab-org/gitlab/-/issues/233362
it appears that it is possible that the user
is not logged in when visiting the project,
and therefore the security dashboard is
unavailable

This MR adds a sign_in_unless_signed_in
call before visiting the project. It
also removes a retry that was added
previously for the same issue as it
turns out that the user not being
logged in is the root cause

qa/qa/specs/features/ee/browser_ui/secure/project_security_dashboard_spec.rb

@@ -60,10 +60,9 @@ module QA
       end
 
       it 'shows vulnerability details' do
+        Flow::Login.sign_in_unless_signed_in
         @project.visit!
-        Support::Retrier.retry_on_exception do
-          Page::Project::Menu.perform(&:click_on_security_dashboard)
-        end
+        Page::Project::Menu.perform(&:click_on_security_dashboard)
 
         EE::Page::Project::Secure::SecurityDashboard.perform do |security_dashboard|
           expect(security_dashboard).to have_vulnerability(description: vulnerability_name)