Commit 2eba76ca authored by Mikołaj Wawrzyniak's avatar Mikołaj Wawrzyniak

Merge branch '336557-fix-ci-cross-join-instance-security-dashboard-all-pipelines' into 'master'

Remove unused method InstanceSecurityDashboard#all_pipelines

See merge request gitlab-org/gitlab!66503
parents 3f2353d5 67b34ed1
...@@ -10,10 +10,6 @@ class InstanceSecurityDashboard ...@@ -10,10 +10,6 @@ class InstanceSecurityDashboard
@user = user @user = user
end end
def all_pipelines
::Ci::Pipeline.where(project_id: users_projects_with_security_reports)
end
def project_ids_with_security_reports def project_ids_with_security_reports
users_projects_with_security_reports.pluck(:project_id) users_projects_with_security_reports.pluck(:project_id)
end end
......
...@@ -21,12 +21,6 @@ RSpec.describe InstanceSecurityDashboard do ...@@ -21,12 +21,6 @@ RSpec.describe InstanceSecurityDashboard do
subject { described_class.new(user, project_ids: project_ids) } subject { described_class.new(user, project_ids: project_ids) }
describe '#all_pipelines' do
it 'returns pipelines for the projects with security reports' do
expect(subject.all_pipelines).to contain_exactly(pipeline1)
end
end
describe '#project_ids_with_security_reports' do describe '#project_ids_with_security_reports' do
context 'when given project IDs' do context 'when given project IDs' do
it "returns the project IDs that are also on the user's security dashboard" do it "returns the project IDs that are also on the user's security dashboard" do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment