Remove legacy queries to find registries for expired uploads

This commit removes the legacy to find registries for expired
uploads by project since we made Foreign Data Wrapper (FDW) a
hard requirement for Geo on GitLab 12.0.

ee/app/finders/geo/expire_uploads_finder.rb

@@ -9,31 +9,9 @@ module Geo
     end
 
     def find_file_registries_uploads(project)
-      if Gitlab::Geo::Fdw.enabled?
-        Gitlab::Geo::Fdw::UploadRegistryQueryBuilder.new
-          .for_model(project)
-          .with_type(UPLOAD_TYPE)
-      else
-        legacy_find_file_registries_uploads(project)
-      end
+      Gitlab::Geo::Fdw::UploadRegistryQueryBuilder.new
+        .for_model(project)
+        .with_type(UPLOAD_TYPE)
     end
-
-    private
-
-    # rubocop:disable CodeReuse/ActiveRecord
-    def legacy_find_file_registries_uploads(project)
-      upload_ids = Upload.for_model(project).pluck_primary_key
-      return Geo::FileRegistry.none if upload_ids.empty?
-
-      values_sql = upload_ids.map { |id| "(#{id})" }.join(',')
-
-      Geo::FileRegistry.joins(<<~SQL)
-        JOIN (VALUES #{values_sql})
-          AS uploads (id)
-          ON uploads.id = file_registry.file_id
-         AND file_registry.file_type='#{UPLOAD_TYPE}'
-      SQL
-    end
-    # rubocop:enable CodeReuse/ActiveRecord
   end
 end

ee/spec/finders/geo/expire_uploads_finder_spec.rb

 require 'spec_helper'
 
-describe Geo::ExpireUploadsFinder, :geo do
+describe Geo::ExpireUploadsFinder, :geo, :geo_fdw do
   include EE::GeoHelpers
 
   let(:project) { create(:project) }
 
-  context 'FDW', :geo_fdw do
-    describe '#find_project_uploads' do
-      context 'filtering per project uploads' do
-        it 'returns only objects associated with the project' do
-          other_upload = create(:upload, :issuable_upload)
-          upload = create(:upload, :issuable_upload, model: project)
-          create(:geo_file_registry, file_id: upload.id)
-          create(:geo_file_registry, file_id: other_upload.id)
+  describe '#find_project_uploads' do
+    context 'filtering per project uploads' do
+      it 'returns only objects associated with the project' do
+        other_upload = create(:upload, :issuable_upload)
+        upload = create(:upload, :issuable_upload, model: project)
+        create(:geo_file_registry, file_id: upload.id)
+        create(:geo_file_registry, file_id: other_upload.id)
 
-          uploads = subject.find_project_uploads(project)
+        uploads = subject.find_project_uploads(project)
 
-          expect(uploads.count).to eq(1)
-          expect(uploads.first.id).to eq(upload.id)
-        end
-      end
-
-      context 'filtering replicated uploads only' do
-        it 'returns only replicated or to be replicated objects' do
-          create(:upload, :issuable_upload, model: project)
-          upload = create(:upload, :issuable_upload, model: project)
-          create(:geo_file_registry, file_id: upload.id, success: false)
-
-          uploads = subject.find_project_uploads(project)
-
-          expect(uploads.count).to eq(1)
-          expect(uploads.first.id).to eq(upload.id)
-        end
+        expect(uploads.count).to eq(1)
+        expect(uploads.first.id).to eq(upload.id)
       end
     end
 
-    describe '#find_file_registries_uploads' do
-      context 'filtering per project uploads' do
-        it 'returns only objects associated with the project' do
-          other_upload = create(:upload, :issuable_upload)
-          upload = create(:upload, :issuable_upload, model: project)
-          create(:geo_file_registry, file_id: other_upload.id)
-          file_registry = create(:geo_file_registry, file_id: upload.id)
+    context 'filtering replicated uploads only' do
+      it 'returns only replicated or to be replicated objects' do
+        create(:upload, :issuable_upload, model: project)
+        upload = create(:upload, :issuable_upload, model: project)
+        create(:geo_file_registry, file_id: upload.id, success: false)
 
-          files = subject.find_file_registries_uploads(project)
+        uploads = subject.find_project_uploads(project)
 
-          expect(files.count).to eq(1)
-          expect(files.first.id).to eq(file_registry.id)
-        end
+        expect(uploads.count).to eq(1)
+        expect(uploads.first.id).to eq(upload.id)
       end
     end
   end
 
-  context 'Legacy' do
-    before do
-      stub_fdw_disabled
-    end
-
-    describe '#find_file_registries_uploads' do
-      context 'filtering per project uploads' do
-        it 'returns only objects associated with the project' do
-          other_upload = create(:upload, :issuable_upload)
-          upload = create(:upload, :issuable_upload, model: project)
-          create(:geo_file_registry, file_id: other_upload.id)
-          file_registry = create(:geo_file_registry, file_id: upload.id)
+  describe '#find_file_registries_uploads' do
+    context 'filtering per project uploads' do
+      it 'returns only objects associated with the project' do
+        other_upload = create(:upload, :issuable_upload)
+        upload = create(:upload, :issuable_upload, model: project)
+        create(:geo_file_registry, file_id: other_upload.id)
+        file_registry = create(:geo_file_registry, file_id: upload.id)
 
-          files = subject.find_file_registries_uploads(project)
+        files = subject.find_file_registries_uploads(project)
 
-          expect(files.count).to eq(1)
-          expect(files.first.id).to eq(file_registry.id)
-        end
+        expect(files.count).to eq(1)
+        expect(files.first.id).to eq(file_registry.id)
       end
     end
   end