Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2f85a88b
Commit
2f85a88b
authored
Dec 07, 2020
by
Tom Quirk
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add specs for design view tracking
parent
9694b8b3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
75 additions
and
3 deletions
+75
-3
app/assets/javascripts/design_management/utils/tracking.js
app/assets/javascripts/design_management/utils/tracking.js
+2
-2
spec/frontend/design_management/pages/design/index_spec.js
spec/frontend/design_management/pages/design/index_spec.js
+73
-1
No files found.
app/assets/javascripts/design_management/utils/tracking.js
View file @
2f85a88b
import
Tracking
from
'
~/tracking
'
;
import
a
pi
from
'
~/api
'
;
import
A
pi
from
'
~/api
'
;
// Snowplow tracking constants
const
DESIGN_TRACKING_CONTEXT_SCHEMAS
=
{
...
...
@@ -55,5 +55,5 @@ export function trackDesignUpdate() {
* Track "design detail" view via usage ping
*/
export
function
usagePingDesignDetailView
()
{
a
pi
.
trackRedisHllUserEvent
(
DESIGN_USAGE_PING_EVENT_TYPES
.
DESIGN_ACTION
);
A
pi
.
trackRedisHllUserEvent
(
DESIGN_USAGE_PING_EVENT_TYPES
.
DESIGN_ACTION
);
}
spec/frontend/design_management/pages/design/index_spec.js
View file @
2f85a88b
...
...
@@ -2,7 +2,9 @@ import { shallowMount, createLocalVue } from '@vue/test-utils';
import
VueRouter
from
'
vue-router
'
;
import
{
GlAlert
}
from
'
@gitlab/ui
'
;
import
{
ApolloMutation
}
from
'
vue-apollo
'
;
import
{
mockTracking
,
unmockTracking
}
from
'
helpers/tracking_helper
'
;
import
createFlash
from
'
~/flash
'
;
import
Api
from
'
~/api
'
;
import
DesignIndex
from
'
~/design_management/pages/design/index.vue
'
;
import
DesignSidebar
from
'
~/design_management/components/design_sidebar.vue
'
;
import
DesignPresentation
from
'
~/design_management/components/design_presentation.vue
'
;
...
...
@@ -20,8 +22,14 @@ import design from '../../mock_data/design';
import
mockResponseWithDesigns
from
'
../../mock_data/designs
'
;
import
mockResponseNoDesigns
from
'
../../mock_data/no_designs
'
;
import
mockAllVersions
from
'
../../mock_data/all_versions
'
;
import
{
DESIGN_TRACKING_PAGE_NAME
,
DESIGN_SNOWPLOW_EVENT_TYPES
,
DESIGN_USAGE_PING_EVENT_TYPES
,
}
from
'
~/design_management/utils/tracking
'
;
jest
.
mock
(
'
~/flash
'
);
jest
.
mock
(
'
~/api.js
'
);
const
focusInput
=
jest
.
fn
();
const
mutate
=
jest
.
fn
().
mockResolvedValue
();
...
...
@@ -81,7 +89,10 @@ describe('Design management design index page', () => {
const
findSidebar
=
()
=>
wrapper
.
find
(
DesignSidebar
);
const
findDesignPresentation
=
()
=>
wrapper
.
find
(
DesignPresentation
);
function
createComponent
({
loading
=
false
}
=
{},
{
data
=
{},
intialRouteOptions
=
{}
}
=
{})
{
function
createComponent
(
{
loading
=
false
}
=
{},
{
data
=
{},
intialRouteOptions
=
{},
provide
=
{}
}
=
{},
)
{
const
$apollo
=
{
queries
:
{
design
:
{
...
...
@@ -106,6 +117,7 @@ describe('Design management design index page', () => {
provide
:
{
issueIid
:
'
1
'
,
projectPath
:
'
project-path
'
,
...
provide
,
},
data
()
{
return
{
...
...
@@ -343,4 +355,64 @@ describe('Design management design index page', () => {
});
});
});
describe
(
'
tracking
'
,
()
=>
{
let
trackingSpy
;
beforeEach
(()
=>
{
trackingSpy
=
mockTracking
(
'
_category_
'
,
undefined
,
jest
.
spyOn
);
});
afterEach
(()
=>
{
unmockTracking
();
});
describe
(
'
on mount
'
,
()
=>
{
it
(
'
tracks design view in snowplow
'
,
()
=>
{
createComponent
({
loading
:
true
});
expect
(
trackingSpy
).
toHaveBeenCalledTimes
(
1
);
expect
(
trackingSpy
).
toHaveBeenCalledWith
(
DESIGN_TRACKING_PAGE_NAME
,
DESIGN_SNOWPLOW_EVENT_TYPES
.
VIEW_DESIGN
,
{
context
:
{
data
:
{
'
design-collection-owner
'
:
'
issue
'
,
'
design-is-current-version
'
:
true
,
'
design-version-number
'
:
1
,
'
internal-object-referrer
'
:
'
issue-design-collection
'
,
},
schema
:
'
iglu:com.gitlab/design_management_context/jsonschema/1-0-0
'
,
},
label
:
DESIGN_SNOWPLOW_EVENT_TYPES
.
VIEW_DESIGN
,
},
);
});
describe
(
'
with usage_data_design_action enabled
'
,
()
=>
{
it
(
'
tracks design view usage ping
'
,
()
=>
{
createComponent
(
{
loading
:
true
},
{
provide
:
{
glFeatures
:
{
usageDataDesignAction
:
true
},
},
},
);
expect
(
Api
.
trackRedisHllUserEvent
).
toHaveBeenCalledTimes
(
1
);
expect
(
Api
.
trackRedisHllUserEvent
).
toHaveBeenCalledWith
(
DESIGN_USAGE_PING_EVENT_TYPES
.
DESIGN_ACTION
,
);
});
});
describe
(
'
with usage_data_design_action disabled
'
,
()
=>
{
it
(
"
doesn't track design view usage ping
"
,
()
=>
{
createComponent
({
loading
:
true
});
expect
(
Api
.
trackRedisHllUserEvent
).
toHaveBeenCalledTimes
(
0
);
});
});
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment