Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
306f70a6
Commit
306f70a6
authored
Jun 24, 2020
by
Shinya Maeda
Committed by
Marcel Amirault
Jun 24, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update Feature Flag removal criteria
This commit clarifies the removal criteria
parent
69b34501
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
3 deletions
+14
-3
doc/development/feature_flags/controls.md
doc/development/feature_flags/controls.md
+11
-2
doc/development/feature_flags/process.md
doc/development/feature_flags/process.md
+3
-1
No files found.
doc/development/feature_flags/controls.md
View file @
306f70a6
...
...
@@ -210,11 +210,20 @@ actors.
Feature
.
enabled?
(
:some_feature
,
group
)
```
NOTE:
NOTE:
**Note:**
**Percentage of time**
rollout is not a good idea if what you want is to make sure a feature
is always on or off to the users. In that case,
**Percentage of actors**
rollout is a better method.
Lastly, to verify that the feature is deemed stable in as many cases as possible,
you should fully roll out the feature by enabling the flag
**globally**
by running:
```
shell
/chatops run feature
set
some_feature
true
```
This changes the feature flag state to be
**enabled**
always, which overrides the
existing gates (e.g.
`--group=gitlab-org`
) in the above processes.
### Feature flag change logging
Any feature flag change that affects GitLab.com (production) will
...
...
doc/development/feature_flags/process.md
View file @
306f70a6
...
...
@@ -71,7 +71,9 @@ absolutely no way to use the feature until it is enabled.
In order to build a final release and present the feature for self-managed
users, the feature flag should be at least defaulted to
**on**
. If the feature
is deemed stable and there is confidence that removing the feature flag is safe,
consider removing the feature flag altogether.
consider removing the feature flag altogether. It's _strongly_ recommended that
the feature flag is
[
enabled **globally** on **production**
](
./controls.md#enabling-a-feature-for-gitlabcom
)
for
**at least one day**
before making this decision. Unexpected bugs are sometimes discovered during this period.
The process for enabling features that are disabled by default can take 5-6 days
from when the merge request is first reviewed to when the change is deployed to
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment