Minor resolver tidying

This makes a few changes that are nice-to-have now, and become more
important down the line:

- adds some missing types to resolvers (a cop violation)
- removes unnecessary field authorization (field authorization does not
  work like that)
- adds extras annotations for `lookahead` etc

.rubocop_manual_todo.yml

@@ -35,7 +35,6 @@ Graphql/IDType:
 Graphql/ResolverType:
   Exclude:
     - 'app/graphql/resolvers/base_resolver.rb'
-    - 'app/graphql/resolvers/ci/jobs_resolver.rb'
     - 'app/graphql/resolvers/ci/pipeline_stages_resolver.rb'
     - 'app/graphql/resolvers/users/group_count_resolver.rb'
     - 'ee/app/graphql/resolvers/vulnerabilities_base_resolver.rb'

app/graphql/resolvers/ci/jobs_resolver.rb

@@ -5,6 +5,8 @@ module Resolvers
     class JobsResolver < BaseResolver
       alias_method :pipeline, :object
 
+      type ::Types::Ci::JobType.connection_type, null: true
+
       argument :security_report_types, [Types::Security::ReportTypeEnum],
               required: false,
               description: 'Filter jobs by the type of security report they produce'

app/graphql/resolvers/design_management/versions_resolver.rb

@@ -9,6 +9,8 @@ module Resolvers
 
       VersionID = ::Types::GlobalIDType[::DesignManagement::Version]
 
+      extras [:parent]
+
       argument :earlier_or_equal_to_sha, GraphQL::STRING_TYPE,
                as: :sha,
                required: false,

app/graphql/resolvers/issue_status_counts_resolver.rb

@@ -6,6 +6,8 @@ module Resolvers
 
     type Types::IssueStatusCountsType, null: true
 
+    extras [:lookahead]
+
     def continue_issue_resolve(parent, finder, **args)
       finder.parent_param = parent
       apply_lookahead(Gitlab::IssuablesCountForState.new(finder, parent))

app/graphql/resolvers/users/group_count_resolver.rb

@@ -3,6 +3,8 @@
 module Resolvers
   module Users
     class GroupCountResolver < BaseResolver
+      type GraphQL::INT_TYPE, null: true
+
       alias_method :user, :object
 
       def resolve(**args)

app/graphql/types/terraform/state_type.rb

@@ -19,7 +19,6 @@ module Types
 
       field :locked_by_user, Types::UserType,
             null: true,
-            authorize: :read_user,
             description: 'The user currently holding a lock on the Terraform state'
 
       field :locked_at, Types::TimeType,

app/graphql/types/terraform/state_version_type.rb

@@ -15,7 +15,6 @@ module Types
 
       field :created_by_user, Types::UserType,
             null: true,
-            authorize: :read_user,
             description: 'The user that created this version'
 
       field :download_path, GraphQL::STRING_TYPE,
@@ -24,7 +23,6 @@ module Types
 
       field :job, Types::Ci::JobType,
             null: true,
-            authorize: :read_build,
             description: 'The job that created this version'
 
       field :serial, GraphQL::INT_TYPE,

ee/app/graphql/resolvers/security_report_summary_resolver.rb

@@ -4,6 +4,8 @@ module Resolvers
   class SecurityReportSummaryResolver < BaseResolver
     type Types::SecurityReportSummaryType, null: true
 
+    extras [:lookahead]
+
     alias_method :pipeline, :object
 
     def resolve(lookahead:)

ee/app/graphql/types/instance_security_dashboard_type.rb

@@ -9,7 +9,6 @@ module Types
     field :projects,
           Types::ProjectType.connection_type,
           null: false,
-          authorize: :read_project,
           description: 'Projects selected in Instance Security Dashboard'
 
     field :vulnerability_scanners,

ee/app/graphql/types/vulnerable_projects_by_grade_type.rb

@@ -15,7 +15,6 @@ module Types
 
     field :projects, Types::ProjectType.connection_type, null: false,
           description: 'Projects within this grade',
-          authorize: :read_project,
           complexity: 5
   end
   # rubocop: enable Graphql/AuthorizeTypes