Merge branch 'qa-shl-fix-login-via-oauth-spec' into 'master'

Retry on OTP authentication failure

Closes #35708

See merge request gitlab-org/gitlab!19811

qa/qa/vendor/github/page/login.rb

@@ -12,11 +12,15 @@ module QA
             fill_in 'password', with: QA::Runtime::Env.github_password
             click_on 'Sign in'
 
-            otp = OnePassword::CLI.new.otp
+            Support::Retrier.retry_until(exit_on_failure: true) do
+              otp = OnePassword::CLI.new.otp
 
-            fill_in 'otp', with: otp
+              fill_in 'otp', with: otp
 
-            click_on 'Verify'
+              click_on 'Verify'
+
+              !has_text?('Two-factor authentication failed', wait: 1.0)
+            end
 
             click_on 'Authorize gitlab-qa' if has_button?('Authorize gitlab-qa')
           end