Merge branch 'switch_diff_check_with_paths_changed_rpc_flag_on' into 'master'

Switch diff_check_with_paths_changed_rpc_flag flag to default true

See merge request gitlab-org/gitlab!49803

changelogs/unreleased/switch_diff_check_with_paths_changed_rpc_flag_on.yml

+---
+title: Improve the performance of the diff change access check
+merge_request: 49803
+author:
+type: performance

config/feature_flags/development/diff_check_with_paths_changed_rpc.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/288827
 milestone: '13.7'
 type: development
 group: group::code review
-default_enabled: false
+default_enabled: true

ee/lib/ee/gitlab/checks/diff_check.rb

@@ -58,7 +58,7 @@ module EE
 
         def path_locks_validation
           lambda do |diff|
-            path = if ::Feature.enabled?(:diff_check_with_paths_changed_rpc, project)
+            path = if ::Feature.enabled?(:diff_check_with_paths_changed_rpc, project, default_enabled: true)
                      diff.path
                    else
                      if diff.renamed_file?
@@ -82,7 +82,7 @@ module EE
 
         def file_name_validation
           lambda do |diff|
-            if ::Feature.enabled?(:diff_check_with_paths_changed_rpc, project)
+            if ::Feature.enabled?(:diff_check_with_paths_changed_rpc, project, default_enabled: true)
               if new_file?(diff) && denylisted_regex = push_rule.filename_denylisted?(diff.path)
                 return unless denylisted_regex.present?
 

lib/gitlab/checks/diff_check.rb

@@ -17,7 +17,7 @@ module Gitlab
 
         file_paths = []
 
-        if ::Feature.enabled?(:diff_check_with_paths_changed_rpc, project)
+        if ::Feature.enabled?(:diff_check_with_paths_changed_rpc, project, default_enabled: true)
           paths = project.repository.find_changed_paths(commits.map(&:sha))
           paths.each do |path|
             file_paths.concat([path.path])