Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
348225aa
Commit
348225aa
authored
Jun 23, 2021
by
Changzheng Liu
Committed by
Tetiana Chupryna
Jun 23, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update the placeholder text of global search navbar
parent
ece74fba
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
5 deletions
+14
-5
app/views/layouts/_search.html.haml
app/views/layouts/_search.html.haml
+2
-2
locale/gitlab.pot
locale/gitlab.pot
+3
-3
spec/views/layouts/_search.html.haml_spec.rb
spec/views/layouts/_search.html.haml_spec.rb
+9
-0
No files found.
app/views/layouts/_search.html.haml
View file @
348225aa
...
...
@@ -3,14 +3,14 @@
.search-input-container
.search-input-wrap
.dropdown
{
data:
{
url:
search_autocomplete_path
}
}
=
search_field_tag
'search'
,
nil
,
placeholder:
_
(
'Search
or jump to…
'
),
=
search_field_tag
'search'
,
nil
,
placeholder:
_
(
'Search
GitLab
'
),
class:
'search-input dropdown-menu-toggle no-outline js-search-dashboard-options'
,
spellcheck:
false
,
autocomplete:
'off'
,
data:
{
issues_path:
issues_dashboard_path
,
mr_path:
merge_requests_dashboard_path
,
qa_selector:
'search_term_field'
},
aria:
{
label:
_
(
'Search
or jump to…
'
)
}
aria:
{
label:
_
(
'Search
GitLab
'
)
}
%button
.hidden.js-dropdown-search-toggle
{
type:
'button'
,
data:
{
toggle:
'dropdown'
}
}
.dropdown-menu.dropdown-select
{
data:
{
testid:
'dashboard-search-options'
}
}
=
dropdown_content
do
...
...
locale/gitlab.pot
View file @
348225aa
...
...
@@ -28357,6 +28357,9 @@ msgstr ""
msgid "Search"
msgstr ""
msgid "Search GitLab"
msgstr ""
msgid "Search Jira issues"
msgstr ""
...
...
@@ -28441,9 +28444,6 @@ msgstr ""
msgid "Search or filter results…"
msgstr ""
msgid "Search or jump to…"
msgstr ""
msgid "Search project"
msgstr ""
...
...
spec/views/layouts/_search.html.haml_spec.rb
View file @
348225aa
...
...
@@ -25,6 +25,15 @@ RSpec.describe 'layouts/_search' do
end
shared_examples
'search context scope is set'
do
context
'when rendering'
do
it
'sets the placeholder'
do
render
expect
(
rendered
).
to
include
(
'placeholder="Search GitLab"'
)
expect
(
rendered
).
to
include
(
'aria-label="Search GitLab"'
)
end
end
context
'when on issues'
do
it
'sets scope to issues'
do
render
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment