Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
35b1c1a5
Commit
35b1c1a5
authored
Sep 01, 2021
by
Sean Arnold
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename method, remove change to worker scope
parent
dda6ed2b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
13 deletions
+3
-13
app/workers/ci/archive_trace_worker.rb
app/workers/ci/archive_trace_worker.rb
+1
-11
lib/gitlab/ci/trace.rb
lib/gitlab/ci/trace.rb
+2
-2
No files found.
app/workers/ci/archive_trace_worker.rb
View file @
35b1c1a5
...
...
@@ -11,20 +11,10 @@ module Ci
# rubocop: disable CodeReuse/ActiveRecord
def
perform
(
job_id
)
ci_build_scop
e
.
find_by
(
id:
job_id
).
try
do
|
job
|
Ci
::
Build
.
without_archived_trac
e
.
find_by
(
id:
job_id
).
try
do
|
job
|
Ci
::
ArchiveTraceService
.
new
.
execute
(
job
,
worker_name:
self
.
class
.
name
)
end
end
# rubocop: enable CodeReuse/ActiveRecord
private
def
ci_build_scope
if
Feature
.
enabled?
(
:ci_enable_live_trace
)
Ci
::
Build
.
with_live_trace
else
Ci
::
Build
.
without_archived_trace
end
end
end
end
lib/gitlab/ci/trace.rb
View file @
35b1c1a5
...
...
@@ -191,7 +191,7 @@ module Gitlab
def
unsafe_archive!
raise
ArchiveError
,
'Job is not finished yet'
unless
job
.
complete?
unsafe_trace_c
leanup
!
unsafe_trace_c
onditionally_cleanup_before_retry
!
if
job
.
trace_chunks
.
any?
Gitlab
::
Ci
::
Trace
::
ChunkedIO
.
new
(
job
)
do
|
stream
|
...
...
@@ -217,7 +217,7 @@ module Gitlab
trace_artifact
&
.
archived_trace_exists?
end
def
unsafe_trace_c
leanup
!
def
unsafe_trace_c
onditionally_cleanup_before_retry
!
return
unless
trace_artifact
if
already_archived?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment