Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
36147aa4
Commit
36147aa4
authored
Mar 14, 2022
by
Alina Mihaila
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add note for Impact Check for query changes
parent
4be7b092
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
0 deletions
+1
-0
doc/development/service_ping/review_guidelines.md
doc/development/service_ping/review_guidelines.md
+1
-0
No files found.
doc/development/service_ping/review_guidelines.md
View file @
36147aa4
...
...
@@ -57,6 +57,7 @@ are regular backend changes.
generating the metric's YAML definition.
-
Add the
`~database`
label and ask for a
[
database review
](
../database_review.md
)
for
metrics that are based on Database.
-
Add
`~Data Warehouse::Impact Check`
for any database metric that has a query change.
-
For tracking using Redis HLL (HyperLogLog):
-
Check the Redis slot.
-
Check if a
[
feature flag is needed
](
implement.md#recommendations
)
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment