Fix use of project_name instead of project_key for import

Correctly generate key and slug for bitbucket server importer

app/serializers/import/bitbucket_server_provider_repo_entity.rb

 # frozen_string_literal: true
 
 class Import::BitbucketServerProviderRepoEntity < Import::BitbucketProviderRepoEntity
+  expose :id, override: true do |repo|
+    "#{repo.project_key}/#{repo.slug}"
+  end
+
   expose :provider_link, override: true do |repo, options|
     repo.browse_url
   end

changelogs/unreleased/xanf-fix-bitbucket-server-importer-key.yml

+---
+title: Fix failing bitbucket server import when project slug differs from name
+merge_request: 39433
+author:
+type: fixed

spec/controllers/import/bitbucket_server_controller_spec.rb

@@ -33,15 +33,18 @@ RSpec.describe Import::BitbucketServerController do
   describe 'POST create' do
     let(:project_name) { "my-project_123" }
 
+    # rubocop: disable CodeReuse/ActiveRecord
     before do
       allow(controller).to receive(:client).and_return(client)
       repo = double(name: project_name)
       allow(client).to receive(:repo).with(project_key, repo_slug).and_return(repo)
       assign_session_tokens
     end
+    # rubocop: enable CodeReuse/ActiveRecord
 
     let_it_be(:project) { create(:project) }
 
+    # rubocop: disable CodeReuse/ActiveRecord
     it 'returns the new project' do
       allow(Gitlab::BitbucketServerImport::ProjectCreator)
         .to receive(:new).with(project_key, repo_slug, anything, project_name, user.namespace, user, anything)
@@ -51,10 +54,12 @@ RSpec.describe Import::BitbucketServerController do
 
       expect(response).to have_gitlab_http_status(:ok)
     end
+    # rubocop: enable CodeReuse/ActiveRecord
 
     context 'with project key with tildes' do
       let(:project_key) { '~someuser_123' }
 
+      # rubocop: disable CodeReuse/ActiveRecord
       it 'successfully creates a project' do
         allow(Gitlab::BitbucketServerImport::ProjectCreator)
           .to receive(:new).with(project_key, repo_slug, anything, project_name, user.namespace, user, anything)
@@ -64,6 +69,7 @@ RSpec.describe Import::BitbucketServerController do
 
         expect(response).to have_gitlab_http_status(:ok)
       end
+      # rubocop: enable CodeReuse/ActiveRecord
     end
 
     it 'returns an error when an invalid project key is used' do
@@ -78,6 +84,7 @@ RSpec.describe Import::BitbucketServerController do
       expect(response).to have_gitlab_http_status(:unprocessable_entity)
     end
 
+    # rubocop: disable CodeReuse/ActiveRecord
     it 'returns an error when the project cannot be found' do
       allow(client).to receive(:repo).with(project_key, repo_slug).and_return(nil)
 
@@ -85,7 +92,9 @@ RSpec.describe Import::BitbucketServerController do
 
       expect(response).to have_gitlab_http_status(:unprocessable_entity)
     end
+    # rubocop: enable CodeReuse/ActiveRecord
 
+    # rubocop: disable CodeReuse/ActiveRecord
     it 'returns an error when the project cannot be saved' do
       allow(Gitlab::BitbucketServerImport::ProjectCreator)
         .to receive(:new).with(project_key, repo_slug, anything, project_name, user.namespace, user, anything)
@@ -95,7 +104,9 @@ RSpec.describe Import::BitbucketServerController do
 
       expect(response).to have_gitlab_http_status(:unprocessable_entity)
     end
+    # rubocop: enable CodeReuse/ActiveRecord
 
+    # rubocop: disable CodeReuse/ActiveRecord
     it "returns an error when the server can't be contacted" do
       allow(client).to receive(:repo).with(project_key, repo_slug).and_raise(::BitbucketServer::Connection::ConnectionError)
 
@@ -103,6 +114,7 @@ RSpec.describe Import::BitbucketServerController do
 
       expect(response).to have_gitlab_http_status(:unprocessable_entity)
     end
+    # rubocop: enable CodeReuse/ActiveRecord
 
     it_behaves_like 'project import rate limiter'
   end
@@ -139,8 +151,6 @@ RSpec.describe Import::BitbucketServerController do
   describe 'GET status' do
     render_views
 
-    let(:repos) { instance_double(BitbucketServer::Collection) }
-
     before do
       allow(controller).to receive(:client).and_return(client)
 
@@ -157,14 +167,14 @@ RSpec.describe Import::BitbucketServerController do
 
       expect(response).to have_gitlab_http_status(:ok)
       expect(json_response['incompatible_repos'].length).to eq(1)
-      expect(json_response.dig("incompatible_repos", 0, "id")).to eq(@invalid_repo.full_name)
+      expect(json_response.dig("incompatible_repos", 0, "id")).to eq("#{@invalid_repo.project_key}/#{@invalid_repo.slug}")
       expect(json_response['provider_repos'].length).to eq(1)
       expect(json_response.dig("provider_repos", 0, "id")).to eq(@repo.full_name)
     end
 
     it_behaves_like 'import controller status' do
       let(:repo) { @repo }
-      let(:repo_id) { @repo.full_name }
+      let(:repo_id) { "#{@repo.project_key}/#{@repo.slug}" }
       let(:import_source) { @repo.browse_url }
       let(:provider_name) { 'bitbucket_server' }
       let(:client_repos_field) { :repos }

spec/serializers/import/bitbucket_server_provider_repo_entity_spec.rb

@@ -6,8 +6,10 @@ RSpec.describe Import::BitbucketServerProviderRepoEntity do
   let(:repo_data) do
     {
       'name' => 'test',
+      'slug' => 'TEST',
       'project' => {
-        'name' => 'demo'
+        'name' => 'demo',
+        'key' => 'DEM'
       },
       'links' => {
         'self' => [
@@ -27,7 +29,7 @@ RSpec.describe Import::BitbucketServerProviderRepoEntity do
   it_behaves_like 'exposes required fields for import entity' do
     let(:expected_values) do
       {
-        id: 'demo/test',
+        id: 'DEM/TEST',
         full_name: 'demo/test',
         sanitized_name: 'test',
         provider_link: 'http://local.bitbucket.server/demo/test.git'