Commit 38da5d6b authored by Lin Jen-Shin's avatar Lin Jen-Shin

Merge branch 'qa-fix-review-app-ping' into 'master'

Don't fail the job if the Review App doesn't deploy properly

See merge request gitlab-org/gitlab-ce!27223
parents cfa5c307 955136b5
...@@ -109,7 +109,7 @@ function perform_review_app_deployment() { ...@@ -109,7 +109,7 @@ function perform_review_app_deployment() {
ensure_namespace ensure_namespace
install_tiller install_tiller
install_external_dns install_external_dns
time deploy || true time deploy
wait_for_review_app_to_be_accessible wait_for_review_app_to_be_accessible
add_license add_license
} }
...@@ -270,7 +270,7 @@ EOF ...@@ -270,7 +270,7 @@ EOF
echoinfo "Deploying with:" echoinfo "Deploying with:"
echoinfo "${HELM_CMD}" echoinfo "${HELM_CMD}"
eval $HELM_CMD eval $HELM_CMD || true
} }
function wait_for_review_app_to_be_accessible() { function wait_for_review_app_to_be_accessible() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment