Merge branch '194165-remove-code-reivew-analytics-feature-flag' into 'master'

Remove Code Review Analytics feature flag

Closes #194165

See merge request gitlab-org/gitlab!23418

doc/user/analytics/code_review_analytics.md

@@ -47,13 +47,3 @@ and trends between them. For example:
 
 - On [Starter or Bronze tier](https://about.gitlab.com/pricing/) and above.
 - By users with Reporter access and above.
-
-## Disable with feature flag
-
-Code Review Analytics is [currently enabled by a feature flag](https://gitlab.com/gitlab-org/gitlab/issues/194165)
-that defaults to ON, meaning the feature is available. If you experience performance problems or
-otherwise wish to disable the feature, a GitLab administrator can execute a command in a Rails console:
-
-```ruby
-Feature.disable(:code_review_analytics)
-```

doc/user/analytics/index.md

@@ -15,8 +15,7 @@ Once enabled, click on **Analytics** from the top navigation bar.
 
 From the centralized analytics workspace, the following analytics are available:
 
-- [Code Review Analytics](code_review_analytics.md), enabled with the `code_review_analytics`
-  [feature flag](../../development/feature_flags/development.md#enabling-a-feature-flag-in-development). **(STARTER)**
+- [Code Review Analytics](code_review_analytics.md). **(STARTER)**
 - [Cycle Analytics](cycle_analytics.md), enabled with the `cycle_analytics`
   [feature flag](../../development/feature_flags/development.md#enabling-a-feature-flag-in-development). **(PREMIUM)**
 - [Productivity Analytics](productivity_analytics.md), enabled with the `productivity_analytics`

ee/app/helpers/ee/projects_helper.rb

@@ -59,7 +59,7 @@ module EE
         nav_tabs << :packages
       end
 
-      if ::Feature.enabled?(:code_review_analytics, project, default_enabled: true)
+      if can?(current_user, :read_code_review_analytics, project)
         nav_tabs << :code_review
       end
 

ee/app/views/layouts/nav/sidebar/_project_analytics_link.html.haml

-- if Feature.enabled?(:code_review_analytics, default_enabled: true) && can?(current_user, :read_code_review_analytics, @project)
+- if can?(current_user, :read_code_review_analytics, @project)
   - project_analytics_link = project_analytics_code_reviews_path(@project)
 
   = nav_link controller: :code_review do

ee/changelogs/unreleased/194165-remove-code-reivew-analytics-feature-flag.yml

+---
+title: Remove Code Review Analytics feature flag
+merge_request: 23418
+author:
+type: changed

ee/config/routes/project.rb

@@ -79,9 +79,7 @@ constraints(::Constraints::ProjectUrlConstrainer.new) do
         resources :audit_events, only: [:index]
 
         namespace :analytics do
-          constraints(::Constraints::FeatureConstrainer.new(:code_review_analytics, default_enabled: true)) do
-            resources :code_reviews, only: [:index]
-          end
+          resources :code_reviews, only: [:index]
         end
 
         draw :merge_requests_ee

ee/lib/api/analytics/code_review_analytics.rb

@@ -28,10 +28,6 @@ module API
         end
       end
 
-      before do
-        not_found! unless Feature.enabled?(:code_review_analytics, default_enabled: true)
-      end
-
       resource :analytics do
         desc 'List code review information about project' do
         end

ee/spec/features/analytics/code_analytics_spec.rb

@@ -14,28 +14,22 @@ describe 'CodeReviewAnalytics', :js do
     project.add_reporter(user)
 
     sign_in(user)
-  end
-
-  context 'when the feature is enabled' do
-    before do
-      stub_feature_flags(code_review_analytics: true)
 
-      visit project_analytics_code_reviews_path(project)
-    end
+    visit project_analytics_code_reviews_path(project)
+  end
 
-    it 'renders the filtered search bar correctly' do
-      page.within('.content-wrapper .content .issues-filters') do
-        expect(page).to have_css('.filtered-search-box')
-      end
+  it 'renders the filtered search bar correctly' do
+    page.within('.content-wrapper .content .issues-filters') do
+      expect(page).to have_css('.filtered-search-box')
     end
+  end
 
-    it 'displays label and milestone in search hint' do
-      filtered_search.click
+  it 'displays label and milestone in search hint' do
+    filtered_search.click
 
-      page.within('#js-dropdown-hint') do
-        expect(page).to have_content('Label')
-        expect(page).to have_content('Milestone')
-      end
+    page.within('#js-dropdown-hint') do
+      expect(page).to have_content('Label')
+      expect(page).to have_content('Milestone')
     end
   end
 end

ee/spec/requests/api/analytics/code_review_analytics_spec.rb

@@ -56,18 +56,6 @@ describe API::Analytics::CodeReviewAnalytics do
       end
     end
 
-    context 'when feature is disabled' do
-      before do
-        stub_feature_flags(code_review_analytics: false)
-      end
-
-      it 'is not found' do
-        api_call
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
-
     context 'when user has no authorization' do
       let(:current_user) { guest }
 

ee/spec/requests/projects/analytics/code_reviews_controller_spec.rb

@@ -8,7 +8,6 @@ describe Projects::Analytics::CodeReviewsController, type: :request do
 
   before do
     login_as user
-    stub_feature_flags(code_review_analytics: true)
   end
 
   describe 'GET /*namespace_id/:project_id/analytics/code_reviews' do