Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3ad89725
Commit
3ad89725
authored
Jun 10, 2020
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prefer to use symbols for feature flag names
This prefers to use symbols where possible for feature flag names
parent
dee19c97
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
7 additions
and
7 deletions
+7
-7
app/models/ci/build_dependencies.rb
app/models/ci/build_dependencies.rb
+1
-1
doc/administration/job_artifacts.md
doc/administration/job_artifacts.md
+2
-2
doc/administration/job_logs.md
doc/administration/job_logs.md
+2
-2
ee/lib/gitlab/geo.rb
ee/lib/gitlab/geo.rb
+1
-1
lib/gitlab/ci/trace.rb
lib/gitlab/ci/trace.rb
+1
-1
No files found.
app/models/ci/build_dependencies.rb
View file @
3ad89725
...
...
@@ -45,7 +45,7 @@ module Ci
end
def
valid_local?
return
true
if
Feature
.
enabled?
(
'ci_disable_validates_dependencies'
)
return
true
if
Feature
.
enabled?
(
:ci_disable_validates_dependencies
)
local
.
all?
(
&
:valid_dependency?
)
end
...
...
doc/administration/job_artifacts.md
View file @
3ad89725
...
...
@@ -351,7 +351,7 @@ you can flip the feature flag from a Rails console.
1.
Flip the switch and disable it:
```
ruby
Feature
.
enable
(
'ci_disable_validates_dependencies'
)
Feature
.
enable
(
:ci_disable_validates_dependencies
)
```
**In installations from source:**
...
...
@@ -366,7 +366,7 @@ you can flip the feature flag from a Rails console.
1.
Flip the switch and disable it:
```
ruby
Feature
.
enable
(
'ci_disable_validates_dependencies'
)
Feature
.
enable
(
:ci_disable_validates_dependencies
)
```
## Set the maximum file size of the artifacts
...
...
doc/administration/job_logs.md
View file @
3ad89725
...
...
@@ -128,13 +128,13 @@ sudo -u git -H bin/rails console -e production
**To check if incremental logging (trace) is enabled:**
```
ruby
Feature
.
enabled?
(
'ci_enable_live_trace'
)
Feature
.
enabled?
(
:ci_enable_live_trace
)
```
**To enable incremental logging (trace):**
```
ruby
Feature
.
enable
(
'ci_enable_live_trace'
)
Feature
.
enable
(
:ci_enable_live_trace
)
```
NOTE:
**Note:**
...
...
ee/lib/gitlab/geo.rb
View file @
3ad89725
...
...
@@ -128,7 +128,7 @@ module Gitlab
end
def
self
.
repository_verification_enabled?
Feature
.
enabled?
(
'geo_repository_verification'
,
default_enabled:
true
)
Feature
.
enabled?
(
:geo_repository_verification
,
default_enabled:
true
)
end
def
self
.
allowed_ip?
(
ip
)
...
...
lib/gitlab/ci/trace.rb
View file @
3ad89725
...
...
@@ -147,7 +147,7 @@ module Gitlab
raise
AlreadyArchivedError
,
'Could not write to the archived trace'
elsif
current_path
File
.
open
(
current_path
,
mode
)
elsif
Feature
.
enabled?
(
'ci_enable_live_trace'
,
job
.
project
)
elsif
Feature
.
enabled?
(
:ci_enable_live_trace
,
job
.
project
)
Gitlab
::
Ci
::
Trace
::
ChunkedIO
.
new
(
job
)
else
File
.
open
(
ensure_path
,
mode
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment