Merge branch 'issue#325836-fix-empty-line-after-let-it-be-error-tracking-module' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses for error tracking module

See merge request gitlab-org/gitlab!58182

.rubocop_manual_todo.yml

@@ -805,9 +805,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/features/cycle_analytics_spec.rb
     - spec/features/dashboard/datetime_on_tooltips_spec.rb
     - spec/features/dashboard/merge_requests_spec.rb
-    - spec/features/error_tracking/user_filters_errors_by_status_spec.rb
-    - spec/features/error_tracking/user_searches_sentry_errors_spec.rb
-    - spec/features/error_tracking/user_sees_error_index_spec.rb
     - spec/features/file_uploads/group_import_spec.rb
     - spec/features/file_uploads/project_import_spec.rb
     - spec/features/file_uploads/user_avatar_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-error-tracking-module.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses for error tracking module
+merge_request: 58182
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/features/error_tracking/user_filters_errors_by_status_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe 'When a user filters Sentry errors by status', :js, :use_clean_ra
 
   let_it_be(:issues_response_body) { fixture_file('sentry/issues_sample_response.json') }
   let_it_be(:filtered_errors_by_status_response) { Gitlab::Json.parse(issues_response_body).filter { |error| error['status'] == 'ignored' }.to_json }
+
   let(:issues_api_url) { "#{sentry_api_urls.issues_url}?limit=20&query=is:unresolved" }
   let(:issues_api_url_filter) { "#{sentry_api_urls.issues_url}?limit=20&query=is:ignored" }
   let(:auth_token) {{ 'Authorization' => 'Bearer access_token_123' }}

spec/features/error_tracking/user_searches_sentry_errors_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe 'When a user searches for Sentry errors', :js, :use_clean_rails_m
 
   let_it_be(:issues_response_body) { fixture_file('sentry/issues_sample_response.json') }
   let_it_be(:error_search_response_body) { fixture_file('sentry/error_list_search_response.json') }
+
   let(:issues_api_url) { "#{sentry_api_urls.issues_url}?limit=20&query=is:unresolved" }
   let(:issues_api_url_search) { "#{sentry_api_urls.issues_url}?limit=20&query=is:unresolved%20NotFound" }
 

spec/features/error_tracking/user_sees_error_index_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe 'View error index page', :js, :use_clean_rails_memory_store_cachi
 
   let_it_be(:issues_response_body) { fixture_file('sentry/issues_sample_response.json') }
   let_it_be(:issues_response) { Gitlab::Json.parse(issues_response_body) }
+
   let(:issues_api_url) { "#{sentry_api_urls.issues_url}?limit=20&query=is:unresolved" }
 
   before do