Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3c40236f
Commit
3c40236f
authored
Jan 23, 2020
by
Donald Cook
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Removed epic_new_issue feature flag references
Cleaned up tests for it too
parent
5e532c2c
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
33 deletions
+8
-33
ee/app/assets/javascripts/related_items_tree/components/related_items_tree_app.vue
.../related_items_tree/components/related_items_tree_app.vue
+0
-4
ee/app/controllers/groups/epics_controller.rb
ee/app/controllers/groups/epics_controller.rb
+0
-1
ee/spec/features/epics/epic_issues_spec.rb
ee/spec/features/epics/epic_issues_spec.rb
+7
-18
ee/spec/frontend/related_items_tree/components/related_items_tree_app_spec.js
...ated_items_tree/components/related_items_tree_app_spec.js
+1
-10
No files found.
ee/app/assets/javascripts/related_items_tree/components/related_items_tree_app.vue
View file @
3c40236f
...
...
@@ -67,9 +67,6 @@ export default {
disableContents
()
{
return
this
.
itemAddInProgress
||
this
.
itemCreateInProgress
;
},
createIssueEnabled
()
{
return
gon
.
features
&&
gon
.
features
.
epicNewIssue
;
},
visibleForm
()
{
if
(
this
.
showAddItemForm
)
{
return
FORM_SLOTS
.
addItem
;
...
...
@@ -169,7 +166,6 @@ export default {
>
<related-items-tree-header
:class=
"
{ 'border-bottom-0': itemsFetchResultEmpty }">
<issue-actions-split-button
v-if=
"createIssueEnabled"
slot=
"issueActions"
class=
"ml-1"
@
showAddIssueForm=
"showAddIssueForm"
...
...
ee/app/controllers/groups/epics_controller.rb
View file @
3c40236f
...
...
@@ -19,7 +19,6 @@ class Groups::EpicsController < Groups::ApplicationController
before_action
do
push_frontend_feature_flag
(
:roadmap_graphql
,
@group
)
push_frontend_feature_flag
(
:vue_issuable_epic_sidebar
,
@group
)
push_frontend_feature_flag
(
:epic_new_issue
,
@group
,
default_enabled:
true
)
end
def
index
...
...
ee/spec/features/epics/epic_issues_spec.rb
View file @
3c40236f
...
...
@@ -40,10 +40,6 @@ describe 'Epic Issues', :js do
wait_for_requests
end
before
do
stub_feature_flags
(
epic_new_issue:
false
)
end
context
'when user is not a group member of a public group'
do
before
do
visit_epic
...
...
@@ -203,23 +199,16 @@ describe 'Epic Issues', :js do
end
end
context
'with epic_new_issue feature flag enabled'
do
before
do
stub_feature_flags
(
epic_new_issue:
true
)
visit_epic
end
it
'user can add new issues to the epic'
do
references
=
"
#{
issue_to_add
.
to_reference
(
full:
true
)
}
"
it
'user can add new issues to the epic'
do
references
=
"
#{
issue_to_add
.
to_reference
(
full:
true
)
}
"
add_issues
(
references
,
button_selector:
'.js-issue-actions-split-button'
)
add_issues
(
references
,
button_selector:
'.js-issue-actions-split-button'
)
expect
(
page
).
not_to
have_selector
(
'.gl-field-error'
)
expect
(
page
).
not_to
have_content
(
"Issue cannot be found."
)
expect
(
page
).
not_to
have_selector
(
'.gl-field-error'
)
expect
(
page
).
not_to
have_content
(
"Issue cannot be found."
)
within
(
'.related-items-tree-container ul.related-items-list'
)
do
expect
(
page
).
to
have_selector
(
'li.js-item-type-issue'
,
count:
3
)
end
within
(
'.related-items-tree-container ul.related-items-list'
)
do
expect
(
page
).
to
have_selector
(
'li.js-item-type-issue'
,
count:
3
)
end
end
...
...
ee/spec/frontend/related_items_tree/components/related_items_tree_app_spec.js
View file @
3c40236f
...
...
@@ -241,27 +241,18 @@ describe('RelatedItemsTreeApp', () => {
});
});
it
(
'
does not render issue actions split button
'
,
()
=>
{
expect
(
findIssueActionsSplitButton
().
exists
()).
toBe
(
false
);
});
it
(
'
does not render create issue form
'
,
()
=>
{
expect
(
findCreateIssueForm
().
exists
()).
toBe
(
false
);
});
});
describe
(
'
with epicNewIssue feature flag enabled
'
,
()
=>
{
describe
(
'
issue actions split button
'
,
()
=>
{
beforeEach
(()
=>
{
window
.
gon
.
features
=
{
epicNewIssue
:
true
};
wrapper
=
createComponent
();
wrapper
.
vm
.
$store
.
state
.
itemsFetchInProgress
=
false
;
return
wrapper
.
vm
.
$nextTick
();
});
afterEach
(()
=>
{
window
.
gon
.
features
=
{};
});
it
(
'
renders issue actions split button
'
,
()
=>
{
expect
(
findIssueActionsSplitButton
().
exists
()).
toBe
(
true
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment